Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp11264084imu; Thu, 6 Dec 2018 14:27:14 -0800 (PST) X-Google-Smtp-Source: AFSGD/VaSXy9MpMvTWjrr0Jwi3sN8S676MujN401lelrjkmw0eC4HGRIUhcw528wIRxyrHSmaCd9 X-Received: by 2002:a62:113:: with SMTP id 19mr29829176pfb.176.1544135234137; Thu, 06 Dec 2018 14:27:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544135234; cv=none; d=google.com; s=arc-20160816; b=gAEgcmB1OhFLfq0JrbeeJn8S82kKOfj3sK267E1U7xl8IEBAgrq8ilRH8ew5CLfmdS iIHVb0uryCjUMmSWyc48r7Z0LfQISaZGkVatRwQzQ2rxq9K4SwoytgzD6DA0d5NDLNDc J0+J+AqrsMK8yeoec3gzvPBsnM3d6blJ9gtYDxWHgJdpG4mHMlt1Q9zicTaJS3vRwdj+ xxUgI4vLZfgvhPL/EIVlb2okWF0z+hLlor9ATs3yYFRzyx/aJ4qg0bdotSPEeXkzjUMJ audvg19U80l7+GF94ygGFt7UVL+cklR96zpklk2tp69L3/XMiJ5miMZd0qyqcSSQlkWb 3rBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=JUg58sWoKwNVB0qIJhvx4Kz/WQpJ4zUQFfWhkt4Uzf0=; b=sGcgR7hVpHR6XiHoZeHeHXkZwo0GA6xUeK19lWZhC8mQy8Fl3DsO/aClj+QIWN+syq Dms+gPnNTXYXjT8ZDUEz5uq9wxzCufhcL/QAttSBIK5oX6DXVy5mNHD4kXPF9zVRNLCJ uircyIIE98ZsPES34wOZDPeBzo3rgnJhy+95URJcbr4nBFXYiFLIvsMXVfTbsKYpbrVq rtZ4tJp0R87yRHAYDWLgimdPJgsCmSLui7VrAZE3LkQ2SuohiScCFZ+p8H5eeKRY9rVG eH7hDjn6JREx/WFnHVX/glM/SQO/ICtsLUTo8OUAsm09U63pUgf/CkSak3WfYSpHo+4q 6ekw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n32si1214401pgm.439.2018.12.06.14.26.58; Thu, 06 Dec 2018 14:27:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726053AbeLFW0N (ORCPT + 99 others); Thu, 6 Dec 2018 17:26:13 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:38538 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbeLFW0M (ORCPT ); Thu, 6 Dec 2018 17:26:12 -0500 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23990411AbeLFWYXY4dWP (ORCPT + 1 other); Thu, 6 Dec 2018 23:24:23 +0100 Date: Thu, 6 Dec 2018 23:24:22 +0100 From: Ladislav Michl To: Stephen Rothwell Cc: Mark Brown , Liam Girdwood , Linux Next Mailing List , Linux Kernel Mailing List , Kuninori Morimoto , anish kumar , alsa-devel@alsa-project.org Subject: [PATCH v2] ASoC: max9867: Remove useless assignment Message-ID: <20181206222422.GA29787@lenoch> References: <20181207080122.20d3d342@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181207080122.20d3d342@canb.auug.org.au> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ret is assigned later, no need to initialize it. Signed-off-by: Ladislav Michl --- CHANGES: -v2: add missing Signed-off-by (I'm sorry for that...) sound/soc/codecs/max9867.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c index 1cda54b59854..1b155f40b106 100644 --- a/sound/soc/codecs/max9867.c +++ b/sound/soc/codecs/max9867.c @@ -476,7 +476,7 @@ static int max9867_i2c_probe(struct i2c_client *i2c, const struct i2c_device_id *id) { struct max9867_priv *max9867; - int ret = 0, reg; + int ret, reg; max9867 = devm_kzalloc(&i2c->dev, sizeof(*max9867), GFP_KERNEL); if (!max9867) @@ -497,10 +497,8 @@ static int max9867_i2c_probe(struct i2c_client *i2c, dev_info(&i2c->dev, "device revision: %x\n", reg); ret = devm_snd_soc_register_component(&i2c->dev, &max9867_component, max9867_dai, ARRAY_SIZE(max9867_dai)); - if (ret < 0) { + if (ret < 0) dev_err(&i2c->dev, "Failed to register component: %d\n", ret); - return ret; - } return ret; } -- 2.20.0.rc2