Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1544163250.3008.7.camel@suse.de>
Subject: Re: [PATCH] mm, kmemleak: Little optimization while scanning
From:   Oscar Salvador <osalvador@suse.de>
To:     Wei Yang <richard.weiyang@gmail.com>
Cc:     akpm@linux-foundation.org, catalin.marinas@arm.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org, mhocko@suse.com
Date:   Fri, 07 Dec 2018 07:14:10 +0100
In-Reply-To: <20181207041528.xs4xnw6vpsbu5csx@master>
References: <20181206131918.25099-1-osalvador@suse.de>
         <20181207041528.xs4xnw6vpsbu5csx@master>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> > +
> 
> This one maybe not necessary.

Yeah, that is a remind of an include file I used for time measurement.
I hope Andrew can drop that if this is taken.

> > /*
> >  * Kmemleak configuration and common defines.
> >  */
> > @@ -1547,11 +1548,14 @@ static void kmemleak_scan(void)
> > 		unsigned long pfn;
> > 
> > 		for (pfn = start_pfn; pfn < end_pfn; pfn++) {
> > -			struct page *page;
> > +			struct page *page =
> > pfn_to_online_page(pfn);
> > +
> > +			if (!page)
> > +				continue;
> > 
> > -			if (!pfn_valid(pfn))
> > +			/* only scan pages belonging to this node
> > */
> > +			if (page_to_nid(page) != i)
> > 				continue;
> 
> Not farmiliar with this situation. Is this often?
Well, hard to tell how often that happens because that mostly depends
on the Hardware in case of baremetal.
Virtual systems can also have it though.

> 
> > -			page = pfn_to_page(pfn);
> > 			/* only scan if page is in use */
> > 			if (page_count(page) == 0)
> > 				continue;
> > -- 
> > 2.13.7
> 
> 
-- 
Oscar Salvador
SUSE L3