Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp219849imu; Thu, 6 Dec 2018 23:16:35 -0800 (PST) X-Google-Smtp-Source: AFSGD/WpHisSGyge0P1eSLc7bh33hJQ3sepvLZK/lqKP9NGfp8K6VVBVnf10c+zyu3No7HcL9vT9 X-Received: by 2002:a63:d104:: with SMTP id k4mr955512pgg.227.1544166995002; Thu, 06 Dec 2018 23:16:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544166994; cv=none; d=google.com; s=arc-20160816; b=nVQHUwIkuFDApQxRcmB4gk7f5JUx/kAGY+buUkMfBew2gq/26fQ4ml35yWzG4OKQem k2Y8CO+WHVeS34ytxqgcyBkDiydK6Yl+jAdvpYvvuqSyr7dNpFhrGbu/XX9eJ+40mEsS xvH0BzkIRC+GMhgnxvUl2CkyIS4inS+yDj/bpOjjJvhQ7DGCIf77FVJ3mpEvlsYEol5i xOAdkXEN5DN90IsE3BrRoEYAbXYIxglrLz1uOaMhCWJwu4c+qrvZ2QwF1T+3WxRGim/R U1urBM1Toi86aobW/RXQQc0kwJapDwvL9FZ5HANR1mbAftbwIx9+jk4vXiCHyGnRz2EK xR4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=pOM5bWKqZrOBmIPZjfRd9wL/pFrrCsgHlchxLX5LM28=; b=Rdn0mkWofDvU39bj0CJntzvcC7ucbEqC/SPA+VWHmbsKi7RUq2sPKS1W4C7ZDbz+vv LBsXrVaWik9KTyHdZzhBN/8EaDOY3LA//zdCeiN54wCvIZSK9sSItVg9QGXKgV5nEYP+ +GfVkqNgi8+0uL9Xkw+mRj6gaxkuA8ByCu3s2aEuK1FfNGWR+pnjlaWqJ07Ioe15Yb8Q eB+OSSaP88IDZMAtzAaJTomF7V/sUpAl6/xvOkCri+JsvIdeCyXCtbm0mwm6S0EI2Uac kh0agIJjvOZ42rmDhpOQiG2E7JFdrCWEkuBGi0p+5jH6AD2Qr4dwp6O9yglhLvzlF49L 9lAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="S/pn/fls"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 2si2078952pgj.104.2018.12.06.23.16.18; Thu, 06 Dec 2018 23:16:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="S/pn/fls"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726011AbeLGHIc (ORCPT + 99 others); Fri, 7 Dec 2018 02:08:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:41572 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbeLGHIc (ORCPT ); Fri, 7 Dec 2018 02:08:32 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ABABD20850; Fri, 7 Dec 2018 07:08:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544166511; bh=/o3XxVTymMGUS4eUzSdcg6eMG+Jiix9BIi10ojsKqRo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S/pn/flsSa8NpTdrVmM7HCoH7p1ouomT5qQLRfpadYExd8XT3tML3cjw3MbjIrN5z 3+v0FwXFfbFSy6Czx9Q1lnYosjifZy+N20+Twwo/iDheq3x+tegbUlCsfYfIZd+UOw D04/LR15laBZYoJk9xFCoPXeWy+EXmIq7iFWuFD4= Date: Fri, 7 Dec 2018 08:08:28 +0100 From: Greg Kroah-Hartman To: Todd Kjos Cc: "open list:ANDROID DRIVERS" , Todd Kjos , LKML , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Martijn Coenen , joel@joelfernandes.org, Android Kernel Team Subject: Re: [PATCH v2 1/3] binder: fix sparse warnings on locking context Message-ID: <20181207070828.GA8802@kroah.com> References: <20181205231926.45928-1-tkjos@google.com> <20181206144408.GA24078@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 06, 2018 at 08:37:41AM -0800, Todd Kjos wrote: > On Thu, Dec 6, 2018 at 6:51 AM Greg KH wrote: > > > > On Wed, Dec 05, 2018 at 03:19:24PM -0800, Todd Kjos wrote: > > > Add __acquire()/__release() annnotations to fix warnings > > > in sparse context checking > > > > > > There is one case where the warning was due to a lack of > > > a "default:" case in a switch statement where a lock was > > > being released in each of the cases, so the default > > > case was added. > > > > > > Signed-off-by: Todd Kjos > > > --- > > > v2: no change, just resubmitted as #1 of 3 patches instead of by itself > > > > I've already applied this one, right? > > No, not yet. I confused you by failing to add the "v2" in the subject > for the other two submitted with it that you applied this morning: > > binder: filter out nodes when showing binder procs > binder: fix kerneldoc header for struct binder_buffer > > Sorry about the confusion. This one still needs to be applied. But I thought I applied this back on November 26: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/commit/?h=char-misc-testing&id=324fa64cf4189094bc4df744a9e7214a1b81d845 You should have gotten an email from my scripts at that time. or is this somehow a different patch with the same commit log? Or a v2 that changed from the one that I had applied? Do I need to revert this one and apply your new one? confused, greg k-h