Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <felipe.balbi@linux.intel.com>
To:     Minas Harutyunyan <minas.harutyunyan@synopsys.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Minas Harutyunyan <minas.harutyunyan@synopsys.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Maynard CABIENTE <maynard.cabiente@raritan.com>
Cc:     "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"
In-Reply-To: <410670D7E743164D87FA6160E7907A56013A7B47A2@am04wembxa.internal.synopsys.com>
References: <CGME20181121154518eucas1p2cc7ffd4d071ff420c747e1d0c387ee5d@eucas1p2.samsung.com> <20181121154504.13052-1-m.szyprowski@samsung.com> <410670D7E743164D87FA6160E7907A56013A7AA1EE@am04wembxa.internal.synopsys.com> <20181123144307.GC2970@unbuntlaptop> <410670D7E743164D87FA6160E7907A56013A7B19C2@am04wembxa.internal.synopsys.com> <2b48a7b5-f806-d761-97f6-885ae6c69a7e@samsung.com> <410670D7E743164D87FA6160E7907A56013A7B47A2@am04wembxa.internal.synopsys.com>
Date:   Fri, 07 Dec 2018 11:50:21 +0200
Message-ID: <87lg517jj6.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi,


Minas Harutyunyan <minas.harutyunyan@synopsys.com> writes:

> Hi Marek,
>
> On 12/6/2018 7:04 PM, Marek Szyprowski wrote:
>> Dear Minas,
>> 
>> On 2018-12-04 13:34, Minas Harutyunyan wrote:
>>> On 11/23/2018 6:43 PM, Dan Carpenter wrote:
>>>> Ugh...  We also had a long thread about the v2 patch but it turns out
>>>> the list was not CC'd.  I should have checked for that.
>>>>
>>>> You have to pass a flag to say if the caller holds the lock or not...
>>>>
>>>> regards,
>>>> dan carpenter
>>>>
>>> Hi Dan, Marek, Maynard,
>>>
>>> Could you please apply bellow patch over follow patches:
>>>
>>> dccf1bad4be7 usb: dwc2: Disable all EP's on disconnect
>>> 6f774b501928 usb: dwc2: Fix ep disable spinlock flow.
>>>
>>> Please review and test. Feedback is appreciated :-)
>> 
>> Okay, I finally managed to find some time to check this. Your diff is
>> mangled, so I had to manually apply it. Frankly, it is very similar to
>> the revert I proposed. I've checked it on my test machines and it fixes
>> the issues. I'm not very happy about the unlock/lock design, but it
>> should be safe in this case and doesn't make the code even more complex.
>> Feel free to add a following tag to the final patch:
>> 
>> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Thanks for testing.

should $Subject be applied? Can you resend rebased on testing/next with
Tested-by tags collected if you're happy with it?

thanks

-- 
balbi