Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp461290imu; Fri, 7 Dec 2018 04:02:27 -0800 (PST) X-Google-Smtp-Source: AFSGD/XLFSi3qS3kqoIpq1Atf5Xw9L7eOzXgCq5YKraxgxAnr5N5xdbSqlcYmStf+scjXyfEcvcC X-Received: by 2002:a62:c583:: with SMTP id j125mr1978699pfg.37.1544184147621; Fri, 07 Dec 2018 04:02:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544184147; cv=none; d=google.com; s=arc-20160816; b=tF0JIwuNwlGHMOoSnM3Se2Gj4aone4nnJQl4auQ8k1EF9Qu01iubKoB1Ba5nFL3CEa 6oZGzfz6+Da/MSCdWlKiBx8P5Ty4QO/X4f6LkGwi+GBZMGtlyap8BewBsaUarBd3WzAs KwwBIDBccPE77oMT558M9opUspk4/kyyGjEwa5+tPsiM2XI0OyD0OKdz5ZS000YkhOiB G1Dskh+sBl6rbvXCeZ37qbwVH5F6bGC082f0NQJ6lAc6NfAaROeTMiqCPqMOs3/NECPg gCpyzdtZLpbkfz/f/Dqs28Wwi9W4sa1fNCmqIX/azg1jg/KWO4RsxdwpRRHsEALLvlU8 m0DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=heU0iaT/ZBu3N/FoB8zFA/x5ImCFjjXMzvzGEIu17bk=; b=CfO3X+pmO0aacaeC8kGXw9hVAuqn4PnBe8fxfwhZfHoEqj6fjcUcroS2oYg9GKyNNj m4uvrgQzab5qs3K+EBWXwW5fD7OI2bxuNu4XXEPwVt5WCvUsivR+EB/ItgNUB6U1ZVbV 7Hgh5TpCvSd9opstmucLL6APlIZaLBRo//XZTpF1HN0KMRVqy0FeRY+fdtxwbmOgaxes XHInYjn4waQ25qoQS+7D0nk4grK1oaVvUPx9R1ZtAG1q3Cgj63EeO/QOGrt3a/e7ZtJo P3ENJ0qflM5s/il68TtZXy1MIhurKg6Uvm38mz9yShEs2GQO4FjHXnYNcMBYHMbjWTuJ xELw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ngkbxYEu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j20si2606391pgb.520.2018.12.07.04.02.09; Fri, 07 Dec 2018 04:02:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ngkbxYEu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726062AbeLGMB0 (ORCPT + 99 others); Fri, 7 Dec 2018 07:01:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:55400 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725992AbeLGMB0 (ORCPT ); Fri, 7 Dec 2018 07:01:26 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C7D1320868; Fri, 7 Dec 2018 12:01:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544184086; bh=g5buTnVo65HFrDtdy85/SuL0Gf1ng+oGrHDcRxNuqlQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ngkbxYEufr8jfFsfwuGxpX/rIGU2bn26w08JY6bxOmDWiXlGmBx4yi7/4cxf1KK7g RfEaj9FCUHn9NXf1Qxcd1h2GQmJwPdAz0LSJQj3sm90nO9fXdr7R61+Tf1/QeMYKHY CyiChTSxJVw3U1XEwREG49OJfhqSEBDAfTuGpi9A= Date: Fri, 7 Dec 2018 13:01:23 +0100 From: Greg KH To: Peter Rajnoha Cc: linux-kernel@vger.kernel.org, msekleta@redhat.com Subject: Re: [PATCH v2] kobject: add kernel/uevent_features sysfs file Message-ID: <20181207120123.GB15336@kroah.com> References: <20181207114607.26981-1-prajnoha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181207114607.26981-1-prajnoha@redhat.com> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 07, 2018 at 12:46:07PM +0100, Peter Rajnoha wrote: > We can use extended format when writing /sys/.../uevent files to > generate synthetic uevents, introduced with commit f36776fafbaa > ("kobject: support passing in variables for synthetic uevents"). > > Before using this extended format, we need to know if it's supported > and kernel version check may not be appropriate in all cases - there > are possible differences from upstream kernel in distributions with > backports. > > This patch adds /sys/kernel/uevent_features file which currently lists > 'synthargs' string to denote that the kernel is able to recognize the > extended synthetic uevent arguments. Userspace can easily check for > the feature then. So this is just to try to have userspace detect what type of feature the kernel has? Why can't you just go off of the other sysfs file itself? You shouldn't need a "this is a feature list" for the kernel, otherwise we would be on a huge slippery slope trying to document everything. Who is going to use this thing? And what else would go into it? Isn't there some other way you can detect this from userspace (like writing to the file and it fails?) thanks, greg k-h