Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 7 Dec 2018 13:04:05 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Bo YU <tsu.yubo@gmail.com>
Cc:     rafael@kernel.org, linux-kernel@vger.kernel.org, joe@perches.com,
        yuzibode@126.com
Subject: Re: [PATCH v3 2/2] kobject: drop newline from msg string
Message-ID: <20181207120405.GC15336@kroah.com>
References: <cover.1544175417.git.tsu.yubo@gmail.com>
 <f03d23a34df36d55274c5cce7d4081d9017668c1.1544175417.git.tsu.yubo@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f03d23a34df36d55274c5cce7d4081d9017668c1.1544175417.git.tsu.yubo@gmail.com>
User-Agent: Mutt/1.11.1 (2018-12-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Dec 07, 2018 at 05:21:49AM -0500, Bo YU wrote:
> There is currently a missing terminating newline in non-switch case
> match, when msg == NULL.
> 
> Signed-off-by: Bo YU <tsu.yubo@gmail.com>
> ---
> Changes in v3:
> Improve the commit log,requested by rafael.
> 
> Changes in v2:
> According to Joe's suggestion,drop newline from msg
> 
>  lib/kobject_uevent.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
> index b7c088c902a2..1837765ebf01 100644
> --- a/lib/kobject_uevent.c
> +++ b/lib/kobject_uevent.c
> @@ -195,12 +195,12 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
>  	enum kobject_action action;
>  	const char *action_args;
>  	struct kobj_uevent_env *env;
> -	const char *msg = NULL, *devpath;
> +	const char *msg = NULL;

Why did you move the devpath variable from here to lower down?  That
really doesn't do anything :(

thanks,

greg k-h