Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: Configure video PAL decoder into media pipeline
To:     Jagan Teki <jagan@amarulasolutions.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media <linux-media@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Philipp Zabel <p.zabel@pengutronix.de>
Cc:     Michael Trimarchi <michael@amarulasolutions.com>
References: <CAMty3ZAa2_o87YJ=1iak-o-rfZjoYz7PKXM9uGrbHsh6JLOCWw@mail.gmail.com>
From:   Hans Verkuil <hverkuil@xs4all.nl>
Message-ID: <850c2502-217c-a9f0-b433-0cd26d0419fd@xs4all.nl>
Date:   Fri, 7 Dec 2018 13:11:33 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <CAMty3ZAa2_o87YJ=1iak-o-rfZjoYz7PKXM9uGrbHsh6JLOCWw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12/07/2018 12:51 PM, Jagan Teki wrote:
> Hi,
> 
> We have some unconventional setup for parallel CSI design where analog
> input data is converted into to digital composite using PAL decoder
> and it feed to adv7180, camera sensor.
> 
> Analog input =>  Video PAL Decoder => ADV7180 => IPU-CSI0

Just PAL? No NTSC support?

> 
> The PAL decoder is I2C based, tda9885 chip. We setup it up via dt
> bindings and the chip is
> detected fine.
> 
> But we need to know, is this to be part of media control subdev
> pipeline? so-that we can configure pads, links like what we do on
> conventional pipeline  or it should not to be part of media pipeline?

Yes, I would say it should be part of the pipeline.

> 
> Please advise for best possible way to fit this into the design.
> 
> Another observation is since the IPU has more than one sink, source
> pads, we source or sink the other components on the pipeline but look
> like the same thing seems not possible with adv7180 since if has only
> one pad. If it has only one pad sourcing to adv7180 from tda9885 seems
> not possible, If I'm not mistaken.

Correct, in all cases where the adv7180 is used it is directly connected
to the video input connector on a board.

So to support this the adv7180 driver should be modified to add an input pad
so you can connect the decoder. It will be needed at some point anyway once
we add support for connector entities.

Regards,

	Hans

> 
> I tried to look for similar design in mainline, but I couldn't find
> it. is there any design similar to this in mainline?
> 
> Please let us know if anyone has any suggestions on this.
> 
> Jagan.
>