Date: Mon, 19 Jan 2004 17:56:21 +0100
Message-ID: <s5hr7xv6fnu.wl@alsa2.suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: arjanv@redhat.com
Cc: Johannes Stezenbach <js@convergence.de>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.1-mm4: ALSA es1968 DMA alloc problem
In-Reply-To: <1074530601.4443.3.camel@laptop.fenrus.com>
References: <20040117161013.GA3303@convergence.de>
	<s5hwu7n6gvz.wl@alsa2.suse.de>
	<1074530601.4443.3.camel@laptop.fenrus.com>
User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 13) (Rational FORTRAN) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 967
Lines: 39

Hi,

At Mon, 19 Jan 2004 17:43:22 +0100,
Arjan van de Ven wrote:
> 
> [1  <text/plain (quoted-printable)>]
> On Mon, 2004-01-19 at 17:29, Takashi Iwai wrote:
> > At Sat, 17 Jan 2004 17:10:13 +0100,
> 
> 
> all throughout the patch:
> pci_set_dma_mask() and friends need their return value checked!

it does check.  the patch replaces the code like

	if (! pci_dma_support(pci, XXXX))
		error;
	pci_set_dma_mask(pci, XXXX);

with
	if (pci_dma_set_mask(pci, XXXX))
		error;

(there is one place which doesn't check, but it's in the resume
 callback.)

the problem is that in the former version only
pci_set_consistent_dma_mask() was called without pci_dma_set_mask().
apparently, this doesn't work properly.


ciao,

Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/