Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v4 10/10] sched/fair: Provide idle search schedstats
To:     Valentin Schneider <valentin.schneider@arm.com>, mingo@redhat.com,
        peterz@infradead.org
Cc:     subhra.mazumdar@oracle.com, dhaval.giani@oracle.com,
        daniel.m.jordan@oracle.com, pavel.tatashin@microsoft.com,
        matt@codeblueprint.co.uk, umgwanakikbuti@gmail.com,
        riel@redhat.com, jbacik@fb.com, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, quentin.perret@arm.com,
        linux-kernel@vger.kernel.org
References: <1544131696-2888-1-git-send-email-steven.sistare@oracle.com>
 <1544131696-2888-11-git-send-email-steven.sistare@oracle.com>
 <be837c2a-6e8d-3598-0a27-db90792a2673@arm.com>
From:   Steven Sistare <steven.sistare@oracle.com>
Organization: Oracle Corporation
Message-ID: <e2f0d3c6-23d3-2d7c-9605-5095d69e00e4@oracle.com>
Date:   Fri, 7 Dec 2018 08:45:24 -0500
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.2
MIME-Version: 1.0
In-Reply-To: <be837c2a-6e8d-3598-0a27-db90792a2673@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12/7/2018 6:56 AM, Valentin Schneider wrote:
> Hi Steve,
> 
> On 06/12/2018 21:28, Steve Sistare wrote:
> [...]
>> @@ -6392,6 +6422,7 @@ static int wake_cap(struct task_struct *p, int cpu, int prev_cpu)
>>  static int
>>  select_task_rq_fair(struct task_struct *p, int prev_cpu, int sd_flag, int wake_flags)
>>  {
>> +	unsigned long time = schedstat_start_time();
> 
> With arm64's defconfig (!CONFIG_SCHEDSTATS) I get:
> 
> kernel/sched/fair.c: In function ‘select_task_rq_fair’:
> kernel/sched/fair.c:6459:16: warning: unused variable ‘time’ [-Wunused-variable]
>   unsigned long time = schedstat_start_time();
>                 ^~~~
> 
> So you probably want something like this:
> 
> ----->8-----
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 5a113a8..7d33f74 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -6456,12 +6456,14 @@ static int wake_cap(struct task_struct *p, int cpu, int prev_cpu)
>  static int
>  select_task_rq_fair(struct task_struct *p, int prev_cpu, int sd_flag, int wake_flags)
>  {
> -	unsigned long time = schedstat_start_time();
>  	struct sched_domain *tmp, *sd = NULL;
>  	int cpu = smp_processor_id();
>  	int new_cpu = prev_cpu;
>  	int want_affine = 0;
>  	int sync = (wake_flags & WF_SYNC) && !(current->flags & PF_EXITING);
> +	unsigned long time;
> +
> +	time = schedstat_start_time();
>  
>  	if (sd_flag & SD_BALANCE_WAKE) {
>  		record_wakee(p);
> -----8<-----
> 
> The 0-day bot will catch those but since it's the only warn I got I figured
> I'd report it :)

Thanks.  This patch is provided for steal evaluation only and it should be 
dropped before the series is pushed upstream.  If I ever post it again for
future work, I will apply your fix.

- Steve