Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp640026imu; Fri, 7 Dec 2018 06:43:23 -0800 (PST) X-Google-Smtp-Source: AFSGD/VG7+TejwIF6TP/+f2EDloRxr1tL4fDRgRvsAiOZ2CCp6BSi8TVuP9cYB/TzBXfO6bmitqL X-Received: by 2002:a62:8d4f:: with SMTP id z76mr2610149pfd.2.1544193803271; Fri, 07 Dec 2018 06:43:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544193803; cv=none; d=google.com; s=arc-20160816; b=Jc0npny2IUZDAxCDnUN96rq0b87oTsVAnlJ+Ol/OOZYze+9gVzR6wIockThvGgQBDf YyEau3c7HVSploJGvV+7/X2G0AEzQ264qg8Xyce4m9ilI1zgwuEWT/5e1Cnj9HIa9Uz+ Mvm4jTV9wQH9qo8/UGlxlSDAQjXrhAZh4RjhELpO1UyziFeZpdUd2iahmDpxMil2agEA 7/dp2yZxcMwG0GRGyDGaFmnQA68dcC+Thwro/yj+91FMtqRw9gVK64XgMlQc4dphqA8w PWEQOAlfFZiNlGBTLg5nU5+tOA+EPBrvwfPOomhO5o4PDPcsjGbTdRMuKVae4FTpstF6 LuVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=kiVB/qz1hdxrz4PMmwkuRvggHH7jVFFIbuwRBoxtrNs=; b=CL1NPdPdZSzEU/Cn4H5gC56XOhCTIUJOqUOz4izkZAD4/E+EBtHF3CWZrcffzVqwwS Zvaj1k8Q5onIuBp3V/AahxiGWYJaJ8mkLyfGuTvYcjLyxpRejVAXQFrbhCC2mcJC3CY+ ViWyRwo8D06pozkvz+qNS6wr9rwaumAcI4npTp4dk129gPCa3xXyTxQsPTkDzXZqmKji U3Xa54ld1U0fcuNr5+6Zbz/ITLGMjeGjRoulw33CfwwsEmbXQfoG8KAjNYumYXyYKsWa 1pyF640hV6XZF7uGI8yBs8KC+9d2K/AxqZ3t2X7k2KI6DKCO3Ac0qfGqfySE8R1n6jz/ hA7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=vmjLiRmT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h9si3169417pli.418.2018.12.07.06.43.08; Fri, 07 Dec 2018 06:43:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=vmjLiRmT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726119AbeLGOlO (ORCPT + 99 others); Fri, 7 Dec 2018 09:41:14 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:40440 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbeLGOlO (ORCPT ); Fri, 7 Dec 2018 09:41:14 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB7Edovf141555; Fri, 7 Dec 2018 14:40:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=kiVB/qz1hdxrz4PMmwkuRvggHH7jVFFIbuwRBoxtrNs=; b=vmjLiRmTUi4QuK+HFPrfCDuv1MmXUsQZ4ynKmSoK3oYq7NvcuV9xSVL1hVDuPhbsqruk JP2tkd/WMMBn9dJdfeLNspxQxO4dXGdtW9ZPu4476Gk8stEGwIe7Sdicjcxj71qIAfd8 Udjq2kVDvfd+7/gFaU8wrEImaskcxINqDq9pC6WgpmFHCg2DFFNgjuGZDfHnB8B8oL3y JhJ7wu0CEQ2EUbFhENAdPXfjFsKMW4s2jFESMxCAaOIjaD2vsBIBPaeqLrlUmCGVbh7i GnWMrEJuRmsue6C5xk63hOyCrqSB5oyAGVHE2BG4tJ4hQzRhwK/j3LgWbxWDyHkwgKR5 lg== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2p3hque7st-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Dec 2018 14:40:58 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wB7EewDv004661 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 Dec 2018 14:40:58 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wB7Eetf3022668; Fri, 7 Dec 2018 14:40:56 GMT Received: from unbuntlaptop (/197.157.0.47) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 07 Dec 2018 06:40:55 -0800 Date: Fri, 7 Dec 2018 17:40:45 +0300 From: Dan Carpenter To: Minas Harutyunyan Cc: Marek Szyprowski , Maynard CABIENTE , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , Greg Kroah-Hartman , Felipe Balbi , Geert Uytterhoeven , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect" Message-ID: <20181207144045.GT3073@unbuntlaptop> References: <20181121154504.13052-1-m.szyprowski@samsung.com> <410670D7E743164D87FA6160E7907A56013A7AA1EE@am04wembxa.internal.synopsys.com> <20181123144307.GC2970@unbuntlaptop> <410670D7E743164D87FA6160E7907A56013A7B19C2@am04wembxa.internal.synopsys.com> <20181204132913.GH3073@unbuntlaptop> <410670D7E743164D87FA6160E7907A56013A7B2847@am04wembxa.internal.synopsys.com> <20181207101532.GR3073@unbuntlaptop> <410670D7E743164D87FA6160E7907A56013A7B4AAF@am04wembxa.internal.synopsys.com> <410670D7E743164D87FA6160E7907A56013A7B4E2E@am04wembxa.internal.synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <410670D7E743164D87FA6160E7907A56013A7B4E2E@am04wembxa.internal.synopsys.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9099 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=638 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812070117 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 07, 2018 at 02:13:18PM +0000, Minas Harutyunyan wrote: > > My patch doesn't pass sparse checking: "warning: context imbalance in > 'dwc2_hsotg_core_init_disconnected' - unexpected unlock". Sparse persist! > So, I need to re-work patch. Can I use your idea with > dwc2_hsotg_ep_disable_lock() function to prepare new one? > Sparse lock checking is pretty crap, and I wouldn't go out of my way normally to make it happy... But of course you can use my idea. regards, dan carpenter