Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp787313imu; Fri, 7 Dec 2018 08:54:35 -0800 (PST) X-Google-Smtp-Source: AFSGD/XsKPewniOXDbyJVr+ALKCCHOxEJnBsbFk6u0zTaAVYUQnHqg+gCQ7L9FwSKzgwfnwt2BEG X-Received: by 2002:a63:a552:: with SMTP id r18mr2633901pgu.176.1544201675451; Fri, 07 Dec 2018 08:54:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544201675; cv=none; d=google.com; s=arc-20160816; b=I2tpOeF8GdAlCZ626U77BnKLgZYTJyzCooHlVo3Fpwtp0tGkKpIXigVGZxq7LsL5aF ChgAbVHkuh36e5ka2hyjQgHtH6ccCPILswk/fSOdm85VFjZEmahNOxFGrgJMxaFmDUrN v4BLhOcc6OgQs0ooQT+WXO0y4Nh77A8oryAmeeISg9VAUk3eLP+UVLZOE6o3gZGPTs+n a9fNKXlxwc0PrXaBBDnTtX27ihtKDZUNP77HFpzyAAI6w6ICiRnRRbE6nKAeXW9unEDW qhR/dBohnzss278WQIWc0fisMfdntTNi1NGSPevIwBi2vguGDwZHvE56DQHW9O0btpce fbXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:organization :content-disposition:mime-version:message-id:subject:cc:to:from:date; bh=u+KM/EzNnQvjbLeRuVsIjxGFUWl19ZQ2udYf1GsoqK4=; b=iJ94BuoH6O9j2jpb7QGM3CNDTy496OMfPGMPkRK7oWqd3OleV0QaPncLdkeyzQ38F0 wbocgFW5Cw4i32XpDh90IZCpJWFLrIsAz0e3PqWB/kSJ893C1PptwiP+AexqpLZ7P07c 8xzXNauSmv+6Ojfblx7jX1jHfMMKKQcoilILXmQBWaPOF+GFtwuB4oyegjj8C6sxL1NO sJ+cxZAnxjhHrpAytYTWIrmLWk/lt/p9TOxKE3RihBeJCMSSZ4kw4rUdVOKVk2iYJ7eT WVakRS0cHB+7W1HC8xnnp+qziKUieCkxr+Y7TVkERLdrwsoec8ccQCPhY7dRCzoXiW5j k03g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g3si3165754pgi.443.2018.12.07.08.54.18; Fri, 07 Dec 2018 08:54:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726112AbeLGQxl (ORCPT + 99 others); Fri, 7 Dec 2018 11:53:41 -0500 Received: from mail.gnudd.com ([77.43.112.34]:57152 "EHLO mail.gnudd.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbeLGQxk (ORCPT ); Fri, 7 Dec 2018 11:53:40 -0500 X-Greylist: delayed 834 seconds by postgrey-1.27 at vger.kernel.org; Fri, 07 Dec 2018 11:53:39 EST Received: from mail.gnudd.com (localhost [127.0.0.1]) by mail.gnudd.com (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id wB7Gdglf009439; Fri, 7 Dec 2018 17:39:42 +0100 Received: (from rubini@localhost) by mail.gnudd.com (8.14.4/8.14.4/Submit) id wB7GdfWQ009437; Fri, 7 Dec 2018 17:39:41 +0100 Date: Fri, 7 Dec 2018 17:39:41 +0100 From: Alessandro Rubini To: paul.gortmaker@windriver.com Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org, ciminaghi@gnudd.com Subject: Re: [PATCH 12/22] mfd: sta2x11: drop unused MODULE_ tags from non-modular code Message-ID: <20181207163941.GA9430@mail.gnudd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Organization: GnuDD, Device Drivers, Embedded Systems, Courses In-Reply-To: <20181203150756.GA23156@windriver.com> References: <20181203150756.GA23156@windriver.com> <1543811009-15112-1-git-send-email-paul.gortmaker@windriver.com> <1543811009-15112-13-git-send-email-paul.gortmaker@windriver.com> <20181203111442.GK26661@dell> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Subject: [PATCH] mfd: sta2x11: drop unused MODULE_ tags from non-modular code Acked-by: Alessandro Rubini > Alessandro, Davide - you can find additional context regarding why we > are making these changes in the [00/22] e-mail that can be found here: > https://lore.kernel.org/lkml/1543811009-15112-1-git-send-email-paul.gortmaker@windriver.com/ Thanks a lot for this extra link. Yes, I agree. I set up this as a module because /sys/modules has much more than what is actually a module, and the "module" concept brings it the idea of module parameters, that are available for built-in code too, with the module namespace. But it's actually not used in this case. Thanks /alessandro