Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp842962imu; Fri, 7 Dec 2018 09:43:37 -0800 (PST) X-Google-Smtp-Source: AFSGD/V9gwevbFzapiS/DXiDgCygh8RPN9+D1b2BtcGYdmmrpHNKZq2BLbqTGQTVz6UgFxaqfJuJ X-Received: by 2002:a17:902:2e01:: with SMTP id q1mr2906699plb.97.1544204617647; Fri, 07 Dec 2018 09:43:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544204617; cv=none; d=google.com; s=arc-20160816; b=Wz+GI/pCCfHZP8gp6B5ZoE2KP4sKqSw+e+efsaGayTTq2inN6ZxG53O73QcLM0MQnF yHY0hWehd0AKgExuaxIotizLfaNkGCUiaEi+F+gj5fOG8ips5sytqcCQxW0IsDYBKIJT EHFnsH6GA6FQDONOttvmJVowUCzojkqf8995Ptil38iNRuV2Us99ukzjBNLMFv/43jTl mSAJ0mFcUHFBG7CM7ueHx3KPyiNGSevfrzx4rbxyWN7fiI9X7R4xu10FQXIDAm24MAte FPjqyVTJkV/dmINZjfaInuJCkIUS+pM1ZGzaf0URbktvPZz+cusn4HFIjYUv0FH+jqZ6 IyUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ebDt/EKIlwTM58kL3Hav5qH9ruaYvhB6SCbvoB2U+Ho=; b=PcqDF2CD2EWM80HYhRpYZUHuwd78QfmerlQntwJdd7YGNJnDpy2UIbPb0qxDIiwiFk 1lyUCC33yk4vKGgEEmJzMyFXciE8Dg7Pvy0umDchlfamALUoFhZV/hgfgKZQvEoDk0R3 ud0OiIigrZoGJ/ToOSAWvL4feuQQH33RKHPiFFa7Vml5hOUtD/rjNAsYojgO15I7hhEt E/T8IXT2xy4BNE2CebQ2MAzywHngRhYiuveT0dfwRuPO8EDEfgT46gl+H8ndVWMbkbjw ekz26eC7EQLdwPfCeodmUBNWR3BQ5o2R4u7l8e+WvFBlUu/e6Bvkm9L2sNmdO6soxL2E /EVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l24si3151965pgj.171.2018.12.07.09.43.21; Fri, 07 Dec 2018 09:43:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726119AbeLGRml (ORCPT + 99 others); Fri, 7 Dec 2018 12:42:41 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:50392 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbeLGRml (ORCPT ); Fri, 7 Dec 2018 12:42:41 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 51E77EBD; Fri, 7 Dec 2018 09:42:40 -0800 (PST) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.113]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BCE943F5AF; Fri, 7 Dec 2018 09:42:34 -0800 (PST) Date: Fri, 7 Dec 2018 17:42:32 +0000 From: Catalin Marinas To: Douglas Anderson Cc: Jason Wessel , Daniel Thompson , Michal Hocko , linux-sh@vger.kernel.org, Peter Zijlstra , kgdb-bugreport@lists.sourceforge.net, Will Deacon , linux-kernel@vger.kernel.org, Rich Felker , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Yoshinori Sato , linux-hexagon@vger.kernel.org, x86@kernel.org, Russell King , Ingo Molnar , James Hogan , linux-snps-arc@lists.infradead.org, Huang Ying , linux-mips@vger.kernel.org, Mike Rapoport , Borislav Petkov , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Vineet Gupta , Ralf Baechle , Richard Kuo , Paul Burton , Benjamin Herrenschmidt , Michael Ellerman , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Subject: Re: [REPOST PATCH v6 0/4] kgdb: Fix kgdb_roundup_cpus() Message-ID: <20181207174231.GD11961@arrakis.emea.arm.com> References: <20181205033828.6156-1-dianders@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181205033828.6156-1-dianders@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 04, 2018 at 07:38:24PM -0800, Douglas Anderson wrote: > Douglas Anderson (4): > kgdb: Remove irq flags from roundup > kgdb: Fix kgdb_roundup_cpus() for arches who used smp_call_function() > kgdb: Don't round up a CPU that failed rounding up before > kdb: Don't back trace on a cpu that didn't round up FWIW, trying these on arm64 (ThunderX2) with CONFIG_KGDB_TESTS_ON_BOOT=y on top of 4.20-rc5 doesn't boot. It looks like they leave interrupts disabled when they shouldn't and it trips over the BUG at mm/vmalloc.c:1380 (called via do_fork -> copy_process). Now, I don't think these patches make things worse on arm64 since prior to them the kgdb boot tests on arm64 were stuck in a loop (RUN singlestep). -- Catalin