Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp876812imu; Fri, 7 Dec 2018 10:15:06 -0800 (PST) X-Google-Smtp-Source: AFSGD/WYBCbe1btVaZkmJbIPDc9hduIcjqqdVFDQAsjkFqYKnkPSap+7te5MsD5lR+GupWfcr/nc X-Received: by 2002:a62:60c5:: with SMTP id u188mr3280872pfb.4.1544206506795; Fri, 07 Dec 2018 10:15:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544206506; cv=none; d=google.com; s=arc-20160816; b=TKqqARXFdXN3acRtK08cjwIPuwc/2SIVTcRHur7jOxZZL5z4sPgfoJvYx+uLXYWqJb JibJw3Fw090ODjXRy8abf3xDR3c0kvP3uMRwj+3KS4SCKcYgPAHiIU4pqfnbCZUW1a76 rca/7oOAHj87WFBgetitulRDo7M1CDeWznI/IP2qIoRMXbO4GhP+gPujiWN3KZvQzW3Q 4n3jKlWV/Y1UOWIFUNMlV6QntQqWThOpEJ3BbC1Z7BjDxRFPHxUDAo1XwuulFQzAnmoh Pv9ofxhetSGztmBYzjiPzclgekY0iTquvEQB61aoEOKwxPTBGFznpYFP4zJxmbpbzDKk yabA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=lFRwytwOq8hBL00zbNbKVksWwMIRtxH5zbE3ghkw8iM=; b=A/xTzZC6Amiix+UttOIR7x6xKhnsG+1FoZm82QFXiyaQlbtHP2DekhXME6OXGEpKhX PRIu+HnPTUm9VU4Q5xtygT3qn9/VW1hH5V7HnPiC6bOUoQ0Gs4++91ifG7S3NE0Q0LPm IcznNxlurVYXCqqb13N7KR/7Lm3hrmwghPeBa3SRN3T1fDMBuLcZ/gYq3jzWrbI2f4/Z mgh17f6PuOxVcUVu9p8BhPLimTozAJ7mhFwp2WRi7RI0PGgPqZN0XPCEUP4WFwqluWSQ pFFCTAGACJ6b8eErcuDSl1YgzNkM2t+Pzu+fo1kWAO7Cs3c5it2XtwVELQjJyQdlV4sh dMWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c11si3278744pgj.255.2018.12.07.10.14.49; Fri, 07 Dec 2018 10:15:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726296AbeLGSL5 (ORCPT + 99 others); Fri, 7 Dec 2018 13:11:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41940 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726223AbeLGSL5 (ORCPT ); Fri, 7 Dec 2018 13:11:57 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CA61B30B96EF; Fri, 7 Dec 2018 18:11:56 +0000 (UTC) Received: from redhat.com (ovpn-124-251.rdu2.redhat.com [10.10.124.251]) by smtp.corp.redhat.com (Postfix) with SMTP id B586D82EC6; Fri, 7 Dec 2018 18:11:43 +0000 (UTC) Date: Fri, 7 Dec 2018 13:11:42 -0500 From: "Michael S. Tsirkin" To: Tiwei Bie Cc: jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, virtio-dev@lists.oasis-open.org, wexu@redhat.com, jfreimann@redhat.com, maxime.coquelin@redhat.com Subject: Re: [RFC 0/3] virtio_ring: define flags as shifts consistently Message-ID: <20181207131058-mutt-send-email-mst@kernel.org> References: <20181207084842.13133-1-tiwei.bie@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181207084842.13133-1-tiwei.bie@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 07 Dec 2018 18:11:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 07, 2018 at 04:48:39PM +0800, Tiwei Bie wrote: > This is a follow up of the discussion in this thread: > https://patchwork.ozlabs.org/patch/1001015/#2042353 How was this tested? I'd suggest building virtio before and after the changes, stripped binary should be exactly the same. > Tiwei Bie (3): > virtio_ring: define flags as shifts consistently > virtio_ring: add VIRTIO_RING_NO_LEGACY > virtio_ring: use new vring flags > > drivers/virtio/virtio_ring.c | 100 ++++++++++++++++++------------- > include/uapi/linux/virtio_ring.h | 61 +++++++++++++------ > 2 files changed, 103 insertions(+), 58 deletions(-) > > -- > 2.17.1