Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 7 Dec 2018 13:16:49 -0500
From:   Paul Gortmaker <paul.gortmaker@windriver.com>
To:     Charles Keepax <ckeepax@opensource.cirrus.com>
CC:     Lee Jones <lee.jones@linaro.org>, <linux-kernel@vger.kernel.org>,
        <patches@opensource.cirrus.com>
Subject: Re: [PATCH 18/22] mfd: wm831x-i2c: Make it explicitly non-modular
Message-ID: <20181207181648.GQ23156@windriver.com>
References: <1543811009-15112-1-git-send-email-paul.gortmaker@windriver.com>
 <1543811009-15112-19-git-send-email-paul.gortmaker@windriver.com>
 <20181205113820.GZ16508@imbe.wolfsonmicro.main>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20181205113820.GZ16508@imbe.wolfsonmicro.main>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

[Re: [PATCH 18/22] mfd: wm831x-i2c: Make it explicitly non-modular] On 05/12/2018 (Wed 11:38) Charles Keepax wrote:

> On Sun, Dec 02, 2018 at 11:23:25PM -0500, Paul Gortmaker wrote:

[...]

> > -static int wm831x_i2c_remove(struct i2c_client *i2c)
> > -{
> > -	struct wm831x *wm831x = i2c_get_clientdata(i2c);
> > -
> > -	wm831x_device_exit(wm831x);
> 
> These patches remove the only callers of wm831x_device_exit, so I
> guess we should probably remove that function too?

Agreed. I've ammended the 831x-core patch to remove this as well.
Thanks for spotting it.  Will send v3 shortly.

Paul.
--

> 
> Thanks,
> Charles