Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp913393imu; Fri, 7 Dec 2018 10:52:05 -0800 (PST) X-Google-Smtp-Source: AFSGD/U1ZvPlfXWxCJDlX3KP1ZTCorhGiIpEgwr2OuLVpT5FqpQac6t3yjby3Ry8kojWnsn1IEXx X-Received: by 2002:a17:902:9a02:: with SMTP id v2mr3276072plp.180.1544208725411; Fri, 07 Dec 2018 10:52:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544208725; cv=none; d=google.com; s=arc-20160816; b=vjk3Q0y8ba1p9Xzr1QXBGKmx3OkpDx1vLx6xxGzLThXxE1lhHAkWJjMSkikS/H/rgi jw9cJMfeO/E2On9Bssgp0cC+xhgB9jEaiw4droj+dVOuxVD3/86vIonSB4Z5XvEEgaDj Xs8RVrTL8nztcLcKFYKdiB6Yq+EPXYprhvITDNX/lekZ3vRu71DdXeB6wybafIsB+37u ayPaBkcFohJ2sw4Hv/U3I9zwf7fj+Yo98lmkU4Hy9KTQ61d+lQNBiscld3E7DLawudTx eDNfY9IWPnhwjCBlSeUNH/1+iH3/7oXK7cSUXRCxXAJ1qTqn+oO354KRY1ii2vitHmP3 50Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=ard7yE4MiM/ZqneJbbg73hGzFxqopsugHKkaYdoUGac=; b=DFHeWOAHeOE4HEtSrNUDTmXh7SPdx+r7ZqgxytGMPXxtK5R1oSnOdqFT2feuMV0c4/ LKFsr0chSIXPKENMwHG3NARnXOtENgyhBVJueEgA+J9UC3bG6puUi7QJsNwLdvHStaNj /K4dYst9cACJDQZeL4k8/D0qL+7uEn5a4aQhVbu9bfF1bZz65endvX3Yq5W0bnQkpgpu g/vCIfghjYw85MEe0KAIuD2q7Bz1m2MM6rmR/c8vf2cv3Vt6kxCHQWFdyk2MA7gqRoOF uRG5Nmm4MfAZ6kGWHZ9JTIiECtP/VF9Zkxl3YDqpfcqw1plJIlEU+4GVxH97v5fcJmtL oWSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v5si3469824pgg.1.2018.12.07.10.51.49; Fri, 07 Dec 2018 10:52:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726113AbeLGSvM convert rfc822-to-8bit (ORCPT + 99 others); Fri, 7 Dec 2018 13:51:12 -0500 Received: from mail.bootlin.com ([62.4.15.54]:44775 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbeLGSvL (ORCPT ); Fri, 7 Dec 2018 13:51:11 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 766F420750; Fri, 7 Dec 2018 19:51:09 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.2 Received: from xps13 (unknown [91.224.148.103]) by mail.bootlin.com (Postfix) with ESMTPSA id 8E01020717; Fri, 7 Dec 2018 19:51:08 +0100 (CET) Date: Fri, 7 Dec 2018 19:51:07 +0100 From: Miquel Raynal To: Mathieu Malaterre Cc: Paul Burton , trivial@kernel.org, kernel-janitors@vger.kernel.org, Harvey Hunt , Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mtd: rawnand: jz4780: annotate implicit fall throughs Message-ID: <20181207195107.1b4959e1@xps13> In-Reply-To: <20181204201057.30733-1-malat@debian.org> References: <20181203212214.8862-1-malat@debian.org> <20181204201057.30733-1-malat@debian.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mathieu, Mathieu Malaterre wrote on Tue, 4 Dec 2018 21:10:57 +0100: > There is a plan to build the kernel with -Wimplicit-fallthrough and > these places in the code produced warnings. Fix them up. > > Signed-off-by: Mathieu Malaterre > --- > v2: fix subject prefix non sense > > drivers/mtd/nand/raw/jz4780_bch.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/nand/raw/jz4780_bch.c b/drivers/mtd/nand/raw/jz4780_bch.c > index 731c6051d91e..7201827809e9 100644 > --- a/drivers/mtd/nand/raw/jz4780_bch.c > +++ b/drivers/mtd/nand/raw/jz4780_bch.c > @@ -136,8 +136,10 @@ static void jz4780_bch_read_parity(struct jz4780_bch *bch, void *buf, > switch (size8) { > case 3: > dest8[2] = (val >> 16) & 0xff; > + /* fall through */ > case 2: > dest8[1] = (val >> 8) & 0xff; > + /* fall through */ > case 1: > dest8[0] = val & 0xff; > break; Applied to nand/next. Thanks, Miquèl