Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp931539imu; Fri, 7 Dec 2018 11:09:36 -0800 (PST) X-Google-Smtp-Source: AFSGD/WaeLWlC/omfrK8ivpQ0BMbtO0kaYXsd1y0QHYIhsnSsmE9Z2wqcai2ifG8GWc+6UDhZdzi X-Received: by 2002:a63:a84a:: with SMTP id i10mr3039487pgp.263.1544209775883; Fri, 07 Dec 2018 11:09:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544209775; cv=none; d=google.com; s=arc-20160816; b=toy7OPOyB+6cA6R1WRODz+WONp2YGJjFNsPHSLEV7nAkrQ17JZq0vAfB6rSSfmZK1T +hpMAGfgEl4+YoyopG+UTA07rlPMRoqtEng8ScHz3cQ55pySy+GIWkDZG+/doshH054/ f4khI/roA5LmQrewZQkqWEQNJkPjiVDShJS5nu9ut1RvO51FcqeC1HLvTmjVU3JFxIoy j/5r609O6Il41ov+zN7+/B1RlksV3OTfBmXJXbo1N6bXm995/tZyT/RaM3MQtoh/eBpq Oc/whlHrTKmDHWv+xunNCqWesY67l2nuAT9r3OXH3sOj2kWIGBg5MndbwKGQYOeKxxcT PsmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PwQJIeLVy0CrwfGDElRmW57KtintlTa2SeqZtzsURfE=; b=0WFqojw0/ebYGRl/n3m/ExOILeln6EhUq6yqZRXbvmntPbLMUpkzcrCVU0b3UJDkBd kKLcEgigB29scMoUQPKmBxMe5OfCtiWT4VF/x+cTP5GodoE/ylS7Fk3PY2UTcSOMBGyY rZ5ifHHcEwhElEASjmOw3rawAvWFyB30OdYa1B+oqu8QYZ//SlsPFu/i8Dmq9UVqTWUj KheCKUMXpMFXeeL/NKLsbNjq7fGOx82ZqiGx+P5eDr4Xq5XkiFtIaArVUsAvj0T/mBO8 CJnoMakwEdETy4gy/4s9TyaBWbtSJksvVVKkNIf2KT17UNJANPefKXr28kwgpq7Ee7yc PF9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=oApWgdKc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x11si3460841plv.321.2018.12.07.11.09.20; Fri, 07 Dec 2018 11:09:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=oApWgdKc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726350AbeLGTIQ (ORCPT + 99 others); Fri, 7 Dec 2018 14:08:16 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:48526 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726124AbeLGTIN (ORCPT ); Fri, 7 Dec 2018 14:08:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PwQJIeLVy0CrwfGDElRmW57KtintlTa2SeqZtzsURfE=; b=oApWgdKcaWmPlw4Ph8w25tRJfR /ZTcLBabdJsHh+H83IxFyYvzgTy6nJ4b54u3RjIogavcE5NoYd2EiZZ9eWv3ur4HOlb2WNAZ6Y6Ng WWIzV3HiWrbMZIdcTlatSSgdWlOflY1nSpl1/ey8jwwOEoZUyWMMbIVOAxukzIJA7iEGOSTjG3SKK 0WQWDqNz1n6CJolYM6nGy6pHDIpCUqM3dI6lUtNZJCgvI9I154MQ1slw8jCqp2oSR7jibN655o5vf 8sPqo38ZbAmRLD+QczLqnnQ1Dsb8HJiOFQ9di+ls+ahkgrKPjGEvkYUVduIFBTTsN4TI0Un7MfMLb T/cBAAAQ==; Received: from [199.255.44.128] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gVLTo-0006oJ-DO; Fri, 07 Dec 2018 19:08:04 +0000 From: Christoph Hellwig To: iommu@lists.linux-foundation.org, Linus Torvalds , Jesper Dangaard Brouer Cc: Tariq Toukan , Ilias Apalodimas , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Robin Murphy , Konrad Rzeszutek Wilk , Tony Luck , Fenghua Yu , Marek Szyprowski , Keith Busch , Jonathan Derrick , linux-pci@vger.kernel.org, linux-ia64@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/15] dma-mapping: merge dma_unmap_page_attrs and dma_unmap_single_attrs Date: Fri, 7 Dec 2018 11:07:12 -0800 Message-Id: <20181207190720.18517-8-hch@lst.de> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181207190720.18517-1-hch@lst.de> References: <20181207190720.18517-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The two functions are exactly the same, so don't bother implementing them twice. Signed-off-by: Christoph Hellwig --- include/linux/dma-mapping.h | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index 8916499d2805..3b431cc58794 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h @@ -253,6 +253,12 @@ static inline void dma_unmap_single_attrs(struct device *dev, dma_addr_t addr, debug_dma_unmap_page(dev, addr, size, dir, true); } +static inline void dma_unmap_page_attrs(struct device *dev, dma_addr_t addr, + size_t size, enum dma_data_direction dir, unsigned long attrs) +{ + return dma_unmap_single_attrs(dev, addr, size, dir, attrs); +} + /* * dma_maps_sg_attrs returns 0 on error and > 0 on success. * It should never return a value < 0. @@ -300,19 +306,6 @@ static inline dma_addr_t dma_map_page_attrs(struct device *dev, return addr; } -static inline void dma_unmap_page_attrs(struct device *dev, - dma_addr_t addr, size_t size, - enum dma_data_direction dir, - unsigned long attrs) -{ - const struct dma_map_ops *ops = get_dma_ops(dev); - - BUG_ON(!valid_dma_direction(dir)); - if (ops->unmap_page) - ops->unmap_page(dev, addr, size, dir, attrs); - debug_dma_unmap_page(dev, addr, size, dir, false); -} - static inline dma_addr_t dma_map_resource(struct device *dev, phys_addr_t phys_addr, size_t size, -- 2.19.1