Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1006611imu; Fri, 7 Dec 2018 12:30:14 -0800 (PST) X-Google-Smtp-Source: AFSGD/XnrSZTk5vqtUOlT6MaDBbBmGQlNDdtN/L1Ae+SY0pckirFoJUhQBcR9Y7l1zSHvB7WsAVd X-Received: by 2002:aa7:8758:: with SMTP id g24mr3568020pfo.250.1544214614289; Fri, 07 Dec 2018 12:30:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544214614; cv=none; d=google.com; s=arc-20160816; b=dFDUlRFG0MkaUc61rNmMr9C2Cccmqn/GJLyvEJzb4pyV2wxR+0hLPQt4gWMF2BO2wn QeHe3tYl/cA7+6nRSasqxXH182iYzBByWRh5ItdviqFOCf9f+TR6po1/ADVWmIRegTWy IboZUE93z+xuz6eGFgdQzBthfpv6nP0lMNQo3DfjLb1eoYnUXcomksxzrZ2nSDP2xW+a N/PCpadfv/3c/SyiqP6sYgi8oHdnaJIPqWqIGUHdA9RJgn9w/xCBm/W6B0SfgStQglQp T3uCRmYIVlnBxSODtA8Ed2zReR4FJCgyNXbHFIKoeLeO1SWwcYaVLYN7Wmf+uO2i5oA7 hzHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature; bh=d2YRIjY785kzhNxRKvoIkFltfN6B/k36a4q6tUN8DPw=; b=TkBBd6IzYCyVeRSP7/ECC7C4x1csROHcl2DO+yItOa0xEYPjJ3CQMzRxpMsnUPJl9d Dqmfcu+vgY/x+qsxtraS/9vstpNIn/WI+1gkeHv4wwfwvnHDQfGTRYdqqRMfcOf2TZch /wBCuYgKALwASJulHvkR6dHO3wgDSDNXoceqFhoep/FUb79yAR6gwz3c6/OExXO3ivxl e2OhKXadWjD7J1oDy0Dc9XOCqOTacfLsEyoLNwSJEvALx+UNypBuJJOVbeIWJ10ldv0c CcNgsTEtrdbGibhibZGeOfTF51/aOgKpcPeL/vA6E+y0wh8GfG1/+dqqvDet2Ou/c57N T9wQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=SouL7Pdi; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ht7HtNAr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d65si3951581pfc.201.2018.12.07.12.29.58; Fri, 07 Dec 2018 12:30:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=SouL7Pdi; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ht7HtNAr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726109AbeLGU3V (ORCPT + 99 others); Fri, 7 Dec 2018 15:29:21 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:58030 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726008AbeLGU3U (ORCPT ); Fri, 7 Dec 2018 15:29:20 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4E2AB607DC; Fri, 7 Dec 2018 20:29:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1544214559; bh=hVs5z3wj+3mwMQk1pou56hc8FiVASkVmV72k1OdjMLA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=SouL7PdiVKVLEEAdcvFriVVTL97BG7BFDqWCEFrYwHsNVbNenfXLUUpgMExaZjxym 1akXHQiMqRYZzD4zi/d7undOA2ZKg0rv/okk4nidVWd9HVdifeASPeck4aDpIsV1GH 6/w7wG3E5RHiUoS7OVxpfONReWJMCN0L2WDfDVC8= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from [10.134.64.210] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: skannan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id F056760241; Fri, 7 Dec 2018 20:29:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1544214558; bh=hVs5z3wj+3mwMQk1pou56hc8FiVASkVmV72k1OdjMLA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Ht7HtNArvWIlF6awEV4XIYq0UJuRpL1D79epMhhHn8x4dS3caH5G/XboPK9D0jSep EBVw/VoXUg/0aN3R+9QXYVz2Eyqq6iSHGtWFgG93wt1KVXyWZFCc6PsRL47InL8e34 8EMqvzbK0d3dXVkmo1JH+Y7q9G5j0HuT1v1swsnI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org F056760241 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=skannan@codeaurora.org Subject: Re: [PATCH v3] PM / devfreq: Restart previous governor if new governor fails to start To: Chanwoo Choi Cc: "Rafael J. Wysocki" , MyungJoo Ham , Kyungmin Park , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1477509425-16936-1-git-send-email-skannan@codeaurora.org> <5820CE7E.40802@codeaurora.org> <5821948B.2010907@samsung.com> <58223AF1.2030605@codeaurora.org> <58227CDB.6050907@samsung.com> <58228B9E.2090108@samsung.com> <58228C10.3070502@samsung.com> <58238840.90802@codeaurora.org> <5823BB01.3090502@samsung.com> From: Saravana Kannan Message-ID: <5164dea6-ad0c-d817-eb0d-36d9f4a718d4@codeaurora.org> Date: Fri, 7 Dec 2018 12:29:17 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <5823BB01.3090502@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/9/16 4:10 PM, Chanwoo Choi wrote: > Hi, > > On 2016년 11월 10일 05:34, Saravana Kannan wrote: >> On 11/08/2016 06:38 PM, Chanwoo Choi wrote: >>> On 2016년 11월 09일 11:36, Chanwoo Choi wrote: >>>> Hi, >>>> >>>> On 2016년 11월 09일 10:33, Chanwoo Choi wrote: >>>>> On 2016년 11월 09일 05:52, Saravana Kannan wrote: >>>>>> On 11/08/2016 01:02 AM, Chanwoo Choi wrote: >>>>>>> Hi, >>>>>>> >>>>>>> On 2016년 11월 08일 03:57, Saravana Kannan wrote: >>>>>>>> On 10/26/2016 05:06 PM, Chanwoo Choi wrote: >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> On 2016년 10월 27일 04:17, Saravana Kannan wrote: >>>>>>>>>> If the new governor fails to start, switch back to old governor so that the >>>>>>>>>> devfreq state is not left in some weird limbo. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Saravana Kannan >>>>>>>>>> --- >>>>>>>>>> * Fix NULL deref for real this time. >>>>>>>>>> * Addressed some style preferences. >>>>>>>>>> >>>>>>>>>> drivers/devfreq/devfreq.c | 13 +++++++++++-- >>>>>>>>>> 1 file changed, 11 insertions(+), 2 deletions(-) >>>>>>>>>> >>>>>>>>>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c >>>>>>>>>> index bf3ea76..77c41a5 100644 >>>>>>>>>> --- a/drivers/devfreq/devfreq.c >>>>>>>>>> +++ b/drivers/devfreq/devfreq.c >>>>>>>>>> @@ -919,7 +919,7 @@ static ssize_t governor_store(struct device *dev, struct device_attribute *attr, >>>>>>>>>> struct devfreq *df = to_devfreq(dev); >>>>>>>>>> int ret; >>>>>>>>>> char str_governor[DEVFREQ_NAME_LEN + 1]; >>>>>>>>>> - struct devfreq_governor *governor; >>>>>>>>>> + const struct devfreq_governor *governor, *prev_governor; >>>>>>>>>> >>>>>>>>>> ret = sscanf(buf, "%" __stringify(DEVFREQ_NAME_LEN) "s", str_governor); >>>>>>>>>> if (ret != 1) >>>>>>>>>> @@ -944,12 +944,21 @@ static ssize_t governor_store(struct device *dev, struct device_attribute *attr, >>>>>>>>>> goto out; >>>>>>>>>> } >>>>>>>>>> } >>>>>>>>>> + prev_governor = df->governor; >>>>>>>>>> df->governor = governor; >>>>>>>>>> strncpy(df->governor_name, governor->name, DEVFREQ_NAME_LEN); >>>>>>>>>> ret = df->governor->event_handler(df, DEVFREQ_GOV_START, NULL); >>>>>>>>>> - if (ret) >>>>>>>>>> + if (ret) { >>>>>>>>>> dev_warn(dev, "%s: Governor %s not started(%d)\n", >>>>>>>>>> __func__, df->governor->name, ret); >>>>>>>>>> + if (prev_governor) { >>>>>>>>> I think that prev_governor is always set. You don't need to check it. >>>>>>>>> Why do check it? >>>>>>>> Not true. Even higher up in this function, we check if df->governor != NULL. Simple example would be that the default governor passed in while adding the device isn't compiled in. >>>>>>> I don't understand. If device is not registered by devfreq_add_device(), >>>>>>> you don't change the governor by using governor_store(). >>>>>>> >>>>>>> If you can change the governor through governor_store(), >>>>>>> it means that the devfreq instance was added without any problem. >>>>>>> The added devfreq instance must have the sepecific governor >>>>>>> on df->governor variable. >>>>>>> >>>>>>> So, I think that df->governor is always set and then prev_governor is always set. >>>>>> Read the code more closely. add_device doesn't (and shouldn't) fail if the governor isn't present. After that, the governor could be changed from user space. >>>>> If governor is not present during devfreq_add_device(), >>>>> the devfreq instance is not able to register the devfreq framework. >>>>> So, the user never touch the sysfs[1] to change the governor >>>>> because the sysfs[1] is not created by devfreq framework. >>>>> [1] /sys/class/devfreq/[device name]/governor >>>>> >>>>> In summary, if governor is not present during devfreq_add_device(), >>>>> the devfreq framework doesn't create tye sysfs[1] for governor. >>>>> >>>>> The user-space never change the governor through sysfs[1] >>>>> because there is no any sysfs entry[1]. >>>> I checked the code of devfreq_add_device(). >>>> As you mentioned, if there is no governor, >>>> devfreq_add_device() don't pass wihtout calling the devfreq->governor->even_handler(). >>> Wrong expression / don't pass -> pass >>> >> I think it's correct as is. Just because the governor isn't there (or hasn't registered yet) doesn't mean the device add should fail. >> >> That aside, do you care to ack this patch for the way the code is currently? > Reviewed-by: Chanwoo Choi > > After fixing the bug of devfreq_add_device(), > I'll remove the unneeded 'if statement' of prev_governor in governor_store. It's been 2 years and this patch still hasn't been picked up. Can we please pick this up and get this into the next kernel release? Thanks, Saravana -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project