Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 7 Dec 2018 17:18:41 -0500
From:   Kyle Williams <kdgwill@chromium.org>
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     linux-usb@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Jack Stocker <jackstocker.93@gmail.com>,
        Michael =?iso-8859-1?Q?Niew=F6hner?= <linux@mniewoehner.de>,
        Nico Sneck <snecknico@gmail.com>,
        Tim Anderson <tsa@biglakesoftware.com>,
        Danilo Krummrich <danilokrummrich@dk-develop.de>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: quirks: add NO_LPM quirk for Logitech
 Flare|Meetup|Brio|Rally
Message-ID: <20181207221841.GA161210@google.com>
References: <CAAd214WBzcsFamzqkdTp0AYDRo1=Uq1=Z5fJhzkOZ6znVFo3MA@mail.gmail.com>
 <Pine.LNX.4.44L0.1812041633580.1537-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.44L0.1812041633580.1537-100000@iolanthe.rowland.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Dec 04, 2018 at 04:36:18PM -0500, Alan Stern wrote:
> On Tue, 4 Dec 2018, Kyle Williams wrote:
> 
> > Description: Some USB device / host controller combinations seem to have
> > problems with Link Power management. In particular it is described that
> > the combination of certain Logitech devices and other powered media
> > devices such as the Atrus device causes 'not enough bandwidth for
> > new device state'error.
> > 
> > This patch creates quirk entries for the tested Logitech device
> > indicating LPM should remain disabled for the device.
> > 
> > Signed-off-by: Kyle Williams <kdgwill@chromium.org>
> > ---
> >  drivers/usb/core/quirks.c | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> > index 0690fcff0ea2..9403edee4797 100644
> > --- a/drivers/usb/core/quirks.c
> > +++ b/drivers/usb/core/quirks.c
> > @@ -246,6 +246,22 @@ static const struct usb_device_id usb_quirk_list[] = {
> >         /* Logitech Harmony 700-series */
> >         { USB_DEVICE(0x046d, 0xc122), .driver_info = USB_QUIRK_DELAY_INIT },
> > 
> > +       /* Logitech Flare */
> > +       { USB_DEVICE(0x046d, 0x0876), .driver_info = USB_QUIRK_NO_LPM },
> 
> This entry is out of order with the preceding entry.  And some of the 
> new entries below are out of order with each other (entries are 
> supposed to be sorted by Vendor ID, then Product ID).
> 
> Also, perhaps instead of adding all these new entries, we should set 
> the NO_LPM quirk flag for all Logitech devices?
> 
> Alan Stern
Setting USB_QUIRK_NO_LPM for all Logitech devices instead of specific
ones seem to be a better solution as there are a lot of other devices
that have the issue as well

Kyle Williams
> 
> > +
> > +       /* Logitech Rally Camera */
> > +       { USB_DEVICE(0x046d, 0x0881), .driver_info = USB_QUIRK_NO_LPM },
> > +       { USB_DEVICE(0x046d, 0x0888), .driver_info = USB_QUIRK_NO_LPM },
> > +       { USB_DEVICE(0x046d, 0x0889), .driver_info = USB_QUIRK_NO_LPM },
> > +
> > +       /* Logitech Meetup */
> > +       { USB_DEVICE(0x046d, 0x0867), .driver_info = USB_QUIRK_NO_LPM },
> > +       { USB_DEVICE(0x046d, 0x0866), .driver_info = USB_QUIRK_NO_LPM },
> > +       { USB_DEVICE(0x046d, 0x086a), .driver_info = USB_QUIRK_NO_LPM },
> > +
> > +       /* Logitech Brio */
> > +       { USB_DEVICE(0x046d, 0x085e), .driver_info = USB_QUIRK_NO_LPM },
> > +
> >         /* Philips PSC805 audio device */
> >         { USB_DEVICE(0x0471, 0x0155), .driver_info = USB_QUIRK_RESET_RESUME
> > },
> > 
> > 
>