Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181207184423.1962-1-sean.j.christopherson@intel.com>
 <20181207195223.23968-1-sean.j.christopherson@intel.com> <CAHk-=wgtN9nQBimLuOmBxY8eYqDRhNeBOW_uvnhqtZSFycyHuA@mail.gmail.com>
 <20181207220646.GH10404@linux.intel.com> <CAHk-=wizzTem4B3muo+DV5JqPBD0n1JJ8-NDjyY1fn-N4WYHCg@mail.gmail.com>
In-Reply-To: <CAHk-=wizzTem4B3muo+DV5JqPBD0n1JJ8-NDjyY1fn-N4WYHCg@mail.gmail.com>
From:   Andy Lutomirski <luto@kernel.org>
Date:   Fri, 7 Dec 2018 15:57:10 -0800
Message-ID: <CALCETrUu=qO4tHkk-QxKD_j687hKV56X9JvYv1YsdgtOy0urmQ@mail.gmail.com>
Subject: Re: [PATCH v2] x86/fault: Decode and print #PF oops in human readable form
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     "Christopherson, Sean J" <sean.j.christopherson@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andrew Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Rik van Riel <riel@surriel.com>,
        Yu-cheng Yu <yu-cheng.yu@intel.com>,
        Ingo Molnar <mingo@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Dec 7, 2018 at 2:14 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Fri, Dec 7, 2018 at 2:06 PM Sean Christopherson
> <sean.j.christopherson@intel.com> wrote:
> >
> > Looking at it again, my own personal preference would be to swap the order
> > of the #PF lines.
>
> Yeah, probably.
>
> Also:
>
> > [  160.246820] BUG: unable to handle kernel paging request at ffffbeef00000000
> > [  160.247517] #PF: supervisor-privileged instruction fetch from kernel code
> > [  160.248085] #PF: error_code(0x0010) - not-present page
>
> With this form, I think the "kernel" in the first line is actually
> misleading. Yes, it's a #PF for the kernel, but then the "kernel" on
> the second line talks about what mode we were in when it happened, so
> we have two different meanings of "kernel" on two adjacent lines.

I'm okay with this variant.  I have a slight preference for:

#PF: supervisor-privileged instruction fetch from kernel code
#PF error_code: 0x0010 [READ]

Which is what we'd get from Sean's patch plus my patch here:

https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/mm&id=ccfb1941f90153818c07fb1a7dc22121a970d252

Sean, what do you think?

> So maybe  that "BUG: unable to handle kernel paging request" message
> should be something like
>
>   "BUG: unable to handle page fault for address ffffbeef00000000"
>
> instead? Does that make sense to people?

Yes please.