Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1288921imu; Fri, 7 Dec 2018 18:42:01 -0800 (PST) X-Google-Smtp-Source: AFSGD/VQ1orT2AO1GpgLz7aP/OpeU2YHHvMeq4dExSPL0l2qSRQ5sSO3TmXcz+z+0LjSX54vkJeN X-Received: by 2002:a17:902:bb86:: with SMTP id m6mr4436814pls.315.1544236921660; Fri, 07 Dec 2018 18:42:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544236921; cv=none; d=google.com; s=arc-20160816; b=GXPCs7oFLtd/GJPg9PF1iC97K0QgfodSzTJ7o2jkhdnxQ4s/P3o0mqhj4ol5O3uDUj bkd8ugr+gWuUS+5KNoWHlIunEKX0m9BeV/20gZqTXirgv6pCnXk3iudmhLJ91MM+0y2l 40jiO3rjwq03NwW9jjcZ7DHgMP+M6J70cndVx1NVy7r44dDZvdY83CLkYAsvx9QFuyOX aF5B8xaU86EHP4apmR7DVFfb0IYAoGg4t6EUU7d80E+jSvzE/UAEWmY6ukM0vDoOUkt7 WPtu/ZSbJbvSrGJCiXDX8vLo6g/mxgIH9RPY9Q6LShVboysdfRTml8DCezFtj+9mwc14 S6rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=q69DHhA+10LNdi++VBHYfVPULsStaw+rz3DQ1DHiGGk=; b=0ddaTrFLaXiXd1zvehWyzRqo8ZfrhvadfhioNe6aL0VQ0eQVY8Dib1OceKTLCgvbiG eP66KHD6ju6f0prZIvHNnwBydiAHEJDRFIV5UauyQBvcKgWP71Bg+gbwqYs6Xb3+JBOO YB7lM561NZlbiP5PiMiHZ9bgLqaQ57mpBzubFyLMYh5gYUA1WdN2P6tO/oTilLo/KooJ G1q8phaX0PC58AuR7XQU3uFfaglLbqtgxjTF1vFOJl+sOjF8AH4YhFn4r031AzyuGvYk vVc4slh3qQM2FTOb67B7O2PtD5WH4Gaj2D1khdDDtCoZVqmNvEhGlf9QqWO0+b93zPJ6 xUaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=TvTjW60i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b14si4751484pfc.156.2018.12.07.18.41.46; Fri, 07 Dec 2018 18:42:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=TvTjW60i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726111AbeLHClJ (ORCPT + 99 others); Fri, 7 Dec 2018 21:41:09 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:34742 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726077AbeLHClI (ORCPT ); Fri, 7 Dec 2018 21:41:08 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB82YFGu030286; Sat, 8 Dec 2018 02:40:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=q69DHhA+10LNdi++VBHYfVPULsStaw+rz3DQ1DHiGGk=; b=TvTjW60isFPWYD0hRAN5DFUqAzxAD1QoGsfJH/HRAUoIervdu341uRjeDnQa42bKEQnp isnFclqYzrRDV/RtDi+jk5YevBBkrBE7eiBK196Lx8RSTbVMeUjVATs8Pr6HYjZRMegz 9gztcHUjJ1WUzMIM/lhUics0ePADsH5NWWAuZjmG+d3XicwV9IUHtIYn+ubn07zqaFYj 022uayXDPCllUVKL/MV2wylQ9jrP5Y52psMlO14zAjN5i5G8E8XBfrzI92b2q0aywKtr u14Qxtls0sA0kigX/+UE7PQ8APrmlxKQjdub7EGlpIvWhtNd+1G8hN02uEM7H65rqjxb Wg== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2p3jxs0g0q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 08 Dec 2018 02:40:48 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wB82ekjH007467 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 8 Dec 2018 02:40:47 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wB82ejpt001665; Sat, 8 Dec 2018 02:40:45 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 07 Dec 2018 18:40:45 -0800 To: Thomas Meyer Cc: kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: megaraid_sas: NULL check before some freeing functions is not needed. From: "Martin K. Petersen" Organization: Oracle Corporation References: <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de> <1543760930052-918941928-10-diffsplit-thomas@m3y3r.de> Date: Fri, 07 Dec 2018 21:40:42 -0500 In-Reply-To: <1543760930052-918941928-10-diffsplit-thomas@m3y3r.de> (Thomas Meyer's message of "Sun, 02 Dec 2018 21:52:11 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9100 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=532 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812080022 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thomas, > NULL check before some freeing functions is not needed. Applied to 4.21/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering