Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1289570imu; Fri, 7 Dec 2018 18:43:11 -0800 (PST) X-Google-Smtp-Source: AFSGD/We8xzq9hgJy28ybWAsb7f6bKJvLc/bQxN1ufZHbsOq1IehcshCSHxoB6S5RmmNqcTeVBKD X-Received: by 2002:a62:442:: with SMTP id 63mr4493419pfe.156.1544236991558; Fri, 07 Dec 2018 18:43:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544236991; cv=none; d=google.com; s=arc-20160816; b=I9c7MS+cjTB4tvXlsl+BZYYOnOfMg4wf7tuFUDL9OwWPOPX9ubhHn0QMCMEo5Dul9f +CYP2D8X+yUwSOsfOwr80ISXYV6WEb9qswklw7SyV/VR1marWzAZ8HuohTX6QUAODf6/ Z1mJsr0ASPB6pSps/fZhKd+gqtYYeYGwxFqVHJmWol2GqPx0BQjpl9KXLF1aJVHpp6eO p12cAoCBFpYfPIUsByRwhTbVxjQtv4PLcH7XrqkFh3ZF4mKnwDPE9shykBDZV2skluNK n+0xwbvLpLQhN77W9bSwdu1t4tp1egwPcPHBm8b+uiDHmG9KF2ZUa6oGTlozGBirE4rV QFsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=Wv0cZnBiWI9/KX+JoPR97XUvnHvRzVIdVGUsrsU7dcg=; b=nap/z/8e0tc99H1RbCR3TdfJK9mEEHJEWdH+0rnDySsOnARGq0Dx98BElWNAjS5H0D TwBLgByrLsJZZH+XJGMdSp1zQZA7+9+VuJC1l6RkOzO7NIm7M2xcT/NtOBMob+/1/UwF BupKHjA6L6xr7fnznMiXyeYCWRkZmC5VqisWE/4Mx7wwAHthALIWVr7eg38BmRKHU+K3 A8/Qr3/aWWrLhry8L4UgXjlTwGpcGtZF25w2MZ/nYQ1WuE2NabTe+bEILti5lQt7VVLM oUAZ5jV8zbJe1s0DsLNLPa+lKgxhkx9Od+ni2uE+7W05MobkEx5ixYfWg2FBJAWvX1Rj KQZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=sMH9lmnI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f35si4122594pgf.449.2018.12.07.18.42.56; Fri, 07 Dec 2018 18:43:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=sMH9lmnI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726159AbeLHClp (ORCPT + 99 others); Fri, 7 Dec 2018 21:41:45 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:51570 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726084AbeLHClp (ORCPT ); Fri, 7 Dec 2018 21:41:45 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB82fPXH071826; Sat, 8 Dec 2018 02:41:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=Wv0cZnBiWI9/KX+JoPR97XUvnHvRzVIdVGUsrsU7dcg=; b=sMH9lmnImmHxes0kZ50h6G0g/LVmtCpYjVlVIjioM5Qn1iXuF111Ccc+QlehhAsoSXNU a5uMKrPYUhMPXY8ss0eCZFnjMMgllRF3mjFPfoK/73jSIIiT0Mho09pNLZ14Yv3gyODa e3E7TCCv67i0P0ROkXPQ1sCJjmXN4v0V/yIIoYp8delvvQuCn/N3Y7f7QdCR84oBEd2C revNwgTtnYAV6tm3h6ZWHlmweTGjbHnYNDbnNWXFGCNY833S4Zg5iYXiXyZktYKr4V1e MBjl0zAyWeZ3zixzC3x17dGBG1KPjtOECJSHM6PPa2E1PTHunaEL7zfDkTMjS6B+230v /w== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2p85ctr00h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 08 Dec 2018 02:41:25 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wB82fOii020463 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 8 Dec 2018 02:41:25 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wB82fOCA013563; Sat, 8 Dec 2018 02:41:24 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 07 Dec 2018 18:41:24 -0800 To: Thomas Meyer Cc: QLogic-Storage-Upstream@cavium.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: qedf: NULL check before some freeing functions is not needed. From: "Martin K. Petersen" Organization: Oracle Corporation References: <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de> <1543760930052-271366275-12-diffsplit-thomas@m3y3r.de> Date: Fri, 07 Dec 2018 21:41:22 -0500 In-Reply-To: <1543760930052-271366275-12-diffsplit-thomas@m3y3r.de> (Thomas Meyer's message of "Sun, 02 Dec 2018 21:52:11 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9100 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=607 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812080022 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thomas, > NULL check before some freeing functions is not needed. Applied to 4.21/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering