Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1292875imu; Fri, 7 Dec 2018 18:49:29 -0800 (PST) X-Google-Smtp-Source: AFSGD/UDGT79x/nnJP8MlvQVi213E+XY8EAOIiFRy8tQ7fn9voD0ktsI3t71To4sc31SEBC9IskG X-Received: by 2002:a62:5b83:: with SMTP id p125mr4632845pfb.116.1544237369340; Fri, 07 Dec 2018 18:49:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544237369; cv=none; d=google.com; s=arc-20160816; b=gzS5DmtxDFhF/t3Ihhd3a7Hz3eUGJYI1Brf7UNRbB4C+HFzr66eC1Kz/cHvOLNhQaK WPFq+H8bZdu9TdX7pe6p7VaEeUN3Nl8HKT6x2sua+6m27157q6MJGulWNWxg4K/Vw14C iHFtUWIXSgLT7kDiK/7Om8W2EGvleIJ7+lBeZnDmiT3KUiWWYDyhpjYhqQR+OsqPANhn uNiQiOmk79tlgoqSBaiq0yUr/Xe/lBQyUsFD8eYmdfaHNTnyhymo+DNAwXXs1qQyJBV+ S5zUpBCkWvLCI3v047RgWgin6GUsHpWy540kosXRjNxYGWDDQf1NQQ+8v0Rsk8hh840O sPCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=q69DHhA+10LNdi++VBHYfVPULsStaw+rz3DQ1DHiGGk=; b=LfozMJZSUWFT+HXPl4OY3ucC6OIUtZaN7hIC64YkjfNqnbqIHzAvm2eHTiwuOQgwUe 8IVDqV1EwqDnlJ0ToKXG7nhay2IjRJIcOWqwzu6SAvPpRAxjrkFtCgUh7VIbDuENnnht /CjmsMn8wxpO4zT47wmK4s/8XZ393qfeB0QrQj3b5o8RqBhSTlY0uy3nSgjprywWTjMH e6g5r2B1xtUylTBsYnFUt2bjLqeqqFT89FPrx5ClNzlv8ibLKTomtbIYO/wfpxGBt6HS nO2gYq3KXytIbFK98xKXLYiZntdJcuigeGwIEt8zOHKvxVz7JCMyMi+B5w7xjSUhA1SG hdeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=0TmeO78o; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 76si4723316pfw.66.2018.12.07.18.49.10; Fri, 07 Dec 2018 18:49:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=0TmeO78o; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726131AbeLHCsP (ORCPT + 99 others); Fri, 7 Dec 2018 21:48:15 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:56514 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726070AbeLHCsP (ORCPT ); Fri, 7 Dec 2018 21:48:15 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB82iuY0074173; Sat, 8 Dec 2018 02:47:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=q69DHhA+10LNdi++VBHYfVPULsStaw+rz3DQ1DHiGGk=; b=0TmeO78oprIKDED/Ha44Ec1DyiE7x8hPIgsEzaQyCTslPxXW0cPKMjjypGfGMxVDM+pz opiNriaPpePUveBuABzuTpV/0wFPLtwplP7QJBi7Mk4H/C/6nWGYUEV6XbnIiSaC8bTS DhoPp0Ptcj61HSebmkqY20F9PgUr/6Y5jp80qxJUeVAxl4AoI5/Bw+/8QV9PJ+tMBb4T W8WV6sNVUbbsPEtz/byJoVohLfGfaQzIkJAkMutOOOYkCbvll9Pnwr5Di2w+IOLA/7BB l81NCEk2NPlcB62fSPkiFztf43R7ImDWSZpeB67pdjkbJOKOZSHYCiPo6/yW6BarREgt OQ== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2p85ctr04t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 08 Dec 2018 02:47:53 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wB82lrev019960 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 8 Dec 2018 02:47:53 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wB82lqsb015709; Sat, 8 Dec 2018 02:47:52 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 07 Dec 2018 18:47:51 -0800 To: Thomas Meyer Cc: qla2xxx-upstream@qlogic.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: qla2xxx: NULL check before some freeing functions is not needed. From: "Martin K. Petersen" Organization: Oracle Corporation References: <1543760930050-1499171309-0-diffsplit-thomas@m3y3r.de> <1543760930052-275330559-13-diffsplit-thomas@m3y3r.de> Date: Fri, 07 Dec 2018 21:47:49 -0500 In-Reply-To: <1543760930052-275330559-13-diffsplit-thomas@m3y3r.de> (Thomas Meyer's message of "Sun, 02 Dec 2018 21:52:11 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9100 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=541 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812080023 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thomas, > NULL check before some freeing functions is not needed. Applied to 4.21/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering