Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Martin Lau <kafai@fb.com>
To:     Roman Gushchin <guroan@gmail.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Roman Gushchin <guro@fb.com>,
        "Alexei Starovoitov" <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH bpf-next 1/3] bpf: pass struct btf pointer to the
 map_check_btf() callback
Thread-Topic: [PATCH bpf-next 1/3] bpf: pass struct btf pointer to the
 map_check_btf() callback
Thread-Index: AQHUjpB+RGQGVYinmE6Av5uq2zwZ/qV1qmMA
Date:   Sun, 9 Dec 2018 02:06:14 +0000
Message-ID: <20181209020612.raa636zl3x4sola2@kafai-mbp.dhcp.thefacebook.com>
References: <20181208005315.3500-1-guro@fb.com>
In-Reply-To: <20181208005315.3500-1-guro@fb.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:180::1:352d]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;MWHPR15MB1757;20:xwwfJ2ay+a09Rlr0P+vcB/oqUYCTjcGrfD1hcBNB7Pq9/a5cWMyS0j2XGXacC2VtF+LYHFUTEqv9Ny+TY3bxDLUWx4M3ny0EvQFCUUye80oS6fuNOBYORAiXi+/awBO8Qya0OOYj/JGvTtsmDxkBplVi3Q+juO5882n4MJDt09M=
x-ms-office365-filtering-correlation-id: 84affc7c-9dff-480c-ee07-08d65d7ae59a
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:MWHPR15MB1757;
x-ms-traffictypediagnostic: MWHPR15MB1757:
x-microsoft-antispam-prvs: <MWHPR15MB1757E10C4CA26FCA0DC654F5D5A40@MWHPR15MB1757.namprd15.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823302103)(3002001)(93006095)(93001095)(3231455)(999002)(11241501185)(944501520)(52105112)(10201501046)(148016)(149066)(150057)(6041310)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095);SRVR:MWHPR15MB1757;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1757;
x-forefront-prvs: 0881A7A935
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(136003)(376002)(346002)(39860400002)(366004)(396003)(199004)(189003)(9686003)(1076002)(6512007)(256004)(6246003)(446003)(5660300001)(11346002)(486006)(99286004)(97736004)(6486002)(316002)(54906003)(6916009)(14454004)(71190400001)(229853002)(71200400001)(6436002)(86362001)(81156014)(8676002)(81166006)(478600001)(2906002)(1411001)(25786009)(39060400002)(4326008)(46003)(7736002)(186003)(68736007)(476003)(105586002)(102836004)(53936002)(305945005)(6506007)(386003)(6116002)(76176011)(8936002)(52116002)(33896004)(106356001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1757;H:MWHPR15MB1790.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-microsoft-antispam-message-info: CYbhik1SP/YK7/4PC6Rj6IQaUFJCg+5DkuMJbSnro7e4esaT4kfURwQEOLZEQY47UAEWnWtIQdMcyNSjbsCm+HrlHta+tfDV3xJE8MJ2crWkXEQO+PiDLZmaEmewdcTN+UDIbXdfkq0Mk3x3f2w/0FnqO9szYWneLMDeYoK0VGjFaYDj6EWLgyJTUs4nruqJF7l1tFlLpYL7kOP+wPPMOnB6lyRa5FyrF4mJbf3uaglGQYbFlDvrKFMCMz60dTv6/p330bxoqW1JYiPPrP77yAYk+C7J5HRyFFqUBB8Hr10ww8VgyrT8HpY8AcCcOBGFr875H40zIvrq1JyUq7tvJf4mfZ4GyNLfO15HGsMngcA=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <283973066151E34791BD15A1D155FC03@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 84affc7c-9dff-480c-ee07-08d65d7ae59a
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2018 02:06:14.3706
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1757
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-12-08_09:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 07, 2018 at 04:53:13PM -0800, Roman Gushchin wrote:
> If key_type or value_type are of non-trivial data types
> (e.g. structure or typedef), it's not possible to check them without
> the additional information, which can't be obtained without a pointer
> to the btf structure.
>=20
> So, let's pass btf pointer to the map_check_btf() callbacks.
Acked-by: Martin KaFai Lau <kafai@fb.com>