Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2711323imu; Sun, 9 Dec 2018 07:40:31 -0800 (PST) X-Google-Smtp-Source: AFSGD/VoJho+eLg8MbQDMJfzMMJ6ur1OGS4s/ZSrDiASmFarlu6+68faNjMIeE32yF4HNFOXVt4y X-Received: by 2002:a17:902:bf03:: with SMTP id bi3mr9022895plb.83.1544370031358; Sun, 09 Dec 2018 07:40:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544370031; cv=none; d=google.com; s=arc-20160816; b=wLOMgWlyzzxYSJurk+Hd7s1bvqkJDIndJ/oCEvyRsENy5xKQ77bcj8sd3fKTM8gDtE cHwL2slGgiYSgJ/rMMUyn27I2Yu/CBwjire8mLKhHnY0F1i9ZSFgUlBnWo/U0x+kdUuG Qs7shV1IhrgPX4Ygc5besLLzpnkU4yyB4EkIsJ2Hm0V3V949P8hWuFath1ykcdanrne5 eSxN32Kv3DB2XrPkpt9Hew4919TQxVWepgpEUdYwkCYyU8wrPfvlnNAOJ/L+CtNPDhPE YbR42GZdGbzk6gs/3yNjHaQ8BH5UstREVR+mRDcIfVEdradfTHBWZoaidSzY5l+NMNdA 60Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :dkim-signature; bh=xn9zHfMRU5cEXBfv2PSCQh6l4r6br9EzowxeGbDyQvI=; b=O/dz5Fz1ljwpaqkljipiSljSzZNXTwGg5uOFPTonv5KvpU40tVaDQVTLoKXm01DXDG xCyVer+OEfu1bfLnL1/psrtNocFSOw8BvjkKHDkMVTjMlBJdiF0LIkF3N906xsDY/7aZ q8yfgZScPpBEmCmJbWVvxd5re/nNox4IyEJ7EVQ9hRwGY1jTw4sWgiQ/HFIkhp3TJVWc e0MxnqYr1a1REYp1nrBJEUXdTXeUYlAbcAWtg4xmoo0NM+HqT4LA3b5GaOLpmUA62mAn n5Ao5O+oGCcwxSu2ZPve6tTgnudBrxyyqTrwNgCRIWN+QcdShfjPM/NUNhTxZ8wqo8qm BXbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=ov0RTIeg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f5si7826071plo.422.2018.12.09.07.39.43; Sun, 09 Dec 2018 07:40:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=ov0RTIeg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726100AbeLIPh5 (ORCPT + 99 others); Sun, 9 Dec 2018 10:37:57 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:41473 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726085AbeLIPh4 (ORCPT ); Sun, 9 Dec 2018 10:37:56 -0500 Received: by mail-lj1-f196.google.com with SMTP id k15-v6so7408957ljc.8 for ; Sun, 09 Dec 2018 07:37:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xn9zHfMRU5cEXBfv2PSCQh6l4r6br9EzowxeGbDyQvI=; b=ov0RTIegm5dJFOK4OSu62jigja4q6QIc3lffU6ZOcrrw//1DRFXBJiXofN0RBBS5sS Os//kepWechFhNWqtXoYbP0e0A2LkGOMHjIvCTZVWIY+inXO4a3A0x5Pch0WHpA9oZFQ rQLcOfbZOOQRlsEfrHXNwCUBgHDq7dZ2zOWTP5YvOU1T+FuH6/UIVuIxCEPpHoKNfSoB 5vAE+cPzvQCIL/uSEm4tlJ3ipcIKD0L6OiIGrVavCm5BiC2j5tnUyYAmE3UFEWOJiC5H pIX1CL2y4FvqsZEGvGP9UQGtHUF1j//oTRLfem3+XX+yteS1Tr1jA2QB0W5yqpm8I+Hw Uebg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=xn9zHfMRU5cEXBfv2PSCQh6l4r6br9EzowxeGbDyQvI=; b=aLViVCPl4s5QosmAJZcduTcIv7Vg1frIx/mAya23pbfeVk8LOkotJZf3svGW+zBVHC lfVEZP25z0WVFGXA7QbrOTDjBQSKOuKtajkzyRIgpN3fUOm+5HAXP2k3iOBBeSUqAu1g BKONl3vznd40MtCpzBZqjNNTvkhzj5zkPnPkir9GjgmbRyMB39RQelHFLCLXMx5v69vA vRDoREnXNAgRW2ujoh156Qodf8FLlZ14fTWdQ0MymQ1QDpb3HuBKutnoiB5cRG7zvX7h 9w3F14MoD9Cs3PhUx7RCq/Y3Djq2qgzriWmHGV0yCe/Ne8gUdNBm9lL2fplvzKiS/PXN 7rOg== X-Gm-Message-State: AA+aEWawndAkhfANCUxZuCxOTquCQuaWE6+K/7FWUQXYAPINYIWKwyky 3IQofwNUSvRK6HqoS6blP1/JLw== X-Received: by 2002:a2e:2909:: with SMTP id u9-v6mr5287150lje.28.1544369874344; Sun, 09 Dec 2018 07:37:54 -0800 (PST) Received: from wasted.cogentembedded.com ([31.173.84.60]) by smtp.gmail.com with ESMTPSA id e5-v6sm1646274ljj.91.2018.12.09.07.37.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Dec 2018 07:37:53 -0800 (PST) Subject: Re: [PATCH v3 0/2] spi: Add Renesas R-Car Gen3 RPC SPI driver To: Mason Yang , broonie@kernel.org, marek.vasut@gmail.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, boris.brezillon@bootlin.com, linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven Cc: juliensu@mxic.com.tw, Simon Horman , zhengxunli@mxic.com.tw References: <1544181199-3373-1-git-send-email-masonccyang@mxic.com.tw> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <1148d04d-96b1-ef91-e3d9-2603e9a5c6fc@cogentembedded.com> Date: Sun, 9 Dec 2018 18:37:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1544181199-3373-1-git-send-email-masonccyang@mxic.com.tw> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/07/2018 02:13 PM, Mason Yang wrote: > This Renesas R-Car Gen3 RPC SPI driver is based on Boris's new > spi-mem direct mapping read/write mode [1][2]. > > v3 patch is according to Marek and Geert's comments including: > 1) soc_device_mach() to set up RPC_PHYCNT_STRTIM. > 2) get_unaligned() > 3) rpc-mode for rpi-spi-flash or rpc-hyperflash. > 4) coding style and so on. > > > v2 patch including: > 1) remove RPC clock enable/dis-able control, > 2) patch run time PM, > 3) add RPC module software reset, > 4) add regmap, > 5) other coding style and so on. > > thanks for your review. > > best regards, > Mason > > [1] https://patchwork.kernel.org/patch/10670753 > [2] https://patchwork.kernel.org/patch/10670747 > > > Mason Yang (2): > spi: Add Renesas R-Car Gen3 RPC SPI controller driver > dt-binding: spi: Document Renesas R-Car Gen3 RPC controller bindings Probably a stupid question: how did you test this driver (especially the dirmap related parts)? MBR, Sergei