Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2886184imu; Sun, 9 Dec 2018 11:43:50 -0800 (PST) X-Google-Smtp-Source: AFSGD/VGJxPIrGs/qsr79nch4CqjfUfBmOK+mVCoIShAt7CYpJ7emUBR5JmS5bZvqnWU4sTMc/0Y X-Received: by 2002:a65:5a8e:: with SMTP id c14mr8418170pgt.137.1544384630017; Sun, 09 Dec 2018 11:43:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544384629; cv=none; d=google.com; s=arc-20160816; b=wxhyPBsgcbEgdmCA3H74g2fdgYHHFtSk6jnfgE4oiZHyotSN48jiyhLrXB7J1S3F5o bJOVwxFRDR+BuIgMC3uTKQrLU3/K49Ots6G3PKSMizIEk85VN31FVxihtSvT3qZOSjmj 9dvU6zAzYL8oXjcQU8OT/XasSTg3CywEpnxs1DnZCYB57ttAAJNuDrbr7Saw+vxdtSty 3sANEA0ClTHQkMEb3nXTjUmO1BGBc4zTiqcbZdJfk9zwo6oFpAOwmhGFjre8Rq22QXsi cEiqWVIv772skK5NRRtk01y62fDVJRPW7xZzI5pdYwYXsN8CsiP0RJOVXr6fvh7NDiiA ZQ+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=em8MJSmDjnp9a5BRU2NjOw9zU0LEnqNlwNIamfjgiFg=; b=SHVHiFac+22VKbNxjW13+Y2tj3iYf0bYLJjuQZC25figB5UcV/og+tIlFy1RawWOsp jtmXBtQoVy+ZlO3VlmPQBNEhBvWXNCpgmxLIu48hjXQ/jrguXgNPSoR/6VB3r9WW4gyF VMVp1olVluz1CYnDTAxx+oUEqdsrWQCFtZYGC1fzt1wf4lc3Mmzx3gcWsQh8kiNgoRIZ VY5ijlp/pplbkroQ6kw8qG6w75BmBC4iM9dbG5w4VGXx+qsYfabYy8kGNUqY56K9YPEb KsX6uHZJ9//R0cf4IAipK/A8x3vvJqXddHFyjQKXZ61g15M3oOI1gnbzPH9iq5yohaac Eo1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yzq0oRsq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e10si8090625plt.181.2018.12.09.11.43.34; Sun, 09 Dec 2018 11:43:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yzq0oRsq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726255AbeLITkc (ORCPT + 99 others); Sun, 9 Dec 2018 14:40:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:36430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726090AbeLITkc (ORCPT ); Sun, 9 Dec 2018 14:40:32 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3DC402064D; Sun, 9 Dec 2018 19:40:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544384431; bh=rXkESkATq3ArhWI5oSj34Vjf172eyN034mZrie4x80A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yzq0oRsq0LyTGegUS8lCbNGGPOn3DPvdGPsSXYDPtui5nowIN4w8uBfoOHu8/GnXg ZpH0wNsIGDr30S8C+NlyvQYoGK2+d9SywEY9F5jb5+841pwIS7C+m/Nbu8YaGwO5e0 ixdMmR0BleivpPvEW89vM1uQs61mwR3edngk2bEA= Date: Sun, 9 Dec 2018 20:40:29 +0100 From: Greg KH To: Joe Perches Cc: Thomas Jespersen , gaoxiang25@huawei.com, yuchao0@huawei.com, linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: erofs: Add braces to do-while statements Message-ID: <20181209194029.GA31163@kroah.com> References: <20181209155900.10164-1-laumann.thomas@gmail.com> <20181209162007.GA22432@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 09, 2018 at 09:27:01AM -0800, Joe Perches wrote: > On Sun, 2018-12-09 at 17:20 +0100, Greg KH wrote: > > On Sun, Dec 09, 2018 at 04:59:00PM +0100, Thomas Jespersen wrote: > > > This fixes warning reported by sparse (with -Wsparse-all). > > > > Why is sparse warning about this? > > Probably because it's the kernel preferred style > to use single statement > > do { > ; > } while (); > > over > > by about a 20:1 ratio. Sparse is spitting out coding style complaints now?