Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2981152imu; Sun, 9 Dec 2018 14:12:58 -0800 (PST) X-Google-Smtp-Source: AFSGD/Wk8I+DFd4Qz4Mj1+DmlFjsTyXs+olEMAdat0EgD3LZLzT0ZUhnog8Eox6qoWcEQizbcMFH X-Received: by 2002:a63:5455:: with SMTP id e21mr8925245pgm.316.1544393578255; Sun, 09 Dec 2018 14:12:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544393578; cv=none; d=google.com; s=arc-20160816; b=Zm4UP9xRyU2JBHOOJukXQlU52ZFN1VDQLI6Pb5PVls9PJo0eeTxdpN+KgWm9hlKRHi BmE/rTp6aVq1kunWJzqTSFIKHDt6EbaGrv+B310DF2mHNiLXsP5WVnN3FuR5pW+FaTHY FnUjWOWaB2chuvjU9/FAo33AbgYPKN45IphRRA636Tgy1HV7QYa2nUBLQYk3IVzLrnL9 1+pO0nk1IkTEEi/dl3Mr1n5AhYqWhaaL1rFwBzbjOTVOU7iI+aq5WauhZUlCYvNYbTNF nI2HXRqpCBWo4vFq8ERO0MsaGKXEfcnHFY438dMjk4uSB/v6rrIfsksfC8yC0YivVyyr wyzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:subject:message-id:date:cc:to :from:mime-version:content-transfer-encoding:content-disposition; bh=DovpBPtka8DBtTHkeQ3JpbCgffJe2TpfcmCDuXBJioQ=; b=gQThlTDY+2k98VoOwb+AeQ0sUJC/lvnUx3YcKndOTiF0DS7B6T0Q5hBzrgu7rMB4DV vX/V4/7z2VSlQC06C6wmec19AVVbG1AlExhMcCICeFCeeKj5MiXif1dAKyrX25mg+l85 pshIEf2+M2iK6C2MkobUVP2bHdkycxP9ozoDFjNjy+XDzpvBr1wP1rsBA1MZ8TT1VMWY RktP25M44u6KYhso+oOQ2I9GOI5t91MNv3o01lFxVkBqEI+LFar/1THbiOsLfJQ1UP6H PVU9+PhCeratbNp+VIDUR88Bwg7ZnekrR3YYbf1WDK+KReyNaVgwHoLS1JlNsN4zpMXi th5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d34si7649578pgb.43.2018.12.09.14.12.43; Sun, 09 Dec 2018 14:12:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728231AbeLIWLR (ORCPT + 99 others); Sun, 9 Dec 2018 17:11:17 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:37668 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728215AbeLIWLP (ORCPT ); Sun, 9 Dec 2018 17:11:15 -0500 Received: from pub.yeoldevic.com ([81.174.156.145] helo=deadeye) by shadbolt.decadent.org.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gW73I-0002po-JN; Sun, 09 Dec 2018 21:55:52 +0000 Received: from ben by deadeye with local (Exim 4.91) (envelope-from ) id 1gW72c-0003M6-Dm; Sun, 09 Dec 2018 21:55:10 +0000 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "Anand Jain" , "Chris Mason" , "David Sterba" , "Anand Jain" Date: Sun, 09 Dec 2018 21:50:33 +0000 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) X-Patchwork-Hint: ignore Subject: [PATCH 3.16 111/328] btrfs: rename total_bytes to avoid confusion In-Reply-To: X-SA-Exim-Connect-IP: 81.174.156.145 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.16.62-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Anand Jain commit 3c1dbdf54a31f4f049a33214c3096595988786bf upstream. we are assigning number_devices to the total_bytes, that's very confusing for a moment Signed-off-by: Anand Jain Reviewed-by: David Sterba Signed-off-by: Chris Mason Signed-off-by: Ben Hutchings --- fs/btrfs/volumes.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -2039,7 +2039,7 @@ int btrfs_init_new_device(struct btrfs_r struct list_head *devices; struct super_block *sb = root->fs_info->sb; struct rcu_string *name; - u64 total_bytes; + u64 tmp; int seeding_dev = 0; int ret = 0; @@ -2142,13 +2142,13 @@ int btrfs_init_new_device(struct btrfs_r if (!blk_queue_nonrot(bdev_get_queue(bdev))) root->fs_info->fs_devices->rotating = 1; - total_bytes = btrfs_super_total_bytes(root->fs_info->super_copy); + tmp = btrfs_super_total_bytes(root->fs_info->super_copy); btrfs_set_super_total_bytes(root->fs_info->super_copy, - total_bytes + device->total_bytes); + tmp + device->total_bytes); - total_bytes = btrfs_super_num_devices(root->fs_info->super_copy); + tmp = btrfs_super_num_devices(root->fs_info->super_copy); btrfs_set_super_num_devices(root->fs_info->super_copy, - total_bytes + 1); + tmp + 1); /* add sysfs device entry */ btrfs_kobj_add_device(root->fs_info, device);