Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 10 Dec 2018 06:36:42 +0000
From:   Lee Jones <lee.jones@linaro.org>
To:     Oskari Lemmela <oskari@lemmela.net>
Cc:     Chen-Yu Tsai <wens@csie.org>,
        Quentin Schulz <quentin.schulz@bootlin.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/2] mfd: axp20x: Re-align mfd cell entries
Message-ID: <20181210063642.GT26661@dell>
References: <20181208175847.32068-1-oskari@lemmela.net>
 <20181208175847.32068-2-oskari@lemmela.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20181208175847.32068-2-oskari@lemmela.net>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 08 Dec 2018, Oskari Lemmela wrote:

> From: Chen-Yu Tsai <wens@csie.org>
> 
> In the axp20x driver, the various mfd_cell lists had varying amounts
> of indentation, sometimes even within the same list. For the axp288,
> there's no alignment at all.
> 
> Re-align the right hand side of the assignments with the least amount
> of tabs possible. Also collapse the closing bracket and the opening
> bracket of the next entry onto the same line for the axp288, to be
> consistent with all the other mfd_cell lists.
> 
> This patch is whitespace change only. No functionality is modified.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Oskari Lemmela <oskari@lemmela.net>

Why is Oskari Lemmela's SoB here?

You both authored this alignment patch?

> ---
>  drivers/mfd/axp20x.c | 107 +++++++++++++++++++++----------------------
>  1 file changed, 51 insertions(+), 56 deletions(-)
> 
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index dfc3cff1d08b..8037b4e01ed6 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -640,9 +640,9 @@ static const struct mfd_cell axp221_cells[] = {
>  
>  static const struct mfd_cell axp223_cells[] = {
>  	{
> -		.name			= "axp221-pek",
> -		.num_resources		= ARRAY_SIZE(axp22x_pek_resources),
> -		.resources		= axp22x_pek_resources,
> +		.name		= "axp221-pek",
> +		.num_resources	= ARRAY_SIZE(axp22x_pek_resources),
> +		.resources	= axp22x_pek_resources,
>  	}, {
>  		.name		= "axp22x-adc",
>  		.of_compatible	= "x-powers,axp221-adc",
> @@ -650,7 +650,7 @@ static const struct mfd_cell axp223_cells[] = {
>  		.name		= "axp20x-battery-power-supply",
>  		.of_compatible	= "x-powers,axp221-battery-power-supply",
>  	}, {
> -		.name			= "axp20x-regulator",
> +		.name		= "axp20x-regulator",
>  	}, {
>  		.name		= "axp20x-ac-power-supply",
>  		.of_compatible	= "x-powers,axp221-ac-power-supply",
> @@ -666,9 +666,9 @@ static const struct mfd_cell axp223_cells[] = {
>  
>  static const struct mfd_cell axp152_cells[] = {
>  	{
> -		.name			= "axp20x-pek",
> -		.num_resources		= ARRAY_SIZE(axp152_pek_resources),
> -		.resources		= axp152_pek_resources,
> +		.name		= "axp20x-pek",
> +		.num_resources	= ARRAY_SIZE(axp152_pek_resources),
> +		.resources	= axp152_pek_resources,
>  	},
>  };
>  
> @@ -697,84 +697,79 @@ static const struct resource axp288_charger_resources[] = {
>  
>  static const struct mfd_cell axp288_cells[] = {
>  	{
> -		.name = "axp288_adc",
> -		.num_resources = ARRAY_SIZE(axp288_adc_resources),
> -		.resources = axp288_adc_resources,
> -	},
> -	{
> -		.name = "axp288_extcon",
> -		.num_resources = ARRAY_SIZE(axp288_extcon_resources),
> -		.resources = axp288_extcon_resources,
> -	},
> -	{
> -		.name = "axp288_charger",
> -		.num_resources = ARRAY_SIZE(axp288_charger_resources),
> -		.resources = axp288_charger_resources,
> -	},
> -	{
> -		.name = "axp288_fuel_gauge",
> -		.num_resources = ARRAY_SIZE(axp288_fuel_gauge_resources),
> -		.resources = axp288_fuel_gauge_resources,
> -	},
> -	{
> -		.name = "axp221-pek",
> -		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
> -		.resources = axp288_power_button_resources,
> -	},
> -	{
> -		.name = "axp288_pmic_acpi",
> +		.name		= "axp288_adc",
> +		.num_resources	= ARRAY_SIZE(axp288_adc_resources),
> +		.resources	= axp288_adc_resources,
> +	}, {
> +		.name		= "axp288_extcon",
> +		.num_resources	= ARRAY_SIZE(axp288_extcon_resources),
> +		.resources	= axp288_extcon_resources,
> +	}, {
> +		.name		= "axp288_charger",
> +		.num_resources	= ARRAY_SIZE(axp288_charger_resources),
> +		.resources	= axp288_charger_resources,
> +	}, {
> +		.name		= "axp288_fuel_gauge",
> +		.num_resources	= ARRAY_SIZE(axp288_fuel_gauge_resources),
> +		.resources	= axp288_fuel_gauge_resources,
> +	}, {
> +		.name		= "axp221-pek",
> +		.num_resources	= ARRAY_SIZE(axp288_power_button_resources),
> +		.resources	= axp288_power_button_resources,
> +	}, {
> +		.name		= "axp288_pmic_acpi",
>  	},
>  };
>  
>  static const struct mfd_cell axp803_cells[] = {
>  	{
> -		.name			= "axp221-pek",
> -		.num_resources		= ARRAY_SIZE(axp803_pek_resources),
> -		.resources		= axp803_pek_resources,
> +		.name		= "axp221-pek",
> +		.num_resources	= ARRAY_SIZE(axp803_pek_resources),
> +		.resources	= axp803_pek_resources,
>  	},
> -	{	.name			= "axp20x-regulator" },
> +	{	.name		= "axp20x-regulator" },
>  };
>  
>  static const struct mfd_cell axp806_self_working_cells[] = {
>  	{
> -		.name			= "axp221-pek",
> -		.num_resources		= ARRAY_SIZE(axp806_pek_resources),
> -		.resources		= axp806_pek_resources,
> +		.name		= "axp221-pek",
> +		.num_resources	= ARRAY_SIZE(axp806_pek_resources),
> +		.resources	= axp806_pek_resources,
>  	},
> -	{	.name			= "axp20x-regulator" },
> +	{	.name		= "axp20x-regulator" },
>  };
>  
>  static const struct mfd_cell axp806_cells[] = {
>  	{
> -		.id			= 2,
> -		.name			= "axp20x-regulator",
> +		.id		= 2,
> +		.name		= "axp20x-regulator",
>  	},
>  };
>  
>  static const struct mfd_cell axp809_cells[] = {
>  	{
> -		.name			= "axp221-pek",
> -		.num_resources		= ARRAY_SIZE(axp809_pek_resources),
> -		.resources		= axp809_pek_resources,
> +		.name		= "axp221-pek",
> +		.num_resources	= ARRAY_SIZE(axp809_pek_resources),
> +		.resources	= axp809_pek_resources,
>  	}, {
> -		.id			= 1,
> -		.name			= "axp20x-regulator",
> +		.id		= 1,
> +		.name		= "axp20x-regulator",
>  	},
>  };
>  
>  static const struct mfd_cell axp813_cells[] = {
>  	{
> -		.name			= "axp221-pek",
> -		.num_resources		= ARRAY_SIZE(axp803_pek_resources),
> -		.resources		= axp803_pek_resources,
> +		.name		= "axp221-pek",
> +		.num_resources	= ARRAY_SIZE(axp803_pek_resources),
> +		.resources	= axp803_pek_resources,
>  	}, {
> -		.name			= "axp20x-regulator",
> +		.name		= "axp20x-regulator",
>  	}, {
> -		.name			= "axp20x-gpio",
> -		.of_compatible		= "x-powers,axp813-gpio",
> +		.name		= "axp20x-gpio",
> +		.of_compatible	= "x-powers,axp813-gpio",
>  	}, {
> -		.name			= "axp813-adc",
> -		.of_compatible		= "x-powers,axp813-adc",
> +		.name		= "axp813-adc",
> +		.of_compatible	= "x-powers,axp813-adc",
>  	}, {
>  		.name		= "axp20x-battery-power-supply",
>  		.of_compatible	= "x-powers,axp813-battery-power-supply",

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog