Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3398592imu; Mon, 10 Dec 2018 01:16:08 -0800 (PST) X-Google-Smtp-Source: AFSGD/UA9meNV042t68sLsC2nzJZ5qq2g/bP8JuGAXQ8wMn8Joq8VaT7fbPUe9ASswB2nRXmLqZX X-Received: by 2002:a62:29c3:: with SMTP id p186mr11822024pfp.117.1544433368886; Mon, 10 Dec 2018 01:16:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544433368; cv=none; d=google.com; s=arc-20160816; b=mpzy32z2hM3n6XrCNMgUmJWPkf45CJ0NJUSh4YUT9uHWSMyNEYoLvYT83Uql7qGiWt X8Ux0stR5TL8jYORaPnZLdi5iFnUFzgGkMYmhB8W0I6VXaLdnrS7GqPvMeRiW14ywS9C yrmneWab89sHeLQeBKqaA6Uz2O3yqkTmxCrcZBq42eJaTstnfr2f13BKGsBPW9sBN7Sy gkDONk82+qXs2Gr/8zim78sKZwpofOirpL04LqUej5vk9PTkNgp1pyDFCGQuQVCec/u4 +D/S1QSQ9dHG9HPTMKC0jmcAhtEJ9Tide4J+fL7xPeMxdB0bkZZlwH9mUm++0xf2qNBZ iRBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=/d+3JhZxpau7fjJYTn4S29wVHsIPpgiQHi+fjdhXsj4=; b=qYjp2UymkPIE/+lHf99c9tRZeIZyGxGCqgrSVCEWMpPD/1+WO6x1lY7ySWu3acHW1v 0LZMQWmQKokE2F835isdkCxZAYWD34vDAXH20LQKwCXLziFyKnNA/bxU1Y3EyR2JqJe/ Lc/QtZejlAaLLmWTS1UQWAzXlrVGJSGVXkJhzMqJY2I9SPatP1cL655BkWgHGudJ+PTo xg/cAc68eXt8i+NmcWyhUHlO8cAqB38OYI/P2f7PFi+FITwXEDtoS1kLmLvmDxgUaixL jgPrEItw7YJzU7NzpFOWr7v8VrFCjfZkmSIRtBBVaRM0I1V3V1EJaAOVna3NgkDvZ3uF GtYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u4si9362722pga.91.2018.12.10.01.15.52; Mon, 10 Dec 2018 01:16:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726610AbeLJIkP (ORCPT + 99 others); Mon, 10 Dec 2018 03:40:15 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:46248 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbeLJIkP (ORCPT ); Mon, 10 Dec 2018 03:40:15 -0500 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.91 #2 (Red Hat Linux)) id 1gWH6Z-0001LW-LR; Mon, 10 Dec 2018 08:39:55 +0000 Date: Mon, 10 Dec 2018 08:39:55 +0000 From: Al Viro To: Chanho Min Cc: Andrew Morton , Kees Cook , "Eric W. Biederman" , "David S. Miller" , Michal Hocko , Alexei Starovoitov , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Seungho Park Subject: Re: [PATCH] exec: make prepare_bprm_creds static Message-ID: <20181210083955.GE2217@ZenIV.linux.org.uk> References: <1544428194-2431-1-git-send-email-chanho.min@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1544428194-2431-1-git-send-email-chanho.min@lge.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 10, 2018 at 04:49:54PM +0900, Chanho Min wrote: > prepare_bprm_creds is not used outside exec.c, so there's no reason for it > to have external linkage. Applied...