Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <balbi@kernel.org>
To:     Anurag Kumar Vulisha <anuragku@xilinx.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Shuah Khan <shuah@kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Johan Hovold <johan@kernel.org>,
        Jaejoong Kim <climbbb.kim@gmail.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Roger Quadros <rogerq@ti.com>,
        Manu Gautam <mgautam@codeaurora.org>,
        "martin.petersen\@oracle.com" <martin.petersen@oracle.com>,
        Bart Van Assche <bvanassche@acm.org>,
        Mike Christie <mchristi@redhat.com>,
        Matthew Wilcox <willy@infradead.org>,
        Colin Ian King <colin.king@canonical.com>
Cc:     "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "v.anuragkumar\@gmail.com" <v.anuragkumar@gmail.com>,
        Thinh Nguyen <thinhn@synopsys.com>,
        Tejas Joglekar <tejas.joglekar@synopsys.com>,
        Ajay Yugalkishore Pandey <APANDEY@xilinx.com>
Subject: RE: [PATCH v7 09/10] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields
In-Reply-To: <BL0PR02MB56338A2EA4515527AA0EECF5A7A50@BL0PR02MB5633.namprd02.prod.outlook.com>
References: <1543662811-5194-1-git-send-email-anurag.kumar.vulisha@xilinx.com> <1543662811-5194-10-git-send-email-anurag.kumar.vulisha@xilinx.com> <875zw82vfj.fsf@linux.intel.com> <BL0PR02MB563352F83A80E3B92347A7A4A7A80@BL0PR02MB5633.namprd02.prod.outlook.com> <874lbpx3vg.fsf@linux.intel.com> <BL0PR02MB56331B2ECFFEB96A99936C32A7AB0@BL0PR02MB5633.namprd02.prod.outlook.com> <87pnu927oq.fsf@linux.intel.com> <BL0PR02MB56338A2EA4515527AA0EECF5A7A50@BL0PR02MB5633.namprd02.prod.outlook.com>
Date:   Mon, 10 Dec 2018 11:03:07 +0200
Message-ID: <87efap21pw.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Anurag Kumar Vulisha <anuragku@xilinx.com> writes:
>>>>> Thanks for reviewing this patch. Lets consider an example where a
>>>>> request has num_sgs > 0 and each sg is mapped to a TRB and the last
>>>>> TRB has the IOC bit set. Once the controller is done with the
>>>>> transfer, it  generates XferInProgress for the last TRB (since IOC bit
>>>>> is set). As a part of trb reclaim process
>>>>> dwc3_gadget_ep_reclaim_trb_sg() calls
>>>>> dwc3_gadget_ep_reclaim_completed_trb() for req->num_sgs times. Since
>>>>> the event already has the IOC bit set, the loop is exited from the
>>>>> loop at the very first TRB and the remaining TRBs (mapped to the sgli=
st) are left
>>>>unhandled.
>>>>> To avoid this we modified the code to exit only if both TRB & event
>>>>> has the IOC bit set.
>>>>
>>>>Seems like IOC case should just test for chain flag as well:
>>>>
>>>
>>> Okay. Along with this logic the code for updating chain bit should also=
 be modified I
>>guess.
>>
>>not really
>>
>>> Since the IOC bit is also set when there are not enough TRBs available,=
 the code
>>should be
>>> modified to not set DWC3_TRB_CTRL_CHN bit when the IOC bit is set. I wi=
ll update
>>below
>>> changes along with your suggestions and resend the patches.
>>
>>no. Actually I don't think we're allowed to split a scatter/gather like
>>that. I did that quite a while ago, but I don't think we're allowed to
>>do so. What we should do, in that case, is not even queue that request
>>until we have enough for all members of the scatter/gather. But that's a
>>separate patch, anyway.
>>
>
> Okay. I have a doubt here, not pushing the request until all sgs are mapp=
ed to enough TRBs
> might remove the driver complexity but reduce the performance (since we a=
re waiting
> until enough TRBs are available). Are we okay with that?=20=20

The only other way would be to copy the buffer over to a contiguous
buffer. That will also reduce performance. I think we need to consider
how frequently this may actually happen. I dare to say we don't have any
usb function in kernel as of today that can, easily and frequently, fall
into such a situation. Besides, the performance loss can be amortized by
a deeper request queue.

IMO, this is a minor problem. But, certainly, if you have the setup,
_do_ run some benchmarking and report your findings :-)

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlwOK8sACgkQzL64meEa
mQaXhA//bnb/3Wsz/IBeBQWc3LG+ucRpdOc0SXEXvKyxFDyCDpHZx5jmFXP7IubP
4vjBeiLmOjK+Nduqe6dcot/tfjM7UDgXdvtVKHXnfMTUiH2lzB2spl/8E4Yt6PM6
MMV3nBip4jcu/stg6Y2eQf4k22zZyMJZ4W1qA/ibueQn0sDsNH6y7R004Eaesiqw
StteapMe8Ke6o63db/5wviU4UAditIDSkOcPwTkuXXKoQX84g4jUxUPFQqDXXGWX
SDfl7uX4YVhdloKxgMinogN9qBHNqc+Z3ZAKwtM/Z97vdqz9YOx21EGTqlbMwV2B
MwG+rT4Rtrt4Ay77QfHojV+qxF5Lq8As8/7jloFRl365sIoUnoDhhPezHPPM1OPi
h0bAxwlgOF8sGKQT8o6BfwV6mNnj7EvPVx02mwlRH+8ZW6ASUFcRw8VZ8VDSsQi3
0RuzP5TsXLKe5fOR2PVvTRgtkjOIwajUr4PhZMves9tSdFc4MVQVrFftRu7A7w5K
Kmg/t5V99ZvCQWX9rGJ252flo2n6ZX+roPNtk8z4Iw3/3HvWs+ON7osnoE8EoTnO
kUl5GROJ5UAFZPgcCuTv+KnZX5A71P7VLp7VY1EKL+k6jlWO9V/iMbS/CuRWZ79P
OC0aAHz8wlR40dWf6ILeaCg/AY1UW1Xvv/NGEfqrZfguPf2RDZE=
=d0zW
-----END PGP SIGNATURE-----
--=-=-=--