Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3434203imu; Mon, 10 Dec 2018 02:03:04 -0800 (PST) X-Google-Smtp-Source: AFSGD/Ukjpgwt/H6iBNJavjlMxSemzll6QQvIWIH0Z4HskKT8Jjpiq5rz1IC4S53PNvxUZru1b6X X-Received: by 2002:a17:902:4681:: with SMTP id p1mr11877156pld.184.1544436184556; Mon, 10 Dec 2018 02:03:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544436184; cv=none; d=google.com; s=arc-20160816; b=UKPf3s0/QwXrrtBdriGkFUUIVnEHfC3wfcfRFx+BVJ+5mpFdDuU3o6zQweCmmWUrog sn/mc1Uym5+wHzYmoR8NCf43v7jU/pc4E8/bIJgJn/aOpRbCmDs5nQq0SOKjpIdiCdP+ uktTggWWik4xiro4YoX1PLMXQaz4tfMJ7oLLX43dCjRkQXez5iyIMmuls8a9brjLiJVc 0NgxELiC5FrOM/nf6fi5X1bJcuLYR6rbj33aJMfuh7S6RNJX6L1mR+Xb4IfTmrogl9Gy YeQW4mvzzQs5C8/NzRlN4+MUtl2WzFDx/MQ2lMN0eVv6+Po6u0E8771AOTOXXYLjFjUD AGoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature:dkim-signature; bh=eiL5DR6Vc0F8tJYXy+61P3d5saxWpsotgHIKnefrr30=; b=FuqAKc8J/oZmc4taZeHctNrQNZULvg//Z2S8GEDLxtDo7zLanLBeUoRuPRAxYVuZbF thyW+eMKDNtzITnpfaOhFEULNV6maPk7iJSc6GO0snxGoTGFxt7ke76A66HfxKY3n8N4 8HtjeMPBe9NX9dW/drAstqkViEHGXq64dQjzctVaK0kQkgkaJGvBu1OhMW71Qgy14qvq LKP1jsU2ca5JadQ93HMvxCEdKAumSI4VVPbr67dm3aZ6RaMtK7YKn0eD4eZDq0shLXfx HxHh0qGdqUqvoolGJ2qQko7g4EG7W3TXc1AUnESI0pwncHBUK8CbBXdsyeiOQNO8P7dd xUNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="FQAd/Kcq"; dkim=pass header.i=@codeaurora.org header.s=default header.b=CXcInnOG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 76si10456359pfw.66.2018.12.10.02.02.47; Mon, 10 Dec 2018 02:03:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="FQAd/Kcq"; dkim=pass header.i=@codeaurora.org header.s=default header.b=CXcInnOG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726942AbeLJKBZ (ORCPT + 99 others); Mon, 10 Dec 2018 05:01:25 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:52270 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726136AbeLJKBZ (ORCPT ); Mon, 10 Dec 2018 05:01:25 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1B5D660A31; Mon, 10 Dec 2018 10:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1544436084; bh=I7AxhQwQHysEjPDandmm/jeeMAur+STPiMaBPDh2vN4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FQAd/KcqwXE22S3tZ1TYoCrdfSwVph2kldE+P6IckGfYdcOyBDtJ0HnRZIypKVotT NMoJzvaIguwAFiY9sfS/w4fRTWau4RqCb+HsZquU9/+66UQey//rXKzcO4J6voDRVT RuiUx5BXMTGj+2tqztyn5KYVBxjKkBEdhlymeBno= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id B8B8860241; Mon, 10 Dec 2018 10:01:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1544436083; bh=I7AxhQwQHysEjPDandmm/jeeMAur+STPiMaBPDh2vN4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CXcInnOGJIU+bLryvuAqpsaMaq1gWgaGoRWmIfN4927UTONX7HxeEdpZO/9uCOTWq 0dpk6zdj+NOkwApLr204tNdJX4qDc8BT+VoWOTfwrkultaLJ8uMXMeDOr3jOwXwfUm TvlZNxYEQtTSYcAM9pFXiANh1EvA5vQWvRBKS3rc= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 10 Dec 2018 18:01:23 +0800 From: yuankuiz@codeaurora.org To: Alexandre Belloni Cc: a.zummo@towertech.it, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc-owner@vger.kernel.org Subject: Re: [PATCH] rtc: proc: printf using alarm for alrm In-Reply-To: <20181206203827.GE8952@piout.net> References: <20181206203827.GE8952@piout.net> Message-ID: <6997a28d4752ce340638f3de5a655d4d@codeaurora.org> X-Sender: yuankuiz@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-12-07 04:38 AM, Alexandre Belloni wrote: > On 06/12/2018 15:22:51+0800, yuankuiz@codeaurora.org wrote: >> Hi, >> >> Kindly, this format change formats the rtc dump from: >> alrm_time : 00:00:00 >> alrm_date : 1970-01-01 >> alarm_IRQ : no >> alrm_pending : no >> >> to: >> alarm time : 00:00:00 >> alarm date : 1970-01-01 >> alarm IRQ : no >> alarm pending : no >> > > Yes, and this would break the ABI as this file is in procfs. This is > not > something I'm willing to do, especially since this file has been > deprecated since 2006. OK. So shall we default it as n like: diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index a819ef0..c51f0e1 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -100,7 +100,7 @@ config RTC_INTF_SYSFS config RTC_INTF_PROC bool "/proc/driver/rtc (procfs for rtcN)" depends on PROC_FS - default RTC_CLASS + default n help Say yes here if you want to use your system clock RTC through the proc interface, /proc/driver/rtc. Thanks, BR//John Zhao