Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Wen Yang <wen.yang99@zte.com.cn>
To:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn,
        Wen Yang <wen.yang99@zte.com.cn>
Subject: [PATCH] VMCI: Use memdup_user() rather than duplicating its implementation
Date:   Mon, 10 Dec 2018 19:36:07 +0800
Message-Id: <20181210113607.46154-1-wen.yang99@zte.com.cn>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Reuse existing functionality from memdup=5Fuser() instead of keeping
duplicate source code.

This issue was detected by using the Coccinelle software.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
CC: Arnd Bergmann <arnd@arndb.de>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: linux-kernel@vger.kernel.org
---
 drivers/misc/vmw=5Fvmci/vmci=5Fhost.c | 18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/drivers/misc/vmw=5Fvmci/vmci=5Fhost.c b/drivers/misc/vmw=5Fvmc=
i/vmci=5Fhost.c
index edfffc9699ba..5da1f3e3f997 100644
--- a/drivers/misc/vmw=5Fvmci/vmci=5Fhost.c
+++ b/drivers/misc/vmw=5Fvmci/vmci=5Fhost.c
@@ -750,19 +750,10 @@ static int vmci=5Fhost=5Fdo=5Fctx=5Fset=5Fcpt=5Fstate=
(struct vmci=5Fhost=5Fdev *vmci=5Fhost=5Fdev,
 	if (copy=5Ffrom=5Fuser(&set=5Finfo, uptr, sizeof(set=5Finfo)))
 		return -EFAULT;
=20
-	cpt=5Fbuf =3D kmalloc(set=5Finfo.buf=5Fsize, GFP=5FKERNEL);
-	if (!cpt=5Fbuf) {
-		vmci=5Fioctl=5Ferr(
-			"cannot allocate memory to set cpt state (type=3D%d)\n",
-			set=5Finfo.cpt=5Ftype);
-		return -ENOMEM;
-	}
-
-	if (copy=5Ffrom=5Fuser(cpt=5Fbuf, (void =5F=5Fuser *)(uintptr=5Ft)set=5Fi=
nfo.cpt=5Fbuf,
-			   set=5Finfo.buf=5Fsize)) {
-		retval =3D -EFAULT;
-		goto out;
-	}
+	cpt=5Fbuf =3D memdup=5Fuser((void =5F=5Fuser *)(uintptr=5Ft)set=5Finfo.cp=
t=5Fbuf,
+				set=5Finfo.buf=5Fsize);
+	if (IS=5FERR(cpt=5Fbuf))
+		return PTR=5FERR(cpt=5Fbuf);
=20
 	cid =3D vmci=5Fctx=5Fget=5Fid(vmci=5Fhost=5Fdev->context);
 	set=5Finfo.result =3D vmci=5Fctx=5Fset=5Fchkpt=5Fstate(cid, set=5Finfo.cp=
t=5Ftype,
@@ -770,7 +761,6 @@ static int vmci=5Fhost=5Fdo=5Fctx=5Fset=5Fcpt=5Fstate(s=
truct vmci=5Fhost=5Fdev *vmci=5Fhost=5Fdev,
=20
 	retval =3D copy=5Fto=5Fuser(uptr, &set=5Finfo, sizeof(set=5Finfo)) ? -EFA=
ULT : 0;
=20
-out:
 	kfree(cpt=5Fbuf);
 	return retval;
 }
--=20
2.19.1