Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     Leo Li <leoyang.li@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        Horia Geanta <horia.geanta@nxp.com>,
        Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
        Roy Pledge <roy.pledge@nxp.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: [PATCH 5/5] bus: fsl-mc: automatically add a device_link on
 fsl_mc_[portal,object]_allocate
Thread-Topic: [PATCH 5/5] bus: fsl-mc: automatically add a device_link on
 fsl_mc_[portal,object]_allocate
Thread-Index: AQHUkKhvHkf6CgsRQ0WduTjo1m5H8A==
Date:   Mon, 10 Dec 2018 16:50:19 +0000
Message-ID: <1544460591-14888-6-git-send-email-ioana.ciornei@nxp.com>
References: <1544460591-14888-1-git-send-email-ioana.ciornei@nxp.com>
In-Reply-To: <1544460591-14888-1-git-send-email-ioana.ciornei@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [86.34.165.90]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;VI1PR0402MB3904;6:ybVO453he2/cOv+/69YpAvHjoqrZWhjXIpwA8iQKkI/j8+KBoms1fnMuEm53MCE5VY/m3JFpe3MxoAAs5AqhXdwSt46vGsjsG5XXnQsa0HgDHxr6A7VZqV9nKcI6lgeNexkb6ieF+R3kzQXmLA+cBS6odceW3I8ubNcaCufuYR6eR0JD/j/gFivFpZALgq7/nOH2RwFQlXVHjVMPryiAikwLMDgQXwNACDOedJqnDql7omdzg5o7LilLC1ZHE7jAntyW4RIBzT1FefL3vh5b83LTGrbbsQZgkaKgD9N4DmFdHQTpD5QhbudoYaE9PvG2FODY6K14Ni3XaEONi0kIJWrR4qMzFsnIMxxa5lrsQyx7qFeVPWIsboVzyyAsoo6bI31wg75Ij8srJwgEjgpGlWjbl/E11SO7loAEX9Op2swlBse5vkoIlxQSASDR7MJuJxVBNPGRoeQZ4+aobf1H0w==;5:jMG4fStHCyN8I8e5m20J/5QHa4rQn0L0VaZN/BRkbepInrwMYYRYR7iyDrQ7YbPo2HLuT9QIDyHC9vE0X+xxvBGLvbDZwjxWKc82sAbXVBhhSfIBQ54T+z+NfzKhggcNzYjFTtQJQazlbqE4Qf/X2TAEi777bnZgSaXd+O0GL8o=;7:oIQIVmbwez5dMQ7zCPI3X5pTr2G3cvjjy8HFRzDqhUI3IKVKEDZbr1cEvKtFsdhBUgTRZIj14eoiABjHu2N/nScwkE8XqMqWS2qA+U5J8qDgPAtTV9WFTpaF8OPiQiJE1pkYVdPUmatr2fW8S4X5uA==
x-ms-office365-filtering-correlation-id: b3a6d845-1591-4b4f-dc1e-08d65ebf9195
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR0402MB3904;
x-ms-traffictypediagnostic: VI1PR0402MB3904:
x-microsoft-antispam-prvs: <VI1PR0402MB3904FAFC4C685D205C9DFE47E0A50@VI1PR0402MB3904.eurprd04.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231455)(999002)(944501520)(52105112)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(201708071742011)(7699051)(76991095);SRVR:VI1PR0402MB3904;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0402MB3904;
x-forefront-prvs: 08828D20BC
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(376002)(346002)(396003)(39860400002)(136003)(199004)(189003)(6486002)(4326008)(14444005)(44832011)(386003)(6506007)(486006)(316002)(68736007)(256004)(446003)(11346002)(52116002)(6436002)(2616005)(186003)(8676002)(8936002)(2906002)(26005)(81156014)(81166006)(97736004)(5660300001)(3846002)(478600001)(36756003)(14454004)(6116002)(2501003)(2201001)(25786009)(71190400001)(71200400001)(106356001)(105586002)(53936002)(305945005)(6512007)(76176011)(476003)(102836004)(54906003)(99286004)(7736002)(86362001)(110136005)(66066001)(142933001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0402MB3904;H:VI1PR0402MB2800.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
x-microsoft-antispam-message-info: /wj2eVPb4Rv5/sd/8SXCfzVhp9Nn7IPB76ivDQmAJuEq3bP3njQ7tUOxC9QeIaloiVkHF0w9jAQfEmgWJEbCQzAamsBGEp6GlCQlkr4aE01Wbjpe+GvQnnY5jaQNS7IwY0GWOv1C1bsvvAsvweKPVWm6RvY6QE94vVtFu5iH3aNzCYtVqP9AsAZVFeOq7aRuaT+LwZSWuRWwZmswPiTnY4lUyvr12muWnfY/0UtfLZ/1KHGJshp2s01ZlMkiSppe4aZ9atj6gO2sfqxhwYw+j+menepRVOsR/5UB/nzglmeLPf0zrJLR/6frq7I5um8O
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3a6d845-1591-4b4f-dc1e-08d65ebf9195
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2018 16:50:19.7118
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3904
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Allocatable devices can be acquired by drivers on the fsl-mc bus using
the fsl_mc_portal_allocate or fsl_mc_object_allocate functions. Add a
device link between the consumer device and the supplier device so that
proper resource management is achieved.
Also, adding a link between these devices ensures that a proper unbind
order is respected (ie before the supplier device is unbound from its
respective driver all consumer devices will be notified and unbound
first).

Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
 drivers/bus/fsl-mc/fsl-mc-allocator.c | 11 +++++++++++
 drivers/bus/fsl-mc/mc-io.c            | 13 +++++++++++++
 include/linux/fsl/mc.h                |  1 +
 3 files changed, 25 insertions(+)

diff --git a/drivers/bus/fsl-mc/fsl-mc-allocator.c b/drivers/bus/fsl-mc/fsl=
-mc-allocator.c
index e906ecfe..8ad7724 100644
--- a/drivers/bus/fsl-mc/fsl-mc-allocator.c
+++ b/drivers/bus/fsl-mc/fsl-mc-allocator.c
@@ -295,6 +295,14 @@ int __must_check fsl_mc_object_allocate(struct fsl_mc_=
device *mc_dev,
 	if (!mc_adev)
 		goto error;
=20
+	mc_adev->consumer_link =3D device_link_add(&mc_dev->dev,
+						 &mc_adev->dev,
+						 DL_FLAG_AUTOREMOVE_CONSUMER);
+	if (!mc_adev->consumer_link) {
+		error =3D -EINVAL;
+		goto error;
+	}
+
 	*new_mc_adev =3D mc_adev;
 	return 0;
 error:
@@ -321,6 +329,9 @@ void fsl_mc_object_free(struct fsl_mc_device *mc_adev)
 		return;
=20
 	fsl_mc_resource_free(resource);
+
+	device_link_del(mc_adev->consumer_link);
+	mc_adev->consumer_link =3D NULL;
 }
 EXPORT_SYMBOL_GPL(fsl_mc_object_free);
=20
diff --git a/drivers/bus/fsl-mc/mc-io.c b/drivers/bus/fsl-mc/mc-io.c
index 7226cfc..3ae574a 100644
--- a/drivers/bus/fsl-mc/mc-io.c
+++ b/drivers/bus/fsl-mc/mc-io.c
@@ -209,9 +209,19 @@ int __must_check fsl_mc_portal_allocate(struct fsl_mc_=
device *mc_dev,
 	if (error < 0)
 		goto error_cleanup_resource;
=20
+	dpmcp_dev->consumer_link =3D device_link_add(&mc_dev->dev,
+						   &dpmcp_dev->dev,
+						   DL_FLAG_AUTOREMOVE_CONSUMER);
+	if (!dpmcp_dev->consumer_link) {
+		error =3D -EINVAL;
+		goto error_cleanup_mc_io;
+	}
+
 	*new_mc_io =3D mc_io;
 	return 0;
=20
+error_cleanup_mc_io:
+	fsl_destroy_mc_io(mc_io);
 error_cleanup_resource:
 	fsl_mc_resource_free(resource);
 	return error;
@@ -244,6 +254,9 @@ void fsl_mc_portal_free(struct fsl_mc_io *mc_io)
=20
 	fsl_destroy_mc_io(mc_io);
 	fsl_mc_resource_free(resource);
+
+	device_link_del(dpmcp_dev->consumer_link);
+	dpmcp_dev->consumer_link =3D NULL;
 }
 EXPORT_SYMBOL_GPL(fsl_mc_portal_free);
=20
diff --git a/include/linux/fsl/mc.h b/include/linux/fsl/mc.h
index 9d3f668..0c4f9805 100644
--- a/include/linux/fsl/mc.h
+++ b/include/linux/fsl/mc.h
@@ -193,6 +193,7 @@ struct fsl_mc_device {
 	struct resource *regions;
 	struct fsl_mc_device_irq **irqs;
 	struct fsl_mc_resource *resource;
+	struct device_link *consumer_link;
 };
=20
 #define to_fsl_mc_device(_dev) \
--=20
1.9.1