Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3917372imu; Mon, 10 Dec 2018 09:50:18 -0800 (PST) X-Google-Smtp-Source: AFSGD/UT+7qylHNLItns8DsIksLXrzoQ2xKEnOnupQKwrE6vjUM7q3pqiXP/rJGPEutK4uvQPX0j X-Received: by 2002:a62:1c7:: with SMTP id 190mr13255157pfb.46.1544464218063; Mon, 10 Dec 2018 09:50:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544464218; cv=none; d=google.com; s=arc-20160816; b=o65D8Q7v0JrlYA/rvJrcCaD0RMOzWecKGCBeOm91OFR2Hn/tsdNS/xu/EF5xreNQpK oZQIHTnaVA8j+KjByw9AM5MDhEIy38GYlpvTWjyeKPH5WodaKvyBweGYMA+KRsutDBIP rMx6dk0fRvrDztZ514FIMugAxJH/lLlHtYmjzPf8sOlDF+E1iVJhgtVQrPUAt6gNs3u0 27n0rmMw/pOC74yRwQJsuWXAzMuFBExJHWl2Ev/t13BX47zNd4Mmv+2+rNqHTB+olTA9 4jLFJ+m2qE9XmW4sSDGPkXGMP50Mt2xXCAQLyp6wkHfEF4UC1/9pl1DR5yJBfNZ4Eosf yaFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=oZYstZRjuND+an4Fv/r4kID4KL+cmh1HkO4wzq5AX90=; b=KGRfmsrOW/lAwsThDkGwV/5jy2XA/YEF+sSDnQhAVqq5GMwX1/+0Empy2FS/Mm8I53 NOV5bjFFDis+uTr0lV6cIgSoIi/UkvWC5rE16JttpbRQCPPSwJA+gFtqf1DW8ySNDqia 3QRoYmTCE9IsOhy8P6IkKYaPM7lMd+vXd7gv89/yj7Nh/sQlcVPHMUf6Yq+bTA2sqNhS Nf+rVFpM+BppOveTLCVSrW5puWSaYANeRFc4y+YKuD1hr31aAno1twsWhxMQ4ZPxRbHi 3MnP9zKa/NbPWRx0h/WArwEdQcMASpJ5chClfNPLHaP8zUmFYKY2a913Z7ru2erEtnOu ze4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z128si10100326pgb.372.2018.12.10.09.50.00; Mon, 10 Dec 2018 09:50:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728518AbeLJRNl (ORCPT + 99 others); Mon, 10 Dec 2018 12:13:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47790 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728409AbeLJRNg (ORCPT ); Mon, 10 Dec 2018 12:13:36 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 305C830820D6; Mon, 10 Dec 2018 17:13:36 +0000 (UTC) Received: from horse.redhat.com (unknown [10.18.25.234]) by smtp.corp.redhat.com (Postfix) with ESMTP id D6591600D6; Mon, 10 Dec 2018 17:13:35 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id CBCD122427D; Mon, 10 Dec 2018 12:13:30 -0500 (EST) From: Vivek Goyal To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: vgoyal@redhat.com, miklos@szeredi.hu, stefanha@redhat.com, dgilbert@redhat.com, sweil@redhat.com, swhiteho@redhat.com Subject: [PATCH 49/52] fuse: don't crash if version table is NULL Date: Mon, 10 Dec 2018 12:13:15 -0500 Message-Id: <20181210171318.16998-50-vgoyal@redhat.com> In-Reply-To: <20181210171318.16998-1-vgoyal@redhat.com> References: <20181210171318.16998-1-vgoyal@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Mon, 10 Dec 2018 17:13:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miklos Szeredi Version table can be NULL. Do not crash. Signed-off-by: Miklos Szeredi --- fs/fuse/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c index 1ab4df442390..d44827bbfa3d 100644 --- a/fs/fuse/inode.c +++ b/fs/fuse/inode.c @@ -1219,7 +1219,8 @@ int fuse_fill_super_common(struct super_block *sb, fc->version_table_size = mount_data->vertab_len / sizeof(s64); fc->version_table = mount_data->vertab_kaddr; - if (fc->version_table[0] != VERSION_TABLE_MAGIC) { + if (fc->version_table && fc->version_table_size > 0 && + fc->version_table[0] != VERSION_TABLE_MAGIC) { pr_warn("bad version table magic: 0x%16llx\n", fc->version_table[0]); fc->version_table_size = 0; -- 2.13.6