Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4032320imu; Mon, 10 Dec 2018 11:55:34 -0800 (PST) X-Google-Smtp-Source: AFSGD/VWpN7oTmh9uF1jTfwjXK1gAodXxZqlcZJ+LbNiwjL//su3Dofxf4lRhs3PUP00ucgznU9h X-Received: by 2002:a17:902:5ac7:: with SMTP id g7mr13523709plm.212.1544471734153; Mon, 10 Dec 2018 11:55:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544471734; cv=none; d=google.com; s=arc-20160816; b=T5q776RQGSXh7Q0nYjkoLz9SxQzKsAFWWGETeOiK509jDB7U+suTNtX+nQ51mhZhMK 5rE/QC3yqwqe+bRMtFdfBrK/gBR9fdTd5Py4juZ4VBcmEK7umd6kk3v2gxPFDIr56Rcr szv2CaqsEMWJW9XUFg3fP/8dqSd5JvtOu91yNanlBHR0d8Uk7qUZiI1R3keNFBxMSj6k 6f4n+o/eO542nQ7k3yvFPfea0rPSJrNktIppBXOouuaWYs+baY3KAsk9WUbS+KcYNXlA tkF/3FIL/Mp+d5Mz6uokIFRwvgXOO2Ml6Bsi5yM9pHnPY9UeB8HWi9eioA4CK+9SYRdT Upzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=7sezDPk9Ztvx36ul7Kib9sPcxRKZKKPrBwiTokoipko=; b=khw0LkyPPjRc27n8ZHooVKfVFLliByWfIKoeMyB6xkmiNjesG1kHMyxMjtPptYIEAq R7P9xdNI8ECU/bIaYiJ5eyOmwqk4LLZVqpC1ViaTA4ZdI9cI6WsD/evVfZMPhWAiaPY2 nP24Ko/r89rAjo2frQL89OpUEiMbn+9OTuhrUAhC0FNu1wqLT79R/TWtnz7WHmIXW2ZY RYHAm5lgEG3pNt1Kpixr0zxRFVqNSDOVSrdhP5VGkkaaM2JBpOQJ/cz7SxOCaGBLMYCd /ea18XHamsQ2ayybCOayE6jgGTuUJ0JflFCxNL024H6XXLiLgMF3ZCfImJGajcKPXnNW 3EqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11si10312919plr.341.2018.12.10.11.55.19; Mon, 10 Dec 2018 11:55:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728380AbeLJR7A (ORCPT + 99 others); Mon, 10 Dec 2018 12:59:00 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:41114 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726959AbeLJR7A (ORCPT ); Mon, 10 Dec 2018 12:59:00 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4338014732B37; Mon, 10 Dec 2018 09:58:59 -0800 (PST) Date: Mon, 10 Dec 2018 09:58:56 -0800 (PST) Message-Id: <20181210.095856.580441946779980596.davem@davemloft.net> To: fw@strlen.de Cc: syzbot+592df0494801b6648ec6@syzkaller.appspotmail.com, herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, steffen.klassert@secunet.com, syzkaller-bugs@googlegroups.com Subject: Re: INFO: rcu detected stall in xfrm_hash_rebuild From: David Miller In-Reply-To: <20181210124724.iuver2va3yjdsokf@breakpoint.cc> References: <00000000000075fe86057ca6367e@google.com> <20181210124724.iuver2va3yjdsokf@breakpoint.cc> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 10 Dec 2018 09:58:59 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Westphal Date: Mon, 10 Dec 2018 13:47:24 +0100 > After recent tree conversion, we could probably make the exact policies > part of the 'inexact tree' (which would be renamed to 'policy tree' or > some such). > > Special-casing the exact policies made a lot of sense when we had > a single list for the inexact policies (to keep its length down). > > But now I think we could try to unify all of this and only maintain > the existing tree-based storage. > > Would also remove the need to do lookups in two different > data structures (bydst-hash-then-inexact-tree). > > What do you think? I think this makes a lot of sense.