Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4067219imu; Mon, 10 Dec 2018 12:31:39 -0800 (PST) X-Google-Smtp-Source: AFSGD/Uw5QUPYJzDFkOeLiBsWbpI6g8AV8kq9mZddD1nqhnGgpzKf7hTbhtwigTuofi64qIvqTGI X-Received: by 2002:a17:902:7d90:: with SMTP id a16mr12840026plm.249.1544473899246; Mon, 10 Dec 2018 12:31:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544473899; cv=none; d=google.com; s=arc-20160816; b=S4l+qIEboWolg5AP/91Uro0zbgJQ5e8euY4e/A9VnABXjG/l5gnwLaQ4soW33WT5eE v/E2e40ux5yONN//LKCJw63dAZ31RWY/JGg6vTuzrKIrGjZpE4xRj3bZhASZb7s6ZOnt bMfxJo3kfyOeHPQjEWjahN80iK0GZ8s5Wu5jN47jKjXpTGBD3DMyzyrWTOgTKfvx+RH3 epCzC17nNie3BE2ZPfk2XPCUF8WVeaejDCgG4+FiuFGhYpKUtumdNWN7e/4ykW9X/btN GooW4iLRKuT8CxHgh8Aua4ftmi7M5nRm6PfUxR5K44B2/q6lnOXFVdKWKxN/9K/rczED gk+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:to:from :dkim-signature; bh=seO5pYUVOppQz0bc69tFmfcD8uMCJdgzegwYSbd9RdE=; b=gvi7oUxbyea51tZsDo8mByXwDVxBWjaq9noBK4z/L+7MbcARgEaK1wJOEifmFwW75U JENsoU6Thad0Yjw4vcZOog6OgT1Z91gOErFhZHAi0xWwLVb++Y+XTGK/+8iZtln74gVL 6I6zKvLooBDKC3mHGCdiq4nbXvXxDh+OjBPLCKAVNjYE8MPdVscIyiyZ9lmPNtmG+Udf Kfc7dxqWq4SnuOQBgyUg8g9j9ReAQdOErNOIb43R/Uiz6R7ZzSJhbHNtDRPqyq/5fg9O Tnqum8y+g3sJZtxno1qMV8C+HyXDnzU8JxGiN20dJsJ1uGskF/zoSdBv6lyI9SgFaJSz nofQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pmgSWe97; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v3si10545903pgh.305.2018.12.10.12.31.24; Mon, 10 Dec 2018 12:31:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pmgSWe97; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728599AbeLJTmU (ORCPT + 99 others); Mon, 10 Dec 2018 14:42:20 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:33177 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726693AbeLJTmU (ORCPT ); Mon, 10 Dec 2018 14:42:20 -0500 Received: by mail-wm1-f65.google.com with SMTP id r24so7370798wmh.0 for ; Mon, 10 Dec 2018 11:42:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=seO5pYUVOppQz0bc69tFmfcD8uMCJdgzegwYSbd9RdE=; b=pmgSWe97BeMvEoJAmtVZwmuh7IMYLeZMMwpzZ1sh7ZmpKDHDtkI/B3Fe+nSRLr7MZn TvkRajyvToh6yrAvg9HZMfF/ip/CGmbmYIg37T++h68gYRFqEfDG90BUmOFc68w0GO/S ettKAnFDAZTYWs4QHF65L1q0nybhUF922TdfKp+vsUfLgVudUIwtWzvwjcEUFh+8fNZ7 prBPqDiONIrMJTkeoEdvHGcGfaa0pHwCdCyq8MuTlTm58Qq2X11jBegoVE3a1j5h3ozY A38LZ7cXEzhXQJa2aFZxvYUeiPEJBTh0U5fzeUVEk/cFPRxtLBqLzdDbjpXHGqvTn4TJ nd2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=seO5pYUVOppQz0bc69tFmfcD8uMCJdgzegwYSbd9RdE=; b=mEXDE3r23KjQlpNDPZWJCIuHyEBHRw8EPS0H1s3JKKt634yCXKaYas7+FWuNHzvjn6 CVDZ93vzE2vsA2eefLo0W+w+yJWXFn/zxDSsGnNTh+WWJ5YMvoQJknJmv9KBOb0yMr6q Sl3AmUurG108u+9Gi8G0HACo4UPhMNumjh6BOjT1gpzJzzQSu5hHdVAJnc6z9WsDS7hK hoDS7XgIKMN9s+fjXx0HRX+I/974APk55fGMbE2H4c0ZWjSLonNUVxZZhGNouZvGwfhw KIsX+uFsJdXDDbqPqZ2J8/E01/DQ0ruHczpNc1VMgruJLOrgup/F/aZh6pYMFX2f/tKR d2KQ== X-Gm-Message-State: AA+aEWZp+Sy24ohaYtvHk102SDEgDlt5SE9JnydH4QyCIw9pIRmcEsfd Q1xMSGJsXM0jHbMx7Q9nzzA= X-Received: by 2002:a1c:dd06:: with SMTP id u6mr11343522wmg.81.1544470938525; Mon, 10 Dec 2018 11:42:18 -0800 (PST) Received: from osboxes.localdomain (bzq-109-67-225-236.red.bezeqint.net. [109.67.225.236]) by smtp.googlemail.com with ESMTPSA id t4sm14565082wrm.6.2018.12.10.11.42.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 10 Dec 2018 11:42:17 -0800 (PST) From: Carmeli Tamir To: hirofumi@mail.parknet.co.jp, jthumshirn@suse.de, sergey.senozhatsky@gmail.com, akpm@linux-foundation.org, axboe@kernel.dk, martin.petersen@oracle.com, bvanassche@acm.org, linux-kernel@vger.kernel.org, carmeli.tamir@gmail.com Subject: [PATCH 0/2] fat: Added macros to determine the FAT FS variant (12/16/32bit) Date: Mon, 10 Dec 2018 14:41:55 -0500 Message-Id: <1544470917-6443-1-git-send-email-carmeli.tamir@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Along the FAT FS code, the FAT variant (whether this is FAT12, FAT16 or FAT32) is determined by checking the fat_bits field of struct msdos_sb_info. This is somewhat error prone as it forces the usage of magics (12, 16, 32) multiple times in the code. This series replaces the places in which the variant is checked with three simple macros - IS_FAT12, IS_FAT16 and IS_FAT16. The introduction of these simple macros makes a clearer API for determining the variant, rather than searching the code for some field in a struct, and therefore increases the code's maintainability and readability. Carmeli Tamir (2): fat: Moved macros that won't work without fat.h fat: New macros to determine the FAT variant (32, 16 or 12) fs/fat/cache.c | 2 +- fs/fat/dir.c | 4 ++-- fs/fat/fat.h | 28 ++++++++++++++++++++++------ fs/fat/fatent.c | 17 +++++++---------- fs/fat/inode.c | 12 ++++++------ fs/fat/misc.c | 2 +- include/uapi/linux/msdos_fs.h | 5 ----- 7 files changed, 39 insertions(+), 31 deletions(-) -- 2.7.4