Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4071148imu; Mon, 10 Dec 2018 12:35:52 -0800 (PST) X-Google-Smtp-Source: AFSGD/WMoicLqow2hXgFE/hXreiQ0Z7W8+bcT08fB/Be9N9q5Hax9eB/gJTComq3qCAdgEpdUxtn X-Received: by 2002:a63:9041:: with SMTP id a62mr11844508pge.163.1544474152360; Mon, 10 Dec 2018 12:35:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544474152; cv=none; d=google.com; s=arc-20160816; b=UbqwA5rfaXd+U10TA/9JiLRW6cQNmCSmno1/SzCmDCgEQSCrq2LAN6Ch9yHpDLcrkU bkJkmH/8vp13NsK6f/6hEDsNI6o9dkIMQh/gC/m+lzpJrgtVQQWSz9lqkVkzGmyLk+WK 9k/HKjFPjjyim9XOSfBIigaHg6n/nIUwucGltLi8cFadXKz6FwclRIv1nSrzHX4vKfBw mZMlJWUNnbogDU5xFm2hUHzwZ5FDwuG20XZ1th5839CrBc4OCd3EA/VhhgvkkMZUNN3V lffIe1s4b9DpoaV8Tt75pib7aXEOKqhV1S4LLxGf864d/qgW1m8SxGY8qNJhcaJa2aQW sxMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=nvT4dYGpswboouNMPqkCmn0bm0WAg+IumoqIxMn+3xU=; b=ToxxYGPrtt58Jj7cF9WDGa+m8xbjjclzZuZjG5+GsHB2CexCVI9xHcQ/961LjWAoW6 nl0zAy/NbEc6zyTV4qIuZuNpBLkldRIL3D9cq4jYN6GnXTYDYBFYdPP6iVEYCSSGbCdo cHASMTQm2XZy196eWb12fgen7q2waKwyVH/dBXh6UTAb5xK3f5qSYIzv+ys9fibLlwYp EdWkYp5JC5InUE8gwF/82MRXF+ypGUjKdoIoZAcheTTbmL+rKg5WYHlXcoz7QCyvrumg Q94jtLlc/EC3anHtdSXxzJaQuAKWzoLWQ4Av8vv1SU/KDp03e+TYf3MDLhlen5C/HNiu Sb2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b10si8904850plz.233.2018.12.10.12.35.28; Mon, 10 Dec 2018 12:35:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729595AbeLJTr2 (ORCPT + 99 others); Mon, 10 Dec 2018 14:47:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48136 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727799AbeLJTr2 (ORCPT ); Mon, 10 Dec 2018 14:47:28 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E0AB630024E6; Mon, 10 Dec 2018 19:47:27 +0000 (UTC) Received: from localhost (ovpn-116-63.gru2.redhat.com [10.97.116.63]) by smtp.corp.redhat.com (Postfix) with ESMTP id 44874608E6; Mon, 10 Dec 2018 19:47:27 +0000 (UTC) Date: Mon, 10 Dec 2018 17:47:25 -0200 From: Eduardo Habkost To: Borislav Petkov Cc: Paolo Bonzini , =?iso-8859-1?Q?J=F6rg_R=F6del?= , Andre Przywara , kvm ML , lkml , Tom Lendacky Subject: Re: kvm: RDTSCP on AMD Message-ID: <20181210194725.GM4669@habkost.net> References: <20181210181328.GA762@zn.tnic> <20181210183730.GJ4669@habkost.net> <20181210184153.GB5482@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181210184153.GB5482@zn.tnic> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 10 Dec 2018 19:47:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 10, 2018 at 07:41:53PM +0100, Borislav Petkov wrote: > On Mon, Dec 10, 2018 at 04:37:30PM -0200, Eduardo Habkost wrote: > > It isn't as simply as reverting commit 33b5e8c03ae7, but we can > > surely re-add RDTSCP on pc-*-4.0 and newer. > > Sure. If you could only point me to an example how to add that to > pc-*-4.0 and newer, I'll gladly cook up a patch and test it. Sorry, I forgot to reply to this part. See commit 33b5e8c03ae7 for reference. The differences will be: * Instead of removing RDTSCP from builtin_x86_defs, you'll be adding it. * Instead of adding rdtscp=on entries to PC_COMPAT_2_4, you'll be adding rdtscp=off entries to PC_COMPAT_3_1. PC_COMPAT_3_1 is added by the patch that creates the 4.0 machine-types. You can find it on my machine-next branch at: http://github.com/ehabkost/qemu -- Eduardo