Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Paul Burton <paul.burton@mips.com>
To:     Firoz Khan <firoz.khan@linaro.org>
CC:     "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
        Ralf Baechle <ralf@linux-mips.org>,
        James Hogan <jhogan@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        "y2038@lists.linaro.org" <y2038@lists.linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "deepa.kernel@gmail.com" <deepa.kernel@gmail.com>,
        "marcin.juszkiewicz@linaro.org" <marcin.juszkiewicz@linaro.org>
Subject: Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'
Thread-Topic: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'
Thread-Index: AQHUjSNJ15+cZub/wUiwPpyZjNjVYqV4aUcA
Date:   Mon, 10 Dec 2018 19:51:46 +0000
Message-ID: <20181210195144.dvprpyxyddusyb5c@pburton-laptop>
References: <1544073508-13720-1-git-send-email-firoz.khan@linaro.org>
 <1544073508-13720-4-git-send-email-firoz.khan@linaro.org>
In-Reply-To: <1544073508-13720-4-git-send-email-firoz.khan@linaro.org>
Accept-Language: en-US
Content-Language: en-US
user-agent: NeoMutt/20180716
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [4.16.204.77]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;MWHPR2201MB1536;6:6ydv6eEKXiQ3ZuUhBHh1BOSTehEFwOPmw0SNb2RkcNjaVDDD1a6y4rSFX1aOzcDhawV+TzYY2Xq0RTPEhtiNWPGc4gFWZyy9Oexmsa08PFYFpwWZ81SZ07rzWD8pdCSmjZ59i9mmVT2vgfk27WwRCQDuBa1TyHWPly6HnIzCsIpOCUEIPaKPmrmiXLCT6BA/M5jOVTfHDBIarn0ipPXPkEemyMSBkkIOUH6DUDywwT+s1dozkKXsgFjrXT6yMOGlCJYMUyX8WuKZ22FSsjri/5guVGATYDpkxuw9dabRuz84LA6H8Lqpe3IMN2krDEq0g3Vz/hsVpmMDepQw3aouxTrHFW2l7YGRASYvcheHyFbb5TObkIkjzLmRFc5PqtAxjhx+rGT+sdkRyZjV0WBWV7An45KZvgCrWQjO7IHJi7hxiQkaAFrG+SDwbBDEb2mjVb6GyiGZnJaWa/iUP6bSqA==;5:HR+ff1X/W2QKLxeiwfOQ7CJlIh7qzYXbilZb3KD3eKaDWHPTaR3tkn/m4auVwviJUzs81gmdIfVt5m6LO7S/+/VzUFElqPgEnHvkLoPyUVmuhfiqzofpsm30SBEIaxkVnirciZl5DoHSc26ROWMCOzowxuxEs3r6fTJ9sAWDs7I=;7:v2sSWo3L4G4D0By7MgBmzZnOnbTPrrOs2e/xhOZVO+Hw8mVDwPPUqUYraCdDlECUFczxqSkKfiaWKRWANIGAhu/JU4z3xV9amR24M+cPdt6WTGBbRlU9HinWH1udndosDVIZGaWw5Tl9YRBfr5btfQ==
x-ms-office365-filtering-correlation-id: 11778c9f-9dad-4e2d-34e7-08d65ed8ea9a
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390098)(7020095)(4652040)(7021145)(8989299)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(5600074)(711020)(2017052603328)(7153060)(7193020);SRVR:MWHPR2201MB1536;
x-ms-traffictypediagnostic: MWHPR2201MB1536:
x-microsoft-antispam-prvs: <MWHPR2201MB1536870E8590FDC6ED0EB9F5C1A50@MWHPR2201MB1536.namprd22.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(3230017)(999002)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(3231472)(944501520)(52105112)(3002001)(148016)(149066)(150057)(6041310)(2016111802025)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(6043046)(201708071742011)(7699051)(76991095);SRVR:MWHPR2201MB1536;BCL:0;PCL:0;RULEID:;SRVR:MWHPR2201MB1536;
x-forefront-prvs: 08828D20BC
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(366004)(396003)(346002)(136003)(39840400004)(376002)(199004)(189003)(53936002)(6916009)(256004)(42882007)(97736004)(14454004)(4326008)(6506007)(508600001)(33896004)(54906003)(81166006)(446003)(8936002)(106356001)(102836004)(44832011)(8676002)(81156014)(476003)(386003)(486006)(99286004)(7416002)(11346002)(2906002)(58126008)(6512007)(229853002)(6246003)(105586002)(66066001)(52116002)(316002)(7736002)(9686003)(3846002)(71200400001)(6486002)(25786009)(6436002)(5660300001)(305945005)(33716001)(76176011)(39060400002)(6116002)(26005)(71190400001)(1076002)(68736007)(186003);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR2201MB1536;H:MWHPR2201MB1277.namprd22.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: wavecomp.com does not designate
 permitted sender hosts)
x-microsoft-antispam-message-info: YrQZo2A75EKMHvb4tzyu02izKP/4u9KIhXRfiGz/nSLSwRn/wetOPC3pbDDe2LIl2MV6RHJ3pAoZyPu6fm0PTjCsrvDULdSZk/ITwpbnq47U5U+itFWgjcRZP8f9CF8odYNR5Kge3hZqdF9s5IDxDThkiQptiIfWUw5VorgRFqJfeRJGxZQz3E/R9uPWxotr2/IDB/z4vDUMR/EbPErnh7WbezqqFzOY/OVoa5ic4Gzr8eLJsnM+40ZHVDrMC12FrcP0KKtxcp3p9R8orxllhyWIyvSMXnfCp+G79RxIYgB7ZiIJcJz+zLvO+Omj+zsPItw1PVoIGNRdty4NI1ArM9hSzUn7ZtWGd4YJmCfFqHE=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6994742102DF064DB805071693ED2AB2@namprd22.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: mips.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11778c9f-9dad-4e2d-34e7-08d65ed8ea9a
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2018 19:51:46.4938
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 463607d3-1db3-40a0-8a29-970c56230104
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR2201MB1536
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Firoz,

On Thu, Dec 06, 2018 at 10:48:24AM +0530, Firoz Khan wrote:
> diff --git a/arch/mips/include/uapi/asm/sgidefs.h b/arch/mips/include/uap=
i/asm/sgidefs.h
> index 26143e3..0364eec 100644
> --- a/arch/mips/include/uapi/asm/sgidefs.h
> +++ b/arch/mips/include/uapi/asm/sgidefs.h
> @@ -40,6 +40,6 @@
>   */
>  #define _MIPS_SIM_ABI32		1
>  #define _MIPS_SIM_NABI32	2
> -#define _MIPS_SIM_ABI64		3
> +#define _MIPS_SIM_ABIN64	3

Whilst I agree with changing our own definitions & filenames to use n64,
this macro actually reflects naming used by the toolchain. ie:

    $ mips-linux-gcc -mips64 -mabi=3D64 -dM -E - </dev/null | grep ABI64
    #define _ABI64 3
    #define _MIPS_SIM _ABI64

Our macro here is used to compare against _MIPS_SIM provided by the
toolchain, so for consistency I think we should keep the same name for
the macro that the toolchain uses.

And I realise that undoing that but keeping n64 in our own filenames &
macros is another type of inconsistency, but something imperfect is
unavoidable at this point given that the engineers way back when decided
to use "ABI64" for n64.

Thanks,
    Paul