Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 11 Dec 2018 10:33:01 +1100
From:   Sam Bobroff <sbobroff@linux.ibm.com>
To:     Oliver <oohall@gmail.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, Russell Currey <ruscur@russell.cc>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>, aik@ozlabs.ru,
        linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc: eeh_event: convert semaphore to completion
References: <20181210215203.1936171-1-arnd@arndb.de>
 <CAOSf1CHqxaGdz_F0EifqHmD+0ZgKVno7aRZEXUG1880C5YvHGQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="Dxnq1zWXvFF0Q93v"
Content-Disposition: inline
In-Reply-To: <CAOSf1CHqxaGdz_F0EifqHmD+0ZgKVno7aRZEXUG1880C5YvHGQ@mail.gmail.com>
User-Agent: Mutt/1.9.3 (2018-01-21)
Message-Id: <20181210233300.GA14707@tungsten.ozlabs.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--Dxnq1zWXvFF0Q93v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 11, 2018 at 10:18:31AM +1100, Oliver wrote:
> On Tue, Dec 11, 2018 at 8:52 AM Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > For this use case, completions and semaphores are equivalent,
> > but semaphores are an awkward interface that should generally
> > be avoided, so use the completion instead.
>=20
> IIRC Sam has been reworking the locking used inside of EEH so this is
> probably going to clash with his changes. Converting to a completion
> is probably a good idea, but we might want to do it as a part of his
> series since it's going to collide with this anyway.
>=20
> Sam, what do you think?

It's such a small change, I don't think it will cause any problems for
the rework. Anyway it seems like a good change, so I'd prefer to see it
go in :-)

Cheers,
Sam.

> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  arch/powerpc/kernel/eeh_event.c | 9 +++------
> >  1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/powerpc/kernel/eeh_event.c b/arch/powerpc/kernel/eeh_=
event.c
> > index 61c9356bf9c9..227e57f980df 100644
> > --- a/arch/powerpc/kernel/eeh_event.c
> > +++ b/arch/powerpc/kernel/eeh_event.c
> > @@ -35,7 +35,7 @@
> >   */
> >
> >  static DEFINE_SPINLOCK(eeh_eventlist_lock);
> > -static struct semaphore eeh_eventlist_sem;
> > +static DECLARE_COMPLETION(eeh_eventlist_event);
> >  static LIST_HEAD(eeh_eventlist);
> >
> >  /**
> > @@ -55,7 +55,7 @@ static int eeh_event_handler(void * dummy)
> >         struct eeh_pe *pe;
> >
> >         while (!kthread_should_stop()) {
> > -               if (down_interruptible(&eeh_eventlist_sem))
> > +               if (wait_for_completion_interruptible(&eeh_eventlist_ev=
ent))
> >                         break;
> >
> >                 /* Fetch EEH event from the queue */
> > @@ -102,9 +102,6 @@ int eeh_event_init(void)
> >         struct task_struct *t;
> >         int ret =3D 0;
> >
> > -       /* Initialize semaphore */
> > -       sema_init(&eeh_eventlist_sem, 0);
> > -
> >         t =3D kthread_run(eeh_event_handler, NULL, "eehd");
> >         if (IS_ERR(t)) {
> >                 ret =3D PTR_ERR(t);
> > @@ -142,7 +139,7 @@ int eeh_send_failure_event(struct eeh_pe *pe)
> >         spin_unlock_irqrestore(&eeh_eventlist_lock, flags);
> >
> >         /* For EEH deamon to knick in */
> > -       up(&eeh_eventlist_sem);
> > +       complete(&eeh_eventlist_event);
> >
> >         return 0;
> >  }
> > --
> > 2.20.0
> >
>=20

--Dxnq1zWXvFF0Q93v
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEELWWF8pdtWK5YQRohMX8w6AQl/iIFAlwO96YACgkQMX8w6AQl
/iKCvwf/QsZpJRkrj9J6Kg5f36kvI3ntwmLJbWMt6w/GtQzVcwIizQLRH84mAjNv
vQBON2d0gPM8QO1sdaA/Ilu0/LQIFG90NIAZWowX/8Leq0gmwAI9gO1zn15wWOjl
NoRboPfBuhi7SzM9XJDf/YXuj7sLCBbKU9Tbj7BDn9cgF+RWxxVsQSHYO2O7LjrW
HlPTJBotLzCE+ucI3yc6O0dimjZ4K6uLrNuzPTBSSg9OxY6GqTLF2NR51M+lLdSA
YpEBhWLFFiXfr6uGeE+RyIqD50QER4HNW7PPF5pG0RyVRGx4zYvHcRXKV/V5Rx/f
xYoJX1OL7THp/VdRBX99OdpcjK9E5Q==
=4vZx
-----END PGP SIGNATURE-----

--Dxnq1zWXvFF0Q93v--