Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To:     Anthony Yznaga <anthony.yznaga@oracle.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "chansen3@cisco.com" <chansen3@cisco.com>,
        "vbabka@suse.cz" <vbabka@suse.cz>,
        "willy@infradead.org" <willy@infradead.org>,
        "rientjes@google.com" <rientjes@google.com>
Subject: Re: [PATCH] tools/vm/page-types.c: fix "kpagecount returned fewer
 pages than expected" failures
Thread-Topic: [PATCH] tools/vm/page-types.c: fix "kpagecount returned fewer
 pages than expected" failures
Thread-Index: AQHUjB+8Q0loeO8VgkakJeKYQ9HUO6V4GgaA
Date:   Tue, 11 Dec 2018 00:00:49 +0000
Message-ID: <20181211000049.GA19806@hori1.linux.bs1.fc.nec.co.jp>
References: <1543962269-26116-1-git-send-email-anthony.yznaga@oracle.com>
In-Reply-To: <1543962269-26116-1-git-send-email-anthony.yznaga@oracle.com>
Accept-Language: en-US, ja-JP
Content-Language: ja-JP
Content-Type: text/plain; charset="iso-2022-jp"
Content-ID: <E8B28FAEE810064EA748D114065562DB@gisp.nec.co.jp>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Dec 04, 2018 at 02:24:29PM -0800, Anthony Yznaga wrote:
> Because kpagecount_read() fakes success if map counts are not being
> collected, clamp the page count passed to it by walk_pfn() to the pages
> value returned by the preceding call to kpageflags_read().
> 
> Fixes: 7f1d23e60718 ("tools/vm/page-types.c: include shared map counts")
> Signed-off-by: Anthony Yznaga <anthony.yznaga@oracle.com>

Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

> ---
>  tools/vm/page-types.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/vm/page-types.c b/tools/vm/page-types.c
> index 37908a83ddc2..1ff3a6c0367b 100644
> --- a/tools/vm/page-types.c
> +++ b/tools/vm/page-types.c
> @@ -701,7 +701,7 @@ static void walk_pfn(unsigned long voffset,
>  		if (kpagecgroup_read(cgi, index, pages) != pages)
>  			fatal("kpagecgroup returned fewer pages than expected");
>  
> -		if (kpagecount_read(cnt, index, batch) != pages)
> +		if (kpagecount_read(cnt, index, pages) != pages)
>  			fatal("kpagecount returned fewer pages than expected");
>  
>  		for (i = 0; i < pages; i++)
> -- 
> 1.8.3.1
> 
>