Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp247533imu; Mon, 10 Dec 2018 20:52:33 -0800 (PST) X-Google-Smtp-Source: AFSGD/VPGDjFwyjzl0v+ZIRNuRnxyYuRuJvIO1+2EMWUOS5eWXsq7R52SXBJiG6IqsInDDBhV5u0 X-Received: by 2002:a17:902:1101:: with SMTP id d1mr14525254pla.136.1544503953785; Mon, 10 Dec 2018 20:52:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544503953; cv=none; d=google.com; s=arc-20160816; b=Dx8I437dpPvTUpz3UZlXUC/gyM1uHQShymwaYyXwr6vBPOn29s3MiPnQpBGB8PK71q vsYeTWuXgd4SGWnFojiHmyzgiKAfw9ZF6Eu89+qyyNwYVYnjNh3AXS6AGPF4EkQ+bLNI hvuReIO4fLCPV6ZBsqKGQGXbYXTh5edtRIcU7G1Mq0YVLOS5aO8jQ3wsZZhCQXb4u+5h CdEOdhAOCfpJZmJAbV6eBuVfK2rHYRvotdBIrPmxIkTRXJVYwS5paF4BVqV4m1Dlr7Nr TfspTVyPTpfS1P3iKxdcjtCwMevEieBftIyWae9RZw4/8MMOe6hgr9cE0fGDt2Kbu9yt FDRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=KDzxnoo9efXOS8nQfeIjn0Aj3VAJZ5uy8uUal97/syU=; b=jbF9zk1dkqtPFHMfpCBdsw6hrfrEOUDQxBRPkcn5SIwBnzhCtZeTqI93I2PglMHmZf ZW7RzEqnyGu9Xva1+8NtGqpAfPLuvcjUQceA2V9amo5L8aR1AAgPiofH0/N/4ml07OSC Spzx6qpQWpqG67uTtyUscmaEHtRBYY6J5iGMdQsblpbcgm0eZo20Ti8cGDWVB8My6jTH PM16wwpVv+5elFmBs0kw4u0v4QYkTO+8VyGW9oG0zDtrR//FXepekHu7ncOT694y412X ZFYnKxT++HVu8rIJBhEmJ4Nkv+tlFfkrJx/SOPutTc/bWsp9RIpEIFyTqiNbDMpGpd9c EKYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=YHw6aMRC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i35si11705007plg.396.2018.12.10.20.52.18; Mon, 10 Dec 2018 20:52:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=YHw6aMRC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727885AbeLKBP6 (ORCPT + 99 others); Mon, 10 Dec 2018 20:15:58 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:50560 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726585AbeLKBP4 (ORCPT ); Mon, 10 Dec 2018 20:15:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=KDzxnoo9efXOS8nQfeIjn0Aj3VAJZ5uy8uUal97/syU=; b=YHw6aMRC7roN Xg8v6L4+wzytAxxvM7Wy11Kb5xsP/Q3SJgyXD/7rMVFC9D8qRNF6aII+YEDCT2t8oju88ojteWTHy s5vitxiY3hhuBpvAKYqed7UJBvEhC6/gvfjNs9PYncMvodmwEo85n1yfIKBpDlTNV0g8nRkcSkZUl 97e9I=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1gWWeI-0000KQ-3p; Tue, 11 Dec 2018 01:15:46 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id C4DD111254C7; Tue, 11 Dec 2018 01:15:45 +0000 (GMT) From: Mark Brown To: Arnd Bergmann Cc: Kuninori Morimoto , Mark Brown , Mark Brown , alsa-devel@alsa-project.org, Kuninori Morimoto , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Katsuhiro Suzuki , alsa-devel@alsa-project.org Subject: Applied "ASoC: simple-card-utils: fix build warning without CONFIG_OF" to the asoc tree In-Reply-To: <20181210204640.2407929-1-arnd@arndb.de> X-Patchwork-Hint: ignore Message-Id: <20181211011545.C4DD111254C7@debutante.sirena.org.uk> Date: Tue, 11 Dec 2018 01:15:45 +0000 (GMT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: simple-card-utils: fix build warning without CONFIG_OF has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 2b320e046495e6cf02d1f0b1abf07042ac5635ea Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Mon, 10 Dec 2018 21:46:10 +0100 Subject: [PATCH] ASoC: simple-card-utils: fix build warning without CONFIG_OF When CONFIG_OF is disabled, of_graph_parse_endpoint() does not initialize 'info', and gcc can see that: sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_card_parse_graph_dai': sound/soc/generic/simple-card-utils.c:284:13: error: 'info.port' may be used uninitialized in this function [-Werror=maybe-uninitialized] It's probably best to check the return code anyway, and that also takes care of the warning. Fixes: b6f3fc005a2c ("ASoC: simple-card-utils: fixup asoc_simple_card_get_dai_id() counting") Signed-off-by: Arnd Bergmann Acked-by: Kuninori Morimoto Signed-off-by: Mark Brown --- sound/soc/generic/simple-card-utils.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c index 6a31d07976b9..17d8aee43835 100644 --- a/sound/soc/generic/simple-card-utils.c +++ b/sound/soc/generic/simple-card-utils.c @@ -280,7 +280,10 @@ static int asoc_simple_card_get_dai_id(struct device_node *ep) * Non HDMI sound case, counting port/endpoint on its DT * is enough. Let's count it. */ - of_graph_parse_endpoint(ep, &info); + ret = of_graph_parse_endpoint(ep, &info); + if (ret) + return -ENXIO; + return info.port; } -- 2.19.0.rc2