Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp371753imu; Tue, 11 Dec 2018 00:01:01 -0800 (PST) X-Google-Smtp-Source: AFSGD/U0KsJP9iD53509qrBuml7vfWT0YY9+AGY8RLGhRZ9qHbin3lplhMRpeKVuaai3+gNT1//F X-Received: by 2002:a62:69c4:: with SMTP id e187mr15567579pfc.50.1544515261062; Tue, 11 Dec 2018 00:01:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544515261; cv=none; d=google.com; s=arc-20160816; b=XlegMweaJFG0rX1HE4STg8Xe0eLQt72gry1y6zIBlzKKEDuT+WrzsJGwf3vlfR8PVr SW6/fyCahtDStn71JxTsfWzNLydBpE986DYIazHMbqLkVvETANU2NC2gnFGPzB3El8yg ksV0UJ3KZlP0FKgTvFxLqkRvc2rC9Hu2gCe0HNyANyoUlCkOpDnMY0yxaPmAf8lASHxP DS9kl0DkjQTZ9iDYIVH26GbhK+UNaoMQvdgpB6kTPV15l0sxd1ea/ddAIPnVcQyhKDJ3 RSpT25wy0Omx4Ck8uPaV6ddXl1KIkYjT88Z5QestC+d47BSofpN71nKrzPDiuuH5kud2 a3bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=/bBJFsSTCQ1uS2ww8N6B/IUA8ytg8fgmrgXqiIto7Jk=; b=V46EUjQ14oKy3LA+vjig/7Rj56vWcQPU4EZGHZRlefp4tb62WTK9zYb5+fwAMlFltV 8h47VDOzo1i0I9Y/N2M5DBRayeuWTCCLdoZN8cuqVSdB4PE8MJ/r1/QcPEzEyHCNbWjn AgdLx98jTt3ragP8AyKtZDzFUPEesfaNsR83ua4QEkXvx8sBMgJJ5mTVHeAG62biBVmx bYBvDBVk51BGttR7P2fYNnO/uy3guKUUZrP4LF85CjqFNu3vsgQZ7e2eB8imMepCkK+g UtuoErDCnSGM8P84e0QKfzHRk8e+frvQ0kHAGi9GNAHHjcv+pCdMzKfuk9tHZBh2/1Um 4KKQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k22si11819565pll.276.2018.12.11.00.00.43; Tue, 11 Dec 2018 00:01:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726214AbeLKH7v (ORCPT + 99 others); Tue, 11 Dec 2018 02:59:51 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:59760 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726036AbeLKH7u (ORCPT ); Tue, 11 Dec 2018 02:59:50 -0500 Received: from 61-220-137-37.hinet-ip.hinet.net ([61.220.137.37] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1gWcxG-0004Br-9E; Tue, 11 Dec 2018 07:59:46 +0000 From: Kai-Heng Feng To: jeffrey.t.kirsher@intel.com Cc: davem@davemloft.net, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kai-Heng Feng Subject: [PATCH 2/2] igb: Exclude device from suspend direct complete optimization Date: Tue, 11 Dec 2018 15:59:38 +0800 Message-Id: <20181211075938.32026-2-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181211075938.32026-1-kai.heng.feng@canonical.com> References: <20181211075938.32026-1-kai.heng.feng@canonical.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org igb sets different WoL settings in system suspend callback and runtime suspend callback. The suspend direct complete optimization leaves igb in runtime suspneded state with wrong WoL setting during system suspend. To fix this, we need to disable suspend direct complete optimization to let igb always use suspend callback to set correct WoL during system suspend. Signed-off-by: Kai-Heng Feng --- drivers/net/ethernet/intel/igb/igb_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 2ce3f2cb156d..e0e8f7a708e9 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -3467,6 +3467,9 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent) break; } } + + dev_pm_set_driver_flags(&pdev->dev, DPM_FLAG_NEVER_SKIP); + pm_runtime_put_noidle(&pdev->dev); return 0; -- 2.17.1