Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp371752imu; Tue, 11 Dec 2018 00:01:01 -0800 (PST) X-Google-Smtp-Source: AFSGD/VXnZlYYYnz67UVx0g7VghKZshS8LQyu3en+1lASiqczvryerVkN9XTt1OX6GffEPANPFzm X-Received: by 2002:a63:1258:: with SMTP id 24mr1731917pgs.114.1544515261058; Tue, 11 Dec 2018 00:01:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544515261; cv=none; d=google.com; s=arc-20160816; b=guyT2ijNywSqpVNoGKzjChXwHTQIUZAHy5J3aWDHh5lV6nfugfXohzOl0k5uW/8zfi 1ym4TV1zApSQU9N9VIJ6U5kyrfNCyiSR1suuztAjl4OALHbrkVvhqQva0kPyRnKwb9e9 2cZglX7YXk4d55eY2qodBYtqewu+qEfB6ei9N/DZ/c2gQ2rPylWQcPAp7fuBOdl31PNn hFIPsWeW2Q3vKiM5FfqVYovA8oAhjmpV9r7aiA+2yMv/CD8erty4jFzAP/fhKBTJagYN vUQX0YjUc5qPshK9FCj6xFB8M9jim8FMFeK9wW7rZ7hoqTywGxPZvyWXEwtrGCVic4jB IMKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=SD/pV5e2vjsKiwYnmZrHzeAtE2ZaX7HbSZvLxHIDTDU=; b=biW5PQf2Jbs3LcM50SXqX3BKaRVc8FdxMcSdeEG/GaqEMGw2YN+Cb4VcDYrMFFwrjw 6UdIKFY7hWSF5iJ/mtNLF/Kc4UKRl8MXVFduEG7YtIe8Hf8ijjc3tVYbU+E7NnqIfmZ/ xsWfP2PM1UnYaxx4qeqWDxOQzDjj4IT8tfEuBNZKnScUlo131lC4tbs+fiCcUZOO/kGr ZxgUlM/t09Cn+Qj/0lKVxcV/mqfYrHH0iC5Nfa/MsSqMYM3aY6U1VKXUV+TC9MW08Np1 ltwu55fqOuDarl1cV6fkE4zGCj34y8g8Tu9gEtz3JBO+JB6JNV1xNViMxJrrPLt5jccd WYDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c3si10693249pgw.425.2018.12.11.00.00.43; Tue, 11 Dec 2018 00:01:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726135AbeLKH7r (ORCPT + 99 others); Tue, 11 Dec 2018 02:59:47 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:59755 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726036AbeLKH7r (ORCPT ); Tue, 11 Dec 2018 02:59:47 -0500 Received: from 61-220-137-37.hinet-ip.hinet.net ([61.220.137.37] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1gWcxC-0004B1-BX; Tue, 11 Dec 2018 07:59:42 +0000 From: Kai-Heng Feng To: jeffrey.t.kirsher@intel.com Cc: davem@davemloft.net, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kai-Heng Feng Subject: [PATCH 1/2] e1000e: Exclude device from suspend direct complete optimization Date: Tue, 11 Dec 2018 15:59:37 +0800 Message-Id: <20181211075938.32026-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org e1000e sets different WoL settings in system suspend callback and runtime suspend callback. The suspend direct complete optimization leaves e1000e in runtime suspneded state with wrong WoL setting during system suspend. To fix this, we need to disable suspend direct complete optimization to let e1000e always use suspend callback to set correct WoL during system suspend. Signed-off-by: Kai-Heng Feng --- drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index e434a6a64966..4a22390f9f49 100644 --- a/drivers/net/ethernet/intel/e1000e/netdev.c +++ b/drivers/net/ethernet/intel/e1000e/netdev.c @@ -7351,6 +7351,8 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent) e1000_print_device_info(adapter); + dev_pm_set_driver_flags(&pdev->dev, DPM_FLAG_NEVER_SKIP); + if (pci_dev_run_wake(pdev)) pm_runtime_put_noidle(&pdev->dev); -- 2.17.1