Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 11 Dec 2018 18:43:00 +0900
From:   Masami Hiramatsu <mhiramat@kernel.org>
To:     Andrea Righi <righi.andrea@gmail.com>
Cc:     Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kprobes/x86/xen: blacklist non-attachable xen interrupt
 functions
Message-Id: <20181211184300.810577f6087339bb0781068c@kernel.org>
In-Reply-To: <20181210151256.GA1977@Dell>
References: <20181210151256.GA1977@Dell>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 10 Dec 2018 16:12:57 +0100
Andrea Righi <righi.andrea@gmail.com> wrote:

> Blacklist symbols in Xen probe-prohibited areas, so that user can see
> these prohibited symbols in debugfs.
> 
> See also: a50480cb6d61.

Looks good to me, thanks!

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

> 
> Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
> ---
>  arch/x86/xen/xen-asm_64.S | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/x86/xen/xen-asm_64.S b/arch/x86/xen/xen-asm_64.S
> index bb1c2da0381d..1e9ef0ba30a5 100644
> --- a/arch/x86/xen/xen-asm_64.S
> +++ b/arch/x86/xen/xen-asm_64.S
> @@ -12,6 +12,7 @@
>  #include <asm/segment.h>
>  #include <asm/asm-offsets.h>
>  #include <asm/thread_info.h>
> +#include <asm/asm.h>
>  
>  #include <xen/interface/xen.h>
>  
> @@ -24,6 +25,7 @@ ENTRY(xen_\name)
>  	pop %r11
>  	jmp  \name
>  END(xen_\name)
> +_ASM_NOKPROBE(xen_\name)
>  .endm
>  
>  xen_pv_trap divide_error
> -- 
> 2.17.1
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>