Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp462803imu; Tue, 11 Dec 2018 02:03:32 -0800 (PST) X-Google-Smtp-Source: AFSGD/W9loSeh7Vs3fBHOfO3JRf/LgyQqjyjKPZkQpTkZL0w5Vwf1IeQB+m6gBdZNLKa0WCH1z85 X-Received: by 2002:a17:902:4681:: with SMTP id p1mr15881551pld.184.1544522612767; Tue, 11 Dec 2018 02:03:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544522612; cv=none; d=google.com; s=arc-20160816; b=LvpR3RSfKEdeQgs1C0YXRU4aA3GeEhF4GOLBntt7tR5fxF5ztSXnMgmHOZimN/bXA1 NbkX/ci3sAQBKrTjA3S9WyWpkHjV6X40LuIVGtbetYsRjDJm3K1H9LyX5IEUdgK36EC4 +bK66GZCauONLTFhhIa8J86aGUaFuZOeNo+O6f2l1TPebvCyAuFTpyt8DLE5VGBMqCAg x8tYmVoXx+pqyyjSjZH8S2lSST8SMo6CBF0nY/S0VI6mGCfvcIaODhTGZycI1MSBb99Z /ewAh4I6BO6z4Kcr3RVvGNADw2gP/i3Jqwk8vbtyYdL4aTxQ1W/w4EW7EEz1W8hk/Nfg o/vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=8qytEbwR9z/2FtyKCA1az1o0fNdd6U04w2kDLfvikSM=; b=kPCCeti+LEGnxft6w5U+eAz+mc2oHqKAoVRl7lX9HMiEdAhKEBsX8Tv1M7a07HOruW ws+1EUyK8KsgujnRrPqRIYeKyxdrWigqZHdmw+5AlL/q2ftAxBJFHILoFB+L5h1qSEg2 OG04pA5wRPL7JauJ5zQME3e93htiNf1qswnSk4/YwcgByegmx56s/YmZh7wSLxnBEXHd 8VgJBJfBIpnyocP79QpyNCh3oZ95PGWDZu4eePjIx5xfERtpFccpFzcKUB1X72Sumaes helvHDh5pE+k1+hhkhwIBSX9uRbPX1Jn/c0MeG0Iw5JYxI7trtTnEj7y6Z6+j34z4O6y csnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e6si11859543pgl.471.2018.12.11.02.03.17; Tue, 11 Dec 2018 02:03:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726275AbeLKKCP (ORCPT + 99 others); Tue, 11 Dec 2018 05:02:15 -0500 Received: from www262.sakura.ne.jp ([202.181.97.72]:27925 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726136AbeLKKCO (ORCPT ); Tue, 11 Dec 2018 05:02:14 -0500 Received: from fsav107.sakura.ne.jp (fsav107.sakura.ne.jp [27.133.134.234]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id wBBA2Dcp045957; Tue, 11 Dec 2018 19:02:13 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav107.sakura.ne.jp (F-Secure/fsigk_smtp/530/fsav107.sakura.ne.jp); Tue, 11 Dec 2018 19:02:13 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/530/fsav107.sakura.ne.jp) Received: from [192.168.1.8] (softbank126126163036.bbtec.net [126.126.163.36]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id wBBA28bj045924 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NO); Tue, 11 Dec 2018 19:02:13 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Subject: Re: [PATCH] kernel/hung_task.c: force ignore_loglevel before panic To: "Liu, Chuansheng" , Sergey Senozhatsky Cc: "akpm@linux-foundation.org" , "pmladek@suse.com" , "sergey.senozhatsky@gmail.com" , "rostedt@goodmis.org" , "dvyukov@google.com" , "linux-kernel@vger.kernel.org" References: <27240C0AC20F114CBF8149A2696CBE4A6015A889@SHSMSX101.ccr.corp.intel.com> <20181210054622.GA6291@jagdpanzerIV> <27240C0AC20F114CBF8149A2696CBE4A6015A8D9@SHSMSX101.ccr.corp.intel.com> <20181210061151.GA28533@jagdpanzerIV> <27240C0AC20F114CBF8149A2696CBE4A6015ABB6@SHSMSX101.ccr.corp.intel.com> From: Tetsuo Handa Message-ID: <77864d48-ce55-a699-ee6e-60d9ec36e305@i-love.sakura.ne.jp> Date: Tue, 11 Dec 2018 19:02:07 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <27240C0AC20F114CBF8149A2696CBE4A6015ABB6@SHSMSX101.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/12/11 10:16, Liu, Chuansheng wrote: > We may enhance it by: > - if (sysctl_hung_task_warnings) { > + if (sysctl_hung_task_panic || sysctl_hung_task_warnings) { > if (sysctl_hung_task_warnings > 0) > sysctl_hung_task_warnings--; Why ignore sysctl_hung_task_warnings? The administrator can already configure as sysctl_hung_task_warnings == -1 && sysctl_hung_task_panic == 1 if he/she does not want to suppress neither sched_show_task() nor debug_show_all_locks()/trigger_all_cpu_backtrace(). Someone might want that sysctl_hung_task_warnings == 0 (which is a request to suppress only sched_show_task()) should not be ignored by sysctl_hung_task_panic == 1 (which is a request to trigger panic).