Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp667210imu; Tue, 11 Dec 2018 05:46:19 -0800 (PST) X-Google-Smtp-Source: AFSGD/XWZ1byXNpmGQDFHbr4edDRPwSZmDNNVSKdCt4tp/rbuv3LasxNXZa0xMfR/fhN5TMGihI1 X-Received: by 2002:a62:2a4b:: with SMTP id q72mr16145639pfq.61.1544535979459; Tue, 11 Dec 2018 05:46:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544535979; cv=none; d=google.com; s=arc-20160816; b=NcIyRS8zQR+xUfagYSNQjQGpfmS5BFKo4AdOjcbb+giCg7I/I+6gz2aZyKpgZlYW8x cQVuEA9GMEEezL9p6nLxu+/ULJUAx35A+VMcwO73R+vqD1vfWXULT9vKofEVyYU9UTdG YoPeNw9XvYB2rkk41fYbX/BG5qqBCHtiDo/BxwtCE0zjCfU6LRY6t2KzYVJ7la/0ZfY+ Gp5rihKMyNlMek8UuLL8XRE+QUzf0XkcK1Lb2GnK3cdxwBzyEdXEqBfq8IBA+LgCQfsF 9LjOdJS7X8RKarMao1DKUuyhIBvopdwVZ1/6R4WDHB9lMdK0O8L+J/peGRImswy9H0jZ bKAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Z9sQkAAtn2j+B/eG6nV+WxPFHWxvsOW4cNfp2WIK/CQ=; b=sSB0M/ETClVQ6BtADdhWcPOk85CTYAehV6wMn9utqp9HEeQCK38on2EoJz0Pru6NPC vo/K+f7zQuKL6lgyOuJndn/qE0aRkdaI7JQYiAn45uDIctCBBZh4AV9j/VtmA7XTCBh1 i65G4TZicoH9iU08TMxJ+R5XndPkLC5UUIkUNeWZMJEUBC5Bdw08TRI0CUOkF2L59QS5 9TS2c6bmRIXfArvF0Aym+7Q2VNJAYibihISU002c9S/9s52hvVC0FPmGChEwtYj+dhg+ gy2Xevm5mDIp3CE10PY9WLE/YJqewaZJzi9/Tb7jcB8wUE/qcxp2xJ12L8z8JpLxK4jC mSDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=W8qheqqE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 5si12574172pgf.579.2018.12.11.05.46.04; Tue, 11 Dec 2018 05:46:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=W8qheqqE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726702AbeLKNpD (ORCPT + 99 others); Tue, 11 Dec 2018 08:45:03 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:44936 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbeLKNpD (ORCPT ); Tue, 11 Dec 2018 08:45:03 -0500 Received: by mail-io1-f66.google.com with SMTP id r200so11768687iod.11 for ; Tue, 11 Dec 2018 05:45:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z9sQkAAtn2j+B/eG6nV+WxPFHWxvsOW4cNfp2WIK/CQ=; b=W8qheqqEnn3cGQbnEGKZ2cUmE3ClyYDHisWwH9SJ15ifncbKC5FuoDZHHGH+YRdz2Y lS3TuH2JtgD6a6WbDbW6vfY9eOhTwOqMhOl9MDsnP2+x7zSd5WjpR8Y854pbCHsXl8Zj tFaCN+bu5zKtvSrwEHBD5VvIvVgHOzeciXH8o4+JIV1S2Mq/AL74C7948e9hO+71W13m ieRenRt7V+rLi4FNWwbfQFJYoPkEyObA7M3Nui17Rx5YkAspRlKwt7uhGkRE1LEhD+RL AWoZPu/TT/l51Y9//fbKiYFCQjFPRR2UZ0nvf6QFGJQJ09co+9japNfw19IHJGRp3mze 26pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z9sQkAAtn2j+B/eG6nV+WxPFHWxvsOW4cNfp2WIK/CQ=; b=rWoNTts+E+MimN0Oq2jH/baVCfLdNUx6qyCHief4E/gYbSb+ucd5adIzj9H7E6Uv28 Rv2KIm2XzfkeXFvbLvfNLPIgNzop5gIuNYKIPT4lBVchI22U2cHmiViBJi/vGssSGOsL W0+7nGrTUSBJlkS36Y4zr2/U8Vw8tuoAKFmREwvLQhqjURtpG6kIMX8XMj7cLcO8ABB8 xapgcvomRUAzgykQrvPX74szbSwtpdeu/wWAxi+TLluTSWdg1bOwuH7WcfIz8ED75JJN XQoNfthiqLsmswpA5f9oeaTsAQm8+na54g6paf+M5iKQqb1ZXdO3eDu3XYFmgKCMThzw g3fQ== X-Gm-Message-State: AA+aEWazti2x1qJIBg5mGIdA1BnFizDsZMpDrBI5scYfTOajYzNh8UA+ hfbfo7ZmK+Zcy3Tt3CZhUNO0jMYGfXl84gg2bQBwlQ== X-Received: by 2002:a5d:8491:: with SMTP id t17mr13057010iom.11.1544535901894; Tue, 11 Dec 2018 05:45:01 -0800 (PST) MIME-Version: 1.0 References: <20181211133453.2835077-1-arnd@arndb.de> In-Reply-To: <20181211133453.2835077-1-arnd@arndb.de> From: Dmitry Vyukov Date: Tue, 11 Dec 2018 14:44:50 +0100 Message-ID: Subject: Re: [PATCH] kasan: fix kasan_check_read/write definitions To: Arnd Bergmann Cc: Andrew Morton , Andrey Ryabinin , anders.roxell@linaro.org, Ard Biesheuvel , Will Deacon , Mark Rutland , Alexander Potapenko , Andrey Konovalov , Stephen Rothwell , kasan-dev , LKML , Linux-MM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 11, 2018 at 2:35 PM Arnd Bergmann wrote: > > Building little-endian allmodconfig kernels on arm64 started failing > with the generated atomic.h implementation, since we now try to call > kasan helpers from the EFI stub: > > aarch64-linux-gnu-ld: drivers/firmware/efi/libstub/arm-stub.stub.o: in function `atomic_set': > include/generated/atomic-instrumented.h:44: undefined reference to `__efistub_kasan_check_write' > > I suspect that we get similar problems in other files that explicitly > disable KASAN for some reason but call atomic_t based helper functions. > > We can fix this by checking the predefined __SANITIZE_ADDRESS__ macro > that the compiler sets instead of checking CONFIG_KASAN, but this in turn > requires a small hack in mm/kasan/common.c so we do see the extern > declaration there instead of the inline function. Alexander, I think you are doing a similar thing for similar reasons in KMSAN patch (see KMSAN_CHECK_ATOMIC_PARAMS): https://github.com/google/kmsan/commit/17ebbfe19624c84adf79b0e5a74fd258c49ff12b Namely, non-KMSAN-instrumented files must not get KMSAN callbacks from atomics too. Arnd patch does it the other way around: non-instrumented files need to opt-in instead of opt-out. Let's settle on a common way to do this, so that we can use it consistently across all tools. > Fixes: b1864b828644 ("locking/atomics: build atomic headers as required") > Reported-by: Anders Roxell > Signed-off-by: Arnd Bergmann > --- > include/linux/kasan-checks.h | 2 +- > mm/kasan/common.c | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/linux/kasan-checks.h b/include/linux/kasan-checks.h > index d314150658a4..a61dc075e2ce 100644 > --- a/include/linux/kasan-checks.h > +++ b/include/linux/kasan-checks.h > @@ -2,7 +2,7 @@ > #ifndef _LINUX_KASAN_CHECKS_H > #define _LINUX_KASAN_CHECKS_H > > -#ifdef CONFIG_KASAN > +#if defined(__SANITIZE_ADDRESS__) || defined(__KASAN_INTERNAL) > void kasan_check_read(const volatile void *p, unsigned int size); > void kasan_check_write(const volatile void *p, unsigned int size); > #else > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 03d5d1374ca7..51a7932c33a3 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -14,6 +14,8 @@ > * > */ > > +#define __KASAN_INTERNAL > + > #include > #include > #include > -- > 2.20.0 >