Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181210210139.3336002-1-arnd@arndb.de> <CAKfTPtDPjqdRjRTt=DH2UwzfDXKDt8jNvxdC9Lsh20SvteMpSQ@mail.gmail.com>
In-Reply-To: <CAKfTPtDPjqdRjRTt=DH2UwzfDXKDt8jNvxdC9Lsh20SvteMpSQ@mail.gmail.com>
From:   Olof Johansson <olof@lixom.net>
Date:   Tue, 11 Dec 2018 07:20:22 -0800
Message-ID: <CAOesGMg-ZYzU=mA21dozNsJkFXkVN54Uv3rYpGmLsJEaKjA7mA@mail.gmail.com>
Subject: Re: [PATCH] sched/fair: move capacity_margin definition into #ifdef
To:     Vincent Guittot <vincent.guittot@linaro.org>
Cc:     Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Muchun Song <smuchun@gmail.com>, morten.rasmussen@arm.com,
        mgorman@techsingularity.net, srikar@linux.vnet.ibm.com,
        patrick.bellasi@arm.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Dec 10, 2018 at 11:46 PM Vincent Guittot
<vincent.guittot@linaro.org> wrote:
>
> Hi Arnd,
>
> On Mon, 10 Dec 2018 at 22:01, Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > Marking the variable static showed that it's only used for
> > SMP builds, as seen from this warning:
> >
> > kernel/sched/fair.c:119:21: error: 'capacity_margin' defined but not used [-Werror=unused-variable]
> >  static unsigned int capacity_margin   = 1280;
>
> Olof sent a similar patch 2 weeks ago: https://lkml.org/lkml/2018/11/26/115

Yeah, Ingo seems to be high latency right now. :( Anyone else able to
pick it up? Peter?


-Olof