Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp776191imu; Tue, 11 Dec 2018 07:24:54 -0800 (PST) X-Google-Smtp-Source: AFSGD/WeJW0bNAdKZUb76xwD2TX806JQop6WkD1YW0P2RJRu+5E88s092amCUIvydgxhf2Lbjp7t X-Received: by 2002:a62:c583:: with SMTP id j125mr16883105pfg.37.1544541894494; Tue, 11 Dec 2018 07:24:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544541894; cv=none; d=google.com; s=arc-20160816; b=q/Q3mWMLDdFuB/vwfUnHj0zgl+eY3UTFjOTQJdeykp4Dn52GksKDp0p9gKpeDUF6gW eC8ul4dsvj42p6vP3wTMeb+J+t0WGhKK0P2u1EOXZ/kWDg3BuKA4PLcN3XsSB7fDgOQi NWywE9sognPyuplneMD5NXpWfjC7ycLB/BnixdKeizl3IqMPmyWqSfGrz4E+Lgjkm7xp R4JyExs/h77DbO72TQ/XtW4VfWvbJt9fTQwuawnapZG+APvzuML19Rjid1ulKgCoGYPq TiiMHxmao+AHLNUAcLrkqxCl+sWGvsaT7YOXyJeqka/0duoa9qp7xbqPIs5RJl55feIu pyHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=CDY7mKJipgHFqkYla36GBWdvWpQ1+H0kjFrdP4NggSc=; b=g8SZj3BXysnAoqR89n9ulKSdz/rgNlF4vMCismmcJt2sMPOlEcElEzVflKCnSebAeX R6tgn+WicLblffmzwUKGXfyMvGJyJ7bQoC6WLj+YyTkQtNzDcZLyQ0S6sTz5tMUD0LDX 5tiXsci8A9sF/uhI0QCW0/f22WMPj+MxOQKHdde65bzNNXnBaF55OAiUKeFtzvOkSq2O TXjdk0R7lKQRpSmodzZ5Zq0p5cgTqp25LCk0xDxCFJH5Mf3Oy67OW1DIWBqxVY/113IJ WWjNVhi1o8z2Riw4jp1k1jqDY7vXLcRHl/ZIIPRag3vu6YkkhCtOOVFrAHgARIy+QrvD Bdyw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v10si12377816plp.183.2018.12.11.07.24.16; Tue, 11 Dec 2018 07:24:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726815AbeLKPVa (ORCPT + 99 others); Tue, 11 Dec 2018 10:21:30 -0500 Received: from imap1.codethink.co.uk ([176.9.8.82]:57998 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726241AbeLKPV3 (ORCPT ); Tue, 11 Dec 2018 10:21:29 -0500 Received: from office.codethink.co.uk ([148.252.241.226] helo=devhw0) by imap1.codethink.co.uk with esmtpsa (Exim 4.84_2 #1 (Debian)) id 1gWjqV-0002GA-PM; Tue, 11 Dec 2018 15:21:15 +0000 Received: from tpreston by devhw0 with local (Exim 4.89) (envelope-from ) id 1gWjqV-0002E9-0L; Tue, 11 Dec 2018 15:21:15 +0000 From: Thomas Preston To: akpm@linux-foundation.org, pmladek@suse.com, andriy.shevchenko@linux.intel.com, rostedt@goodmis.org, geert+renesas@glider.be, corbet@lwn.net, me@tobin.cc, sergey.senozhatsky@gmail.com, linux-kernel@vger.kernel.org Cc: Thomas Preston Subject: [PATCH 0/2] vsprintf Stop using obsolete simple_strtoul() Date: Tue, 11 Dec 2018 15:21:11 +0000 Message-Id: <20181211152113.8523-1-thomas.preston@codethink.co.uk> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, We've fixed a bug with sscanf(). When passing in a 16-digit hex-string like so: sscanf("fafafafa0b0b0b0b", "%8x%8x", &hi, &lo) The resulting value in hi is always 0. This is because vsscanf() uses the obsolete and broken functions simple_strtoul() and simple_strtoull(), which we have replaced. Many thanks, Thomas Thomas Preston (2): vsprintf: Specify type for union val members vsprintf: Stop using obsolete simple_strtoul() lib/vsprintf.c | 66 ++++++++++++++++++++++++++++++++++++++-------------------- 1 file changed, 43 insertions(+), 23 deletions(-) -- 2.11.0