Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp811640imu; Tue, 11 Dec 2018 07:58:41 -0800 (PST) X-Google-Smtp-Source: AFSGD/VcR79QpmxZzFMHzz1QnFIwHVAlEzIiZGuuVgpVxuJMCd9flrvl9FgOq8CwgRRi/jAE8C9I X-Received: by 2002:a17:902:8a95:: with SMTP id p21mr16885485plo.183.1544543921869; Tue, 11 Dec 2018 07:58:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544543921; cv=none; d=google.com; s=arc-20160816; b=MpjPkaEjpZzcqYadezSmSISmVAwcPJva88olq1q/zpXFu1/cSh069Qk6n49CpcUkyZ T7yrba62J+UjImHdqqRmQfuR5+fNl9UE3P5Dj1yh+s338EcNcyWGBj7Fwi48g5uLOFcC BCQx0N9CFQv8aU+OYefp1FEcktaLyzs3SQj6TkSF+7MviYayUHZOGhFMTSRIe2PEyojW jAiZ7DZFRhKQdzlFcBh2QAoiJXSjV4QdaiFInAhHP9Ledwp+iEKZZsUm9xINVewJORi+ 0Kt4XJlvS02QHWAXbKfdfGY9A/UglQMH/IxpGwz/jK0Fa2ixuRuDGq3W1bpPkIrVKS8D xrNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=JRIZi605tFzQkpHLKPOA1x7MZa550WrZKew8eM+M5/o=; b=uJaCdJTX5e1BHKpPMmVszwFoxu6wqkm4vJQU10hCySuSGJgwSwv2ASQ+CUgKPozPpT Ua56ClvNUA94V0f/jPOR9LgzfO0aC5LncIIlNlG/annTOw/3QdGC6PygcQWGhRdXEcIO k/ZonQayhm4fxJAqPjP/5qicUzm2OJCBQeAUQ9iVmZcenGap/yWwmF/RvDZMOLHTdgML 0NamKRFAdgpdP0raRTDSyR1tZAOsKnhvdn0reE19tXgjiokNN++6f6ShdA6wHgBV8ub8 eN/B+75jSYN6sYYzL0WGs0IfsGSGZPxio/lyY8NmY0d8VG4Z2bFlk9QxrHIkbzjOyRiK SuLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wfrrIl+X; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i198si13520416pfe.289.2018.12.11.07.58.04; Tue, 11 Dec 2018 07:58:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wfrrIl+X; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730131AbeLKPzY (ORCPT + 99 others); Tue, 11 Dec 2018 10:55:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:44036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730357AbeLKPzW (ORCPT ); Tue, 11 Dec 2018 10:55:22 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 751C82146F; Tue, 11 Dec 2018 15:55:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544543722; bh=NpVw8TFo+75Ye6QSzYp35tGYf1GLwYOQ0138JmVeEzo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wfrrIl+X0D8cBKd/0frQM4XffjRHpUNMB7mD3oDo+U+ks2kgStsx1rllTNgBdrKOT KjEtd9oyb8s+DLXvkCjfy4m97brnz1qrHmnq1kKz2KQJn7f00wW7pv/JMhoQ+VhCSr +8hLOM/SIb+47YEkA+Va/OiLcxuJfBGsstduiuzY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Kalle Valo , Sasha Levin Subject: [PATCH 4.19 006/118] brcmutil: really fix decoding channel info for 160 MHz bandwidth Date: Tue, 11 Dec 2018 16:40:25 +0100 Message-Id: <20181211151644.478944899@linuxfoundation.org> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20181211151644.216668863@linuxfoundation.org> References: <20181211151644.216668863@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 3401d42c7ea2d064d15c66698ff8eb96553179ce ] Previous commit /adding/ support for 160 MHz chanspecs was incomplete. It didn't set bandwidth info and didn't extract control channel info. As the result it was also using uninitialized "sb" var. This change has been tested for two chanspecs found to be reported by some devices/firmwares: 1) 60/160 (0xee32) Before: chnum:50 control_ch_num:36 After: chnum:50 control_ch_num:60 2) 120/160 (0xed72) Before: chnum:114 control_ch_num:100 After: chnum:114 control_ch_num:120 Fixes: 330994e8e8ec ("brcmfmac: fix for proper support of 160MHz bandwidth") Signed-off-by: Rafał Miłecki Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c b/drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c index e7584b842dce..eb5db94f5745 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c @@ -193,6 +193,9 @@ static void brcmu_d11ac_decchspec(struct brcmu_chan *ch) } break; case BRCMU_CHSPEC_D11AC_BW_160: + ch->bw = BRCMU_CHAN_BW_160; + ch->sb = brcmu_maskget16(ch->chspec, BRCMU_CHSPEC_D11AC_SB_MASK, + BRCMU_CHSPEC_D11AC_SB_SHIFT); switch (ch->sb) { case BRCMU_CHAN_SB_LLL: ch->control_ch_num -= CH_70MHZ_APART; -- 2.19.1