Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp814937imu; Tue, 11 Dec 2018 08:01:19 -0800 (PST) X-Google-Smtp-Source: AFSGD/VW6tgJCWlf7YJMrmuZENfMDgc5a2Q9lTNOFIGo5kwegqZIpuFMVg+onGbKeYSPkzGXJcXK X-Received: by 2002:a17:902:b7c7:: with SMTP id v7mr16602488plz.75.1544544078986; Tue, 11 Dec 2018 08:01:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544544078; cv=none; d=google.com; s=arc-20160816; b=D72P5tDkuDU3lDf4TaAZ8igXC/xe/rmT7hwVztVeETefcqV2doBKWEb3GnGAwnlFxA HmIPkHc2zAPXCNKHweWDz1YsG5q0GQaRfzfTS/VpBwbM2dwdbd0cCptryBOY23KPB8Ih fkBk1P6H9w4UAhuURI3G/TULRo4RB/3+Tcb1tjQxD+gr9w8XT7P6gqDg231+9XuMkF63 mz46Hi8aTNmD5F1N4GGtbGZzDLfHE1UBuemPSC0eaUVwVI0LIzFwKvi4hbAcjEl5KbNc c/1veBcAvN/0MAwflhDoPRT5KKYvaAGwHrBz524wLlzSJcLKc7lFIusKUxJReiMI4HMN H/pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=lj8m9oQXkgVrPz/UP4StiwDJYaWJHyVvwlqBmaAf/Qk=; b=xKzX6dLwTXE3j1vtpl8Xmb8E9NUAevNga8MDrJYuzf6S1u5sGt5IkCvPTLw1NE3tfA oZ6/gqC5zAj/HAmYnix+SVGmLMWuVJv4gT+9HwnwI7uSk5N79TDQzW3AvoshhLVvsB4s l9uCSkWDKwNZ9bwm56wIZzteDW8g36m4blICvhOUEkSoO+ey/KKVFZUquloWlcTtW9Lk +dB6mFotV4XdCrdgbN2iSieXthlRpDqnpkEWOKPXZPLeb75aMqG2YM3mC0PIik0BBn+f fiQKxqd8E20pSOIlLny67l98VExuXeXgBCW02jqAOZ9xlPXUGLxqY1FrUO2vUNSTPka3 mUBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=maxpEYyn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t3si12200797pgl.108.2018.12.11.08.01.04; Tue, 11 Dec 2018 08:01:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=maxpEYyn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731108AbeLKP64 (ORCPT + 99 others); Tue, 11 Dec 2018 10:58:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:48468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731102AbeLKP6x (ORCPT ); Tue, 11 Dec 2018 10:58:53 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C28522145D; Tue, 11 Dec 2018 15:58:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544543933; bh=rJmvEOCrS+ivRRR8gypou3uNE1WonnB+MKK/NlAfXy0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=maxpEYynHwmKXDVKYeAgciaXRuoknUS0KrY3LIZGRYprzFlnTHw1/b3ck7FqFBxL2 4RIPvTnMiAG0BrhgX0BFSqqeP4fRB9quiV52daW/5SrtVkqoIcakxFZJ7c9cXPdzKr G7qsjYjSQgQz/YoT5pTM5SAKi5ILqdojZ5VHh7I0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yan-Hsuan Chuang , Larry Finger , Johannes Berg Subject: [PATCH 4.19 113/118] mac80211: fix GFP_KERNEL under tasklet context Date: Tue, 11 Dec 2018 16:42:12 +0100 Message-Id: <20181211151648.825577652@linuxfoundation.org> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20181211151644.216668863@linuxfoundation.org> References: <20181211151644.216668863@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yan-Hsuan Chuang commit c752cac9db1b0c469db7ba9d17af4ba708984db5 upstream. cfg80211_sta_opmode_change_notify needs a gfp_t flag to hint the nl80211 stack when allocating new skb, but it is called under tasklet context here with GFP_KERNEL and kernel will yield a warning about it. Cc: stable@vger.kernel.org Fixes: ff84e7bfe176 ("mac80211: Add support to notify ht/vht opmode modification.") Signed-off-by: Yan-Hsuan Chuang ACKed-by: Larry Finger Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- net/mac80211/rx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/mac80211/rx.c +++ b/net/mac80211/rx.c @@ -3029,7 +3029,7 @@ ieee80211_rx_h_action(struct ieee80211_r cfg80211_sta_opmode_change_notify(sdata->dev, rx->sta->addr, &sta_opmode, - GFP_KERNEL); + GFP_ATOMIC); goto handled; } case WLAN_HT_ACTION_NOTIFY_CHANWIDTH: { @@ -3066,7 +3066,7 @@ ieee80211_rx_h_action(struct ieee80211_r cfg80211_sta_opmode_change_notify(sdata->dev, rx->sta->addr, &sta_opmode, - GFP_KERNEL); + GFP_ATOMIC); goto handled; } default: