Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp824620imu; Tue, 11 Dec 2018 08:08:32 -0800 (PST) X-Google-Smtp-Source: AFSGD/WSGL6uRMLJeyg5JELytBjVYLnZSdXRg8pDBLgf3E46y31opSPsP9zC/BCVmYuhZYjGL2de X-Received: by 2002:a63:91c1:: with SMTP id l184mr15146100pge.29.1544544512745; Tue, 11 Dec 2018 08:08:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544544512; cv=none; d=google.com; s=arc-20160816; b=QVW4ap4e32b3LAdR2GmPdrDpu5OJK1u7s25RyiBYoUBhiC+ET1yA8OpFEjeg51cNg/ GU1mG34Iho/GcbOV9BrqEHttqAHl1LRzIxsoKesT+iPhyLJq9RrubA4UB+HG3clH2SNx AYXVQslAKFQ25AMxkjoQgcuY16bkONcCxH5C4WA4aM8O+bxeLxpD8Q5GkZkpoemO12Dc Hk8ECDuIDTEn378Az/hJfw4posel9xj8duEI+TdSDy7w7PN9KjUo3zwph+UsKO2nhUIg rSTbgrocuG4IufXhhY/b/ilZZL7bnOLC31py+XtJgU7/S21G9pqKMLBjoglubKFHy8Nl FkqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UENA+dfPWCINFR91CyYTVRPwwKDjPkmqQpvexRJysLk=; b=anyFkaEandx4gLba/aLFdRmj1kbGFby1zDxUYkR4ZP19l9ovls5BUN54QhlCppKeHG OdkR7UZO7Zzhy9TQP+BW3ogmFDpSeypOPA6HVACAFtPDUEIZKK5AgHmMdtaRsK1mpXuz KNLxeGmt/s2rU6W1UGOxVtls24Ue6+XHH8s2YOtVkzCJHVEXApoUP6gMV5Wz4HUEXb1n lHGQYSyadlpkkMo+/C9O80lLqRYY+cCfxlnKrhtALlidXgJtJvtoTA7ONL/gzR1t47Ak MQ6TYfSnGpDL0i1cQGf78UCq7mBIxXX8IxI80Qg86CGIGZ/jIGgoNMBXmXf6c19+f5Lu SojA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gGBvFG2V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p15si12867123plq.24.2018.12.11.08.08.18; Tue, 11 Dec 2018 08:08:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gGBvFG2V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730790AbeLKQGb (ORCPT + 99 others); Tue, 11 Dec 2018 11:06:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:43098 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730105AbeLKPy2 (ORCPT ); Tue, 11 Dec 2018 10:54:28 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A89D2146D; Tue, 11 Dec 2018 15:54:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544543668; bh=2FHduYeVoT2nO9GLw8ujAMf2ZzEE/71ovSwwS/jNHUE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gGBvFG2VbSc86dnTSABZg5pTBibHOHxarbEn8w5+FQFbbthP72b4dge1/rEy7DotO WDhdekKL84pXa72ZmKqPHm3Fx/RddrgmNAQlL7O4/HeLluUna7uNJGtOnd8iJlmeu7 KS7K8QNPxY7DWJHoHfVj0hJ6fURjS8pVkYqBfP9E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Denis Bolotin , Michal Kalderon , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 018/118] qed: Fix PTT leak in qed_drain() Date: Tue, 11 Dec 2018 16:40:37 +0100 Message-Id: <20181211151644.966103989@linuxfoundation.org> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20181211151644.216668863@linuxfoundation.org> References: <20181211151644.216668863@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 9aaa4e8ba12972d674caeefbc5f88d83235dd697 ] Release PTT before entering error flow. Signed-off-by: Denis Bolotin Signed-off-by: Michal Kalderon Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qed/qed_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c index 2094d86a7a08..cf3b0e3dc350 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c @@ -1634,9 +1634,9 @@ static int qed_drain(struct qed_dev *cdev) return -EBUSY; } rc = qed_mcp_drain(hwfn, ptt); + qed_ptt_release(hwfn, ptt); if (rc) return rc; - qed_ptt_release(hwfn, ptt); } return 0; -- 2.19.1